x86: Do not assign values to unaligned pointer to 128 bits
PATCH v2 1/1 x86: Do not assign values to unaligned pointer to 128 bits
When compiled with clang, the following statement gets converted into a movaps instructions.
mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;
Since mem is an unaligned pointer to a union of an sse, we get a GP when running.
All we want is to make the values between mem and v different for this testcase, so let's just memset the pointer at mem, and convert to uint32_t pointer. Then the compiler will not assume the pointer is aligned to 128 bits.
emulator.c")
--- x86/emulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
x86/emulator.c +3 -3
@@ -716,12 +716,12 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// test unaligned access for movups, movupd and movaps v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned" ); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movupd %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movupd unaligned" ); exceptions =0 ;
@@ -734,7 +734,7 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// setup memory for cross page access mem = (sse_union *)(&bytes[4096 -8 ]); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned crosspage" );
Signature · 1 line
2.31.1.607.g51e8a6a459-goog
Sean Christopherson
reviewerQuoted 25 lines · Jacob Xu
When compiled with clang, the following statement gets converted into a movaps instructions.
mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;Since mem is an unaligned pointer to a union of an sse, we get a GP when running.
All we want is to make the values between mem and v different for this testcase, so let's just memset the pointer at mem, and convert to
uint32_tpointer. Then the compiler will not assume the pointer is aligned to 128 bits.Fixes e5e76263b5 ("x86: add additional test cases for sse exceptions to
emulator.c")Signed-off-by Jacob Xu <[email protected]>--- x86/emulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)x86/emulator.c +0
-0
x86/emulator.c static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem) · line 719
Quoted 5 lines
x86/emulator.c +1
-1@@ -716,12 +716,12 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// test unaligned access for movups, movupd and movaps v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem));
memset() takes a void *, which it casts to an char, i.e. it works on one byte at a time. Casting to a uint32_t won't make it write the full "0xdecafbad", it will just repease 0xad over and over.
The size needs to be sizeof(*mem), i.e. the size of the object that mem points to, not the size of the pointer's storage.
Quoted 21 lines
x86/emulator.c +2
-2asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned" ); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movupd %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movupd unaligned" ); exceptions =0 ;@@ -734,7 +734,7 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// setup memory for cross page access mem = (sse_union *)(&bytes[4096 -8 ]); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned crosspage" );Signature · 1 line
2.31.1.607.g51e8a6a459-goog
Quoted 1 line
memset()takes a void *, which it casts to an char, i.e. it works on one byte at
a time.
Huh, TIL. Based on this I'd thought that I don't need a cast at all, but doing so actually results in a movaps instruction. I've changed the cast back to (uint8_t *).
Quoted 1 line
The size needs to be
sizeof(*mem)
Bah, thanks for catching that.
I've updated it below.
--- x86/emulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
x86/emulator.c +0 -0
@@ -716,12 +716,12 @@ static __attribute__((target("sse2"))) void
test_sse_exceptions(void *cross_mem)
// test unaligned access for movups, movupd and movaps
v.u[0] = 1; v.u[1] = 2; v.u[2] = 3; v.u[3] = 4;
- mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;
+ memset((uint8_t *)mem, 5, sizeof(*mem));
asm("movups %1, %0" : "=m"(*mem) : "x"(v.sse));
report(sseeq(&v, mem), "movups unaligned");
v.u[0] = 1; v.u[1] = 2; v.u[2] = 3; v.u[3] = 4;
- mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;
+ memset((uint8_t *)mem, 5, sizeof(*mem));
asm("movupd %1, %0" : "=m"(*mem) : "x"(v.sse));
report(sseeq(&v, mem), "movupd unaligned");
exceptions = 0;
@@ -734,7 +734,7 @@ static __attribute__((target("sse2"))) void
test_sse_exceptions(void *cross_mem)
// setup memory for cross page access
mem = (sse_union *)(&bytes[4096-8]);
v.u[0] = 1; v.u[1] = 2; v.u[2] = 3; v.u[3] = 4;- mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;
+ memset((uint8_t *)mem, 5, sizeof(*mem));
asm("movups %1, %0" : "=m"(*mem) : "x"(v.sse));
report(sseeq(&v, mem), "movups unaligned crosspage");--
Quoted 61 lines · Sean Christopherson
Quoted 25 lines · Jacob Xu
When compiled with clang, the following statement gets converted into a movaps instructions.
mem->u[0] = 5; mem->u[1] = 6; mem->u[2] = 7; mem->u[3] = 8;Since mem is an unaligned pointer to a union of an sse, we get a GP when running.
All we want is to make the values between mem and v different for this testcase, so let's just memset the pointer at mem, and convert to
uint32_tpointer. Then the compiler will not assume the pointer is aligned to 128 bits.Fixes e5e76263b5 ("x86: add additional test cases for sse exceptions to
emulator.c")Signed-off-by Jacob Xu <[email protected]>--- x86/emulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)x86/emulator.c +0
-0x86/emulator.c static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem) · line 719
Quoted 5 lines
x86/emulator.c +1
-1@@ -716,12 +716,12 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// test unaligned access for movups, movupd and movaps v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem));
memset()takes a void *, which it casts to an char, i.e. it works on one byte at a time. Casting to auint32_twon't make it write the full "0xdecafbad", it will just repease0xadover and over.The size needs to be
sizeof(*mem), i.e. the size of the object that mem points to, not the size of the pointer's storage.Quoted 21 lines
x86/emulator.c +2
-3asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned" ); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movupd %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movupd unaligned" ); exceptions =0 ;@@ -734,7 +734,7 @@ static __attribute__((target("sse2"))) void test_sse_exceptions(void *cross_mem)// setup memory for cross page access mem = (sse_union *)(&bytes[4096 -8 ]); v.u[0 ] =1 ; v.u[1 ] =2 ; v.u[2 ] =3 ; v.u[3 ] =4 ; - mem->u[0 ] =5 ; mem->u[1 ] =6 ; mem->u[2 ] =7 ; mem->u[3 ] =8 ; +memset ((uint32_t *)mem,0xdecafbad ,sizeof (mem)); asm("movups %1, %0" :"=m" (*mem) :"x" (v.sse));report (sseeq (&v, mem),"movups unaligned crosspage" ); --2.31.1.607.g51e8a6a459-goog
Sean Christopherson
reviewerQuoted 4 lines · Jacob Xu
Quoted 1 line
memset()takes a void *, which it casts to an char, i.e. it works on one byte ata time.
Huh, TIL. Based on this I'd thought that I don't need a cast at all, but doing so actually results in a movaps instruction.
Ewwww. That's likely because emulator.c does:
#define memset __builtin_memset
and the compiler is clever enough to know that __attribute__((vector_size(16))) means the variable is (supposed to be) aligned.
Quoted 1 line
I've changed the cast back to (
uint8_t*).
I assume removing the above #define and grabbing memset() from string.c fixes the movaps generation? If so, that has my vote, as opposed to fudging around the compiler by casting to uint8_t *.
As evidenced by this issue, using the compiler's memset() in kvm-unit-tests seems inherently dangerous since the tests are often doing intentionally stupid things.
Quoted 6 lines · Jacob Xu
Quoted 2 lines
memset()takes a void *, which it casts to an char, i.e. it works on one byte ata time.
Huh, TIL. Based on this I'd thought that I don't need a cast at all, but doing so actually results in a movaps instruction. I've changed the cast back to (uint8_t*).
I'm pretty sure you're just getting lucky. If 'mem' is not 16-byte aligned, the behavior of the code is undefined. The compiler does not have to discard what it can infer about the alignment just because you cast 'mem' to a type with weaker alignment constraints.
Why does 'mem' need to have type 'sse_union *'? Why can't it just be declared as 'uint8_t *'? Just add a "memory" clobbers to the inline asm statements that use 'mem' as an SSE operand.
Of course, passing it as an argument to sseeq() also implies 16-byte alignment. Perhaps sseeq should take uint32_t pointers as arguments rather than sse_union pointers. I'm not convinced that the sse_union buys us anything other than trouble.
Quoted 6 lines
The compiler does not
have to discard what it can infer about the alignment just because you cast 'mem' to a type with weaker alignment constraints.Why does 'mem' need to have type '
sse_union*'? Why can't it just be declared as 'uint8_t*'?
Huh, I see. I'll just delete sse_union then and use uint32_t instead.
Quoted 4 lines
Ewwww. That's likely because
emulator.cdoes:
#define memset__builtin_memset
As evidenced by this issue, using the compiler'smemset()in kvm-unit-tests seems inherently dangerous since the tests are often doing intentionally stupid things.
I'll make a separate patch to remove this from emulator.c
Quoted 22 lines · Jim Mattson
Quoted 6 lines · Jacob Xu
Quoted 2 lines
memset()takes a void *, which it casts to an char, i.e. it works on one byte ata time.
Huh, TIL. Based on this I'd thought that I don't need a cast at all, but doing so actually results in a movaps instruction. I've changed the cast back to (uint8_t*).I'm pretty sure you're just getting lucky. If 'mem' is not 16-byte aligned, the behavior of the code is undefined. The compiler does not have to discard what it can infer about the alignment just because you cast 'mem' to a type with weaker alignment constraints.
Why does 'mem' need to have type '
sse_union*'? Why can't it just be declared as 'uint8_t*'? Just add a "memory" clobbers to the inline asm statements that use 'mem' as an SSE operand.Of course, passing it as an argument to
sseeq()also implies 16-byte alignment. Perhaps sseeq should takeuint32_tpointers as arguments rather thansse_unionpointers. I'm not convinced that thesse_unionbuys us anything other than trouble.