Skip to contentSkip to conversation

*** SUBJECT HERE ***

PATCH In review Saurav Girepunje 2 participants 5 messages May 7, 2021 1 message not in the archive

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

Saurav Girepunje

author
#0 lore raw

cover *** SUBJECT HERE ***

*** BLURB HERE ***

Saurav Girepunje (2):
usb: musb: remove unused function argument
usb: musb: Remove unused function argument

 drivers/usb/musb/musb_host.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

--
2.25.1

author
#1 lore raw

PATCH 1/2 usb: musb: remove unused function argument

Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb() in musb_host.c

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/usb/musb/musb_host.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/usb/musb/musb_host.c +2 -7
index 8b7d22a0c0fb..978d822af2c5 100644
@@ -602,12 +602,8 @@ static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
 	musb_writew(epio, MUSB_TXCSR, csr);
 }
 
-static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
-					   struct musb_hw_ep *hw_ep,
-					   struct musb_qh *qh,
+static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
 					   struct urb *urb,
-					   u32 offset,
-					   u32 *length,
 					   u8 *mode)
 {
 	struct dma_channel *channel = hw_ep->tx_channel;

@@ -633,8 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
 		musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
 					    &length, &mode);
 	else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
-		musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
-					       &length, &mode);
+		musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
 	else
 		return false;

--
2.25.1

A message that is not in the archive (sent off-list or not yet received): PH0PR04MB73174B65B1619C64549E34049E579@PH0PR04MB7317.namprd04.prod.outlook.com

author
#3 lore raw

Re: [PATCH 1/2] usb: musb: remove unused function argument

Quoted 46 lines · SAURAV GIREPUNJE

________________________________
From: Saurav Girepunje <[email protected]>
Sent: Friday, May 7, 2021 10:11 AM
To: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: [PATCH 1/2] usb: musb: remove unused function argument

Remove unused function argument from musb_tx_dma_set_mode_cppi_tusb() in musb_host.c

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/usb/musb/musb_host.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/usb/musb/musb_host.c +2 -8
index 8b7d22a0c0fb..978d822af2c5 100644
@@ -602,12 +602,8 @@ static void musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
         musb_writew(epio, MUSB_TXCSR, csr);
 }
 
-static void musb_tx_dma_set_mode_cppi_tusb(struct dma_controller *dma,
-                                          struct musb_hw_ep *hw_ep,
-                                          struct musb_qh *qh,
+static void musb_tx_dma_set_mode_cppi_tusb(struct musb_hw_ep *hw_ep,
                                            struct urb *urb,
-                                          u32 offset,
-                                          u32 *length,
                                            u8 *mode)
 {
         struct dma_channel *channel = hw_ep->tx_channel;

@@ -633,8 +629,7 @@ static bool musb_tx_dma_program(struct dma_controller *dma,
                 musb_tx_dma_set_mode_mentor(dma, hw_ep, qh, urb, offset,
                                             &length, &mode);
         else if (is_cppi_enabled(hw_ep->musb) || tusb_dma_omap(hw_ep->musb))
-               musb_tx_dma_set_mode_cppi_tusb(dma, hw_ep, qh, urb, offset,
-                                              &length, &mode);
+               musb_tx_dma_set_mode_cppi_tusb(hw_ep, urb, &mode);
         else
                 return false;
 
--
Quoted 2 lines

2.25.1

Please ignore this mail.

maintainer
#4 lore raw
In reply to Saurav Girepunje
Quoted 1 line · Saurav Girepunje

*** BLURB HERE ***

No subject or blurb?

Quoted 4 lines

Saurav Girepunje (2):
usb: musb: remove unused function argument
usb: musb: Remove unused function argument

Again, these have the same subject line, which is not allowed.

Please fix up and resend them all (we only saw 1 on the mailing list.)

thanks,

greg k-h

author
#5 lore raw
Quoted 10 lines · Greg KH
Quoted 1 line · Saurav Girepunje

*** BLURB HERE ***

No subject or blurb?

Quoted 4 lines

Saurav Girepunje (2):
usb: musb: remove unused function argument
usb: musb: Remove unused function argument

Quoted 7 lines

Again, these have the same subject line, which is not allowed.

Please fix up and resend them all (we only saw 1 on the mailing list.)

thanks,

greg k-h

Plese ignore this mail.

I was trying to learn how to send pathes with cover letter from below
https://kernelnewbies.org/FirstKernelPatch

and did not realized that on sample command set the cc list
git format-patch -o /tmp/ --cover-letter -n --thread=shallow --cc="[email protected]" 3b12c21^..b7ca36a