Skip to contentSkip to conversation

package/dhcp: add host-gawk optional dependency

PATCH New Heiko Thiery 3 participants 3 messages May 7, 2021 – May 23, 2021

lore
Share & tools
lore

Heiko Thiery

author
#0 lore raw

PATCH v2 1/1 package/dhcp: add host-gawk optional dependency

On hosts where gawk is not available, it is not possible to build the package with server option (BR2_PACKAGE_DHCP_SERVER).
The build goes through without errors but the binaries are not created and installed. The reason is that autotools cannot find gawk.

Fixes Bug 13781
Reported-by Kay Jeschonneck <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>

---
v2:
- set to correct bug number

 package/dhcp/dhcp.mk | 1 +
 1 file changed, 1 insertion(+)
package/dhcp/dhcp.mk +1 -0
index 988c7792dc..8d7157f357 100644
@@ -55,6 +55,7 @@ define DHCP_INSTALL_LIBS
 endef
 
 ifeq ($(BR2_PACKAGE_DHCP_SERVER),y)
+DHCP_DEPENDENCIES += host-gawk
 define DHCP_INSTALL_CTL_LIBS
 	$(MAKE) -C $(@D)/dhcpctl install-exec DESTDIR=$(TARGET_DIR)
 endef
Signature · 1 line
2.30.0
Applied
#1 lore raw

PATCH v2 1/1 package/dhcp: add host-gawk optional dependency

Quoted 9 lines · Heiko Thiery

On hosts where gawk is not available, it is not possible to build the package with server option (BR2_PACKAGE_DHCP_SERVER).
The build goes through without errors but the binaries are not created and installed. The reason is that autotools cannot find gawk.

Fixes Bug 13781
Reported-by Kay Jeschonneck <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>

Applied to master, thanks.

Regards,
Arnout

Quoted 20 lines

---
v2:
- set to correct bug number

 package/dhcp/dhcp.mk | 1 +
 1 file changed, 1 insertion(+)
package/dhcp/dhcp.mk +1 -0
index 988c7792dc..8d7157f357 100644
@@ -55,6 +55,7 @@ define DHCP_INSTALL_LIBS
 endef
 
 ifeq ($(BR2_PACKAGE_DHCP_SERVER),y)
+DHCP_DEPENDENCIES += host-gawk
 define DHCP_INSTALL_CTL_LIBS
 	$(MAKE) -C $(@D)/dhcpctl install-exec DESTDIR=$(TARGET_DIR)
 endef
#2 lore raw

PATCH v2 1/1 package/dhcp: add host-gawk optional dependency

In reply to Heiko Thiery
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Heiko" == Heiko Thiery <[email protected]> writes:

On hosts where gawk is not available, it is not possible to build the package with server option (BR2_PACKAGE_DHCP_SERVER).
The build goes through without errors but the binaries are not created and installed. The reason is that autotools cannot find gawk.

Quoted 7 lines
Fixes Bug 13781
Reported-by Kay Jeschonneck <[email protected]>
Signed-off-by Heiko Thiery <[email protected]>

---
v2:
- set to correct bug number

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard