Skip to contentSkip to conversation

RDMA/rxe: remove the unnecessary break

PATCH In review Zhu Yanjun 3 participants 3 messages May 9, 2021 – May 12, 2021

Subsystems (2)
lore
Share & tools
lore

Zhu Yanjun

author
#0 lore raw

PATCH 1/1 RDMA/rxe: remove the unnecessary break

From: Zhu Yanjun <[email protected]>

In the final default, the break is not necessary.

Fixes 8700e3e7c485 ("Soft RoCE driver")
---
 drivers/infiniband/sw/rxe/rxe_qp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_qp.c +0 -1
index 34ae957a315c..00588735744f 100644
@@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp,
 
 	default:
 		qp->ibqp.qp_num		= qpn;
-		break;
 	}
 
 	INIT_LIST_HEAD(&qp->grp_list);
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 4 lines · Zhu Yanjun

From: Zhu Yanjun <[email protected]>

In the final default, the break is not necessary.

Hi, Jason Gunthorpe and Leon Romanovsky

Gently ping

Zhu Yanjun

Quoted 22 lines
Fixes 8700e3e7c485 ("Soft RoCE driver")
---
 drivers/infiniband/sw/rxe/rxe_qp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_qp.c +0 -2
index 34ae957a315c..00588735744f 100644
@@ -186,7 +186,6 @@ static void rxe_qp_init_misc(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        default:
                qp->ibqp.qp_num         = qpn;
-               break;
        }
 
        INIT_LIST_HEAD(&qp->grp_list);
--

2.27.0

#2 lore raw
Quoted 9 lines · Zhu Yanjun
Quoted 4 lines · Zhu Yanjun

From: Zhu Yanjun <[email protected]>

In the final default, the break is not necessary.

Hi, Jason Gunthorpe and Leon Romanovsky

Gently ping

I'm not keen on this kind of churn

Jason