net: pch_gbe: fix and a few cleanups
Subsystems (2)
v3 cover net: pch_gbe: fix and a few cleanups
The series provides one fix (patch 1) for GPIO to be able to wait for the GPIO driver to appear. This is separated from the conversion to the GPIO descriptors (patch 2) in order to have a possibility for backporting. Patches 3 and 4 fix minor warnings from Sparse while moving to a new APIs. Patch 5 is MODULE_VERSION() clean up.
Tested on Intel Minnowboard (v1).
Since v3:
- rebased on top of v5.13-rc1
- added Tested-by (Flavio)
- added Reported-by to certain changes (LKP)
Since v2:
- added a few cleanups on top of the fix
Andy Shevchenko (5):
net: pch_gbe: Propagate error from devm_gpio_request_one()
net: pch_gbe: Convert to use GPIO descriptors
net: pch_gbe: use readx_poll_timeout_atomic() variant
net: pch_gbe: Use proper accessors to BE data in pch_ptp_match()
net: pch_gbe: remove unneeded MODULE_VERSION() call
.../net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 2 - .../oki-semi/pch_gbe/pch_gbe_ethtool.c | 2 + .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 102 +++++++++--------- 3 files changed, 54 insertions(+), 52 deletions(-)
Signature · 1 line
2.30.2
PATCH v3 1/5 net: pch_gbe: Propagate error from devm_gpio_request_one()
If GPIO controller is not available yet we need to defer the probe of GBE until provider will become available.
While here, drop GPIOF_EXPORT because it's deprecated and may not be available.
--- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +7 -3
@@ -2532,9 +2532,13 @@ static int pch_gbe_probe(struct pci_dev *pdev, adapter->pdev = pdev; adapter->hw.back = adapter; adapter->hw.reg =pcim_iomap_table (pdev)[PCH_GBE_PCI_BAR ]; + adapter->pdata = (struct pch_gbe_privdata *)pci_id->driver_data; -if (adapter->pdata && adapter->pdata->platform_init) - adapter->pdata->platform_init (pdev); +if (adapter->pdata && adapter->pdata->platform_init) { + ret = adapter->pdata->platform_init (pdev); +if (ret) + goto err_free_netdev; + } adapter->ptp_pdev = pci_get_domain_bus_and_slot(pci_domain_nr(adapter->pdev->bus),
@@ -2629,7 +2633,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,*/ static int pch_gbe_minnow_platform_init (struct pci_dev *pdev) { -unsigned long flags =GPIOF_DIR_OUT |GPIOF_INIT_HIGH |GPIOF_EXPORT ; +unsigned long flags =GPIOF_OUT_INIT_HIGH ;unsigned gpio =MINNOW_PHY_RESET_GPIO ;int ret;
Signature · 1 line
2.30.2
PATCH v3 2/5 net: pch_gbe: Convert to use GPIO descriptors
In reply to Andy ShevchenkoThis switches the PCH GBE driver to use GPIO descriptors.
--- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 44 ++++++++++++++----- 1 file changed, 32 insertions(+), 12 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +32 -12
@@ -8,6 +8,9 @@#include "pch_gbe.h" #include "pch_gbe_phy.h" + +#include <linux/gpio/consumer.h> +#include <linux/gpio/machine.h> #include <linux/module.h> #include <linux/net_tstamp.h> #include <linux/ptp_classify.h>
@@ -97,8 +100,6 @@ const char pch_driver_version[] = DRV_VERSION;#define PTP_L4_MULTICAST_SA "01:00:5e:00:01:81"#define PTP_L2_MULTICAST_SA "01:1b:19:00:00:00" -#define MINNOW_PHY_RESET_GPIO 13 -static int pch_gbe_mdio_read (struct net_device *netdev,int addr,int reg);static void pch_gbe_mdio_write (struct net_device *netdev,int addr,int reg,int data);
@@ -2628,26 +2629,45 @@ static int pch_gbe_probe(struct pci_dev *pdev,return ret; } +static void pch_gbe_gpio_remove_table (void *table) +{ +gpiod_remove_lookup_table (table); +} + +static int pch_gbe_gpio_add_table (struct device *dev,void *table) +{ +gpiod_add_lookup_table (table); +return devm_add_action_or_reset (dev, pch_gbe_gpio_remove_table, table); +} + +static struct gpiod_lookup_table pch_gbe_minnow_gpio_table = { + .dev_id ="0000:02:00.1" , + .table = { +GPIO_LOOKUP ("sch_gpio.33158" ,13 ,NULL ,GPIO_ACTIVE_LOW ), + {} + }, +}; +/* The AR803X PHY on the MinnowBoard requires a physical pin to be toggled to * ensure it is awake for probe and init. Request the line and reset the PHY. */ static int pch_gbe_minnow_platform_init (struct pci_dev *pdev) { -unsigned long flags =GPIOF_OUT_INIT_HIGH ; -unsigned gpio =MINNOW_PHY_RESET_GPIO ; +struct gpio_desc *gpiod;int ret; - ret =devm_gpio_request_one (&pdev->dev, gpio, flags, -"minnow_phy_reset" ); -if (ret) { -dev_err (&pdev->dev, -"ERR: Can't request PHY reset GPIO line '%d'\n" , gpio); + ret =pch_gbe_gpio_add_table (&pdev->dev, &pch_gbe_minnow_gpio_table); +if (ret)return ret; - } -gpio_set_value (gpio,0 ); + gpiod =devm_gpiod_get (&pdev->dev,NULL ,GPIOD_OUT_HIGH ); +if (IS_ERR (gpiod)) +return dev_err_probe (&pdev->dev,PTR_ERR (gpiod), +"Can't request PHY reset GPIO line\n" ); + +gpiod_set_value (gpiod,1 );usleep_range (1250 ,1500 ); -gpio_set_value (gpio,1 ); +gpiod_set_value (gpiod,0 );usleep_range (1250 ,1500 );return ret;
Signature · 1 line
2.30.2
PATCH v3 3/5 net: pch_gbe: use readx_poll_timeout_atomic() variant
In reply to Andy ShevchenkoUse readx_poll_timeout_atomic() instead of open coded variants.
While at it, add __iomem attribute to the parameter of pch_gbe_wait_clr_bit(). This in particular will fix a lot of warnings detected by Sparse, e.g.
.../pch_gbe_main.c:308:26: warning: incorrect type in argument 1 (different address spaces).../pch_gbe_main.c:308:26: expected void const [noderef] __iomem *.../pch_gbe_main.c:308:26: got void *reg
--- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 27 ++++++------------- 1 file changed, 8 insertions(+), 19 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +8 -19
@@ -11,6 +11,7 @@#include <linux/gpio/consumer.h> #include <linux/gpio/machine.h> +#include <linux/iopoll.h> #include <linux/module.h> #include <linux/net_tstamp.h> #include <linux/ptp_classify.h>
@@ -299,15 +300,12 @@ static s32 pch_gbe_mac_read_mac_addr(struct pch_gbe_hw *hw)* @reg: Pointer of register * @bit: Busy bit */ -static void pch_gbe_wait_clr_bit (void *reg,u32 bit) +static void pch_gbe_wait_clr_bit (void __iomem *reg,u32 bit) {u32 tmp;/* wait busy */ - tmp =1000 ; -while ((ioread32 (reg) & bit) && --tmp) -cpu_relax (); -if (!tmp) +if (readx_poll_timeout_atomic (ioread32, reg, tmp, !(tmp & bit),0 ,10 ))pr_err ("Error: busy bit is not cleared\n" ); }
@@ -491,18 +489,13 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg, u16 data) {struct pch_gbe_adapter *adapter =pch_gbe_hw_to_adapter (hw); -u32 data_out =0 ; -unsigned int i;unsigned long flags; +u32 data_out;spin_lock_irqsave (&hw->miim_lock, flags); -for (i =100 ; i; --i) { -if ((ioread32 (&hw->reg->MIIM) &PCH_GBE_MIIM_OPER_READY )) -break ; -udelay (20 ); - } -if (i ==0 ) { +if (readx_poll_timeout_atomic (ioread32, &hw->reg->MIIM, data_out, + data_out &PCH_GBE_MIIM_OPER_READY ,20 ,2000 )) {netdev_err (adapter->netdev,"pch-gbe.miim won't go Ready\n" );spin_unlock_irqrestore (&hw->miim_lock, flags);return 0 ;/* No way to indicate timeout error */
@@ -510,12 +503,8 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg,iowrite32 (((reg <<PCH_GBE_MIIM_REG_ADDR_SHIFT ) | (addr <<PCH_GBE_MIIM_PHY_ADDR_SHIFT ) | dir | data), &hw->reg->MIIM); -for (i =0 ; i <100 ; i++) { -udelay (20 ); - data_out =ioread32 (&hw->reg->MIIM); -if ((data_out &PCH_GBE_MIIM_OPER_READY )) -break ; - } +readx_poll_timeout_atomic (ioread32, &hw->reg->MIIM, data_out, + data_out &PCH_GBE_MIIM_OPER_READY ,20 ,2000 );spin_unlock_irqrestore (&hw->miim_lock, flags); netdev_dbg(adapter->netdev, "PHY %s: reg=%d, data=0x%04X\n",
Signature · 1 line
2.30.2
PATCH v3 4/5 net: pch_gbe: Use proper accessors to BE data in pch_ptp_match()
In reply to Andy ShevchenkoSparse is not happy about handling of strict types in pch_ptp_match():
.../pch_gbe_main.c:158:33: warning: incorrect type in argument 2 (different base types)
.../pch_gbe_main.c:158:33: expected unsigned short [usertype] uid_hi
.../pch_gbe_main.c:158:33: got restricted __be16 [usertype]
.../pch_gbe_main.c:158:45: warning: incorrect type in argument 3 (different base types)
.../pch_gbe_main.c:158:45: expected unsigned int [usertype] uid_lo
.../pch_gbe_main.c:158:45: got restricted __be32 [usertype]
.../pch_gbe_main.c:158:56: warning: incorrect type in argument 4 (different base types)
.../pch_gbe_main.c:158:56: expected unsigned short [usertype] seqid
.../pch_gbe_main.c:158:56: got restricted __be16 [usertype]
Fix that by switching to use proper accessors to BE data.
--- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +6 -13
@@ -110,7 +110,7 @@ static int pch_ptp_match(struct sk_buff *skb, u16 uid_hi, u32 uid_lo, u16 seqid) {u8 *data = skb->data;unsigned int offset; -u16 *hi, *id; +u16 hi, id;u32 lo;if (ptp_classify_raw (skb) ==PTP_CLASS_NONE )
@@ -121,14 +121,11 @@ static int pch_ptp_match(struct sk_buff *skb, u16 uid_hi, u32 uid_lo, u16 seqid)if (skb->len < offset +OFF_PTP_SEQUENCE_ID +sizeof (seqid))return 0 ; - hi = (u16 *)(data + offset +OFF_PTP_SOURCE_UUID ); - id = (u16 *)(data + offset +OFF_PTP_SEQUENCE_ID ); + hi =get_unaligned_be16 (data + offset +OFF_PTP_SOURCE_UUID +0 ); + lo =get_unaligned_be32 (data + offset +OFF_PTP_SOURCE_UUID +2 ); + id =get_unaligned_be16 (data + offset +OFF_PTP_SEQUENCE_ID ); -memcpy (&lo, &hi[1 ],sizeof (lo)); - -return (uid_hi == *hi && - uid_lo == lo && - seqid == *id); +return (uid_hi == hi && uid_lo == lo && seqid == id); } static void
@@ -138,7 +135,6 @@ pch_rx_timestamp(struct pch_gbe_adapter *adapter, struct sk_buff *skb)struct pci_dev *pdev;u64 ns;u32 hi, lo, val; -u16 uid, seq;if (!adapter->hwts_rx_en)return ;
@@ -154,10 +150,7 @@ pch_rx_timestamp(struct pch_gbe_adapter *adapter, struct sk_buff *skb) lo =pch_src_uuid_lo_read (pdev); hi =pch_src_uuid_hi_read (pdev); - uid = hi &0xffff ; - seq = (hi >>16 ) &0xffff ; - -if (!pch_ptp_match (skb,htons (uid),htonl (lo),htons (seq))) +if (!pch_ptp_match (skb, hi, lo, hi >>16 )) goto out; ns =pch_rx_snap_read (pdev);
Signature · 1 line
2.30.2
PATCH v3 5/5 net: pch_gbe: remove unneeded MODULE_VERSION() call
In reply to Andy ShevchenkoRemove MODULE_VERSION(), as it doesn't seem to serve any practical purpose. For in-tree drivers, the kernel version matters. The code received lots of changes, but module version remained constant, since the driver landed in mainline. So, this version doesn't seem have any practical meaning anymore.
--- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 2 -- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 2 ++ drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 4 ---- 3 files changed, 2 insertions(+), 6 deletions(-)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h +0 -2
@@ -596,8 +596,6 @@ struct pch_gbe_adapter {#define pch_gbe_hw_to_adapter (hw) container_of(hw, struct pch_gbe_adapter, hw) -extern const char pch_driver_version[]; -/* pch_gbe_main.c */ int pch_gbe_up (struct pch_gbe_adapter *adapter);void pch_gbe_down (struct pch_gbe_adapter *adapter);
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +2 -0
@@ -8,6 +8,8 @@#include "pch_gbe.h" #include "pch_gbe_phy.h" +static const char pch_driver_version[] ="1.01" ; +/* * pch_gbe_stats - Stats item information */
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +0 -4
@@ -18,9 +18,6 @@#include <linux/ptp_pch.h> #include <linux/gpio.h> -#define DRV_VERSION "1.01" -const char pch_driver_version[] =DRV_VERSION ; -#define PCH_GBE_MAR_ENTRIES 16#define PCH_GBE_SHORT_PKT 64#define DSC_INIT16 0xC000
@@ -2728,7 +2725,6 @@ module_pci_driver(pch_gbe_driver);MODULE_DESCRIPTION ("EG20T PCH Gigabit ethernet Driver" );MODULE_AUTHOR ("LAPIS SEMICONDUCTOR, <[email protected]>" );MODULE_LICENSE ("GPL" ); -MODULE_VERSION (DRV_VERSION );MODULE_DEVICE_TABLE (pci, pch_gbe_pcidev_id);/* pch_gbe_main.c */
Signature · 1 line
2.30.2
This series was applied to netdev/net-next.git (refs/heads/master):
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
Quoted 9 lines · On Mon, 10 May 2021 19:39:26 +0300 you wrote:
The series provides one fix (patch 1) for GPIO to be able to wait for the GPIO driver to appear. This is separated from the conversion to the GPIO descriptors (patch 2) in order to have a possibility for backporting. Patches 3 and 4 fix minor warnings from Sparse while moving to a new APIs. Patch 5 is
MODULE_VERSION()clean up.Tested on Intel Minnowboard (v1).
[...]
Here is the summary with links:
- [net-next,v3,1/5] net: pch_gbe: Propagate error from devm_gpio_request_one()
https://git.kernel.org/netdev/net-next/c/9e3617a7b845 - [net-next,v3,2/5] net: pch_gbe: Convert to use GPIO descriptors https://git.kernel.org/netdev/net-next/c/aca6a8746c36 - [net-next,v3,3/5] net: pch_gbe: use readx_poll_timeout_atomic() variant https://git.kernel.org/netdev/net-next/c/6fcfb267cb49 - [net-next,v3,4/5] net: pch_gbe: Use proper accessors to BE data in pch_ptp_match() https://git.kernel.org/netdev/net-next/c/443ef39b499c - [net-next,v3,5/5] net: pch_gbe: remove unneeded MODULE_VERSION() call https://git.kernel.org/netdev/net-next/c/40b161bb16c4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html