Skip to contentSkip to conversation

dt-bindings: media: renesas,drif: Use graph schema

PATCH Applied Rob Herring 2 participants 3 messages May 10, 2021 – May 17, 2021

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: media: renesas,drif: Use graph schema

Convert the renesas,drif binding schema to use the graph schema. The binding referred to video-interfaces.txt, but it doesn't actually use any properties from it as 'sync-active' is a custom property. As 'sync-active' is custom, it needs a type definition.

Cc Fabrizio Castro <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Ramesh Shanmugasundaram <[email protected]>
---
 .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)
Documentation/devicetree/bindings/media/renesas,drif.yaml +7 -13
index f1bdaeab4053..ce505a7c006a 100644
@@ -99,32 +99,26 @@ properties:
       Indicates that the channel acts as primary among the bonded channels.
 
   port:
-    type: object
+    $ref: /schemas/graph.yaml#/properties/port
+    unevaluatedProperties: false
     description:
-      Child port node corresponding to the data input, in accordance with the
-      video interface bindings defined in
-      Documentation/devicetree/bindings/media/video-interfaces.txt.
-      The port node must contain at least one endpoint.
+      Child port node corresponding to the data input. The port node must
+      contain at least one endpoint.
 
     properties:
       endpoint:
-        type: object
+        $ref: /schemas/graph.yaml#/$defs/endpoint-base
+        unevaluatedProperties: false
 
         properties:
-          remote-endpoint:
-            description:
-              A phandle to the remote tuner endpoint subnode in remote node
-              port.
-
           sync-active:
+            $ref: /schemas/types.yaml#/definitions/uint32
             enum: [0, 1]
             description:
               Indicates sync signal polarity, 0/1 for low/high respectively.
               This property maps to SYNCAC bit in the hardware manual. The
               default is 1 (active high).
 
-        additionalProperties: false
-
 required:
   - compatible
   - reg
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Rob,

thank you for your patch.

Quoted 9 lines

From: Rob Herring <[email protected]>
Sent: 10 May 2021 21:35
Subject: [PATCH] dt-bindings: media: renesas,drif: Use graph schema

Convert the renesas,drif binding schema to use the graph schema. The binding referred to video-interfaces.txt, but it doesn't actually use any properties from it as 'sync-active' is a custom property. As 'sync-active' is custom, it needs a type definition.

Quoted 6 lines
Cc Fabrizio Castro <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Ramesh Shanmugasundaram <[email protected]>

Best regards,
Fab

Quoted 56 lines
---
 .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)
Documentation/devicetree/bindings/media/renesas,drif.yaml +0 -0
index f1bdaeab4053..ce505a7c006a 100644
@@ -99,32 +99,26 @@ properties:
       Indicates that the channel acts as primary among the bonded

channels.

port:

Documentation/devicetree/bindings/media/renesas,drif.yaml +2 -2
-    type: object
+    $ref: /schemas/graph.yaml#/properties/port
+    unevaluatedProperties: false
     description:
-      Child port node corresponding to the data input, in accordance with

the

Documentation/devicetree/bindings/media/renesas,drif.yaml +4 -7
-      video interface bindings defined in
-      Documentation/devicetree/bindings/media/video-interfaces.txt.
-      The port node must contain at least one endpoint.
+      Child port node corresponding to the data input. The port node must
+      contain at least one endpoint.
 
     properties:
       endpoint:
-        type: object
+        $ref: /schemas/graph.yaml#/$defs/endpoint-base
+        unevaluatedProperties: false
 
         properties:
-          remote-endpoint:
-            description:
-              A phandle to the remote tuner endpoint subnode in remote

node

Documentation/devicetree/bindings/media/renesas,drif.yaml +1 -2
-              port.
-
           sync-active:
+            $ref: /schemas/types.yaml#/definitions/uint32
             enum: [0, 1]
             description:
               Indicates sync signal polarity, 0/1 for low/high

respectively.
This property maps to SYNCAC bit in the hardware manual.
The
default is 1 (active high).

Documentation/devicetree/bindings/media/renesas,drif.yaml +0 -3
-        additionalProperties: false
-
 required:
   - compatible
   - reg
--

2.27.0

author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

Convert the renesas,drif binding schema to use the graph schema. The binding referred to video-interfaces.txt, but it doesn't actually use any properties from it as 'sync-active' is a custom property. As 'sync-active' is custom, it needs a type definition.

Cc Fabrizio Castro <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
Cc Ramesh Shanmugasundaram <[email protected]>
Quoted 4 lines
---
 .../bindings/media/renesas,drif.yaml          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

Applied, thanks!