mm/page-writeback: Use __this_cpu_inc() in account_page_dirtied()
Subsystems (2)
PATCH 1/1 mm/page-writeback: Use __this_cpu_inc() in account_page_dirtied()
As account_page_dirtied() was always protected by xa_lock_irqsave(), so using __this_cpu_inc() is better.
Signed-off-by Chi Wu <[email protected]>
--- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page-writeback.c +1 -1
@@ -2436,7 +2436,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping)inc_wb_stat (wb,WB_DIRTIED );task_io_account_write (PAGE_SIZE ); current->nr_dirtied++; -this_cpu_inc (bdp_ratelimits); +__this_cpu_inc (bdp_ratelimits);mem_cgroup_track_foreign_dirty (page, wb); }
Signature · 1 line
2.17.1
Quoted 4 lines · Chi Wu
As
account_page_dirtied()was always protected byxa_lock_irqsave(), so using__this_cpu_inc()is better.Signed-off-by Chi Wu <[email protected]>
Looks good. You can add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 20 lines
--- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page-writeback.c +1
-1@@ -2436,7 +2436,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping)inc_wb_stat (wb,WB_DIRTIED );task_io_account_write (PAGE_SIZE ); current->nr_dirtied++; -this_cpu_inc (bdp_ratelimits); +__this_cpu_inc (bdp_ratelimits);mem_cgroup_track_foreign_dirty (page, wb); }Signature · 1 line
2.17.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR