vdpa/mlx5: fix device unplug
Subsystems (2)
PATCH 1/1 vdpa/mlx5: fix device unplug
The vDPA PCI device unplug proccess should release all the private device resources and also to unregister the device.
The device unregistration was missed what remained the device data invalid in the rte_vhost library.
Unregister the device in unplug proccess via the remove operation.
--- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/vdpa/mlx5/mlx5_vdpa.c +2 -0
@@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) mlx5_glue->dv_free_var (priv->var); priv->var =NULL ; } +if (priv->vdev) +rte_vdpa_unregister_device (priv->vdev); mlx5_glue->close_device (priv->ctx);pthread_mutex_destroy (&priv->vq_config_lock);rte_free (priv);
Signature · 1 line
2.25.1
PATCH v2 1/1 vdpa/mlx5: fix device unplug
The vDPA PCI device unplug process should release all the private device resources and also to unregister the device.
The device unregistration was missed what remained the device data invalid in the rte_vhost library.
Unregister the device in unplug process via the remove operation.
--- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)
v2:
fix spelling and email format
drivers/vdpa/mlx5/mlx5_vdpa.c +2 -0
@@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) mlx5_glue->dv_free_var (priv->var); priv->var =NULL ; } +if (priv->vdev) +rte_vdpa_unregister_device (priv->vdev); mlx5_glue->close_device (priv->ctx);pthread_mutex_destroy (&priv->vq_config_lock);rte_free (priv);
Signature · 1 line
2.25.1
Quoted 44 lines
-----Original Message-----
From: stable <[email protected]> On Behalf Of Matan Azrad
Sent: Friday, May 14, 2021 2:40 AM
To: [email protected]
Cc: [email protected]; [email protected]; Eli Britstein <[email protected]>; Xueming Li <[email protected]>
Subject: [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplugThe vDPA PCI device unplug process should release all the private device resources and also to unregister the device.
The device unregistration was missed what remained the device data invalid in the
rte_vhostlibrary.Unregister the device in unplug process via the remove operation.
Fixes 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver")Reported-by Eli Britstein <[email protected]>Signed-off-by Matan Azrad <[email protected]>Tested-by Eli Britstein <[email protected]>Acked-by Xueming Li <[email protected]>--- drivers/vdpa/mlx5/mlx5_vdpa.c | 2 ++ 1 file changed, 2 insertions(+)v2:
fix spelling and email formatdrivers/vdpa/mlx5/mlx5_vdpa.c +2
-1@@ -787,6 +787,8 @@ mlx5_vdpa_pci_remove(struct rte_pci_device *pci_dev) mlx5_glue->dv_free_var (priv->var); priv->var =NULL ; } +if (priv->vdev) +rte_vdpa_unregister_device (priv->vdev); mlx5_glue->close_device (priv->ctx);pthread_mutex_destroy (&priv->vq_config_lock);rte_free (priv); --
Quoted 1 line
2.25.1
Xia, Chenbo
AppliedQuoted 19 lines
-----Original Message-----
From: stable <[email protected]> On Behalf Of Matan Azrad
Sent: Friday, May 14, 2021 2:40 AM
To: [email protected]
Cc: [email protected]; [email protected]; Eli Britstein <[email protected]>; Xueming Li <[email protected]>
Subject: [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplugThe vDPA PCI device unplug process should release all the private device resources and also to unregister the device.
The device unregistration was missed what remained the device data invalid in the
rte_vhostlibrary.Unregister the device in unplug process via the remove operation.
Fixes 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver")
Quoted 6 lines
Reported-by Eli Britstein <[email protected]>Signed-off-by Matan Azrad <[email protected]>Tested-by Eli Britstein <[email protected]>Acked-by Xueming Li <[email protected]>---
2.25.1
Applied to next-virtio/main. Thanks.