Skip to contentSkip to conversation

gpio: gpio-bd9571mwv: remove platform_set_drvdata() + cleanup probe

PATCH Applied Alexandru Ardelean 2 participants 2 messages May 14, 2021 – May 21, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: gpio-bd9571mwv: remove platform_set_drvdata() + cleanup probe

The platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.

---
 drivers/gpio/gpio-bd9571mwv.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-bd9571mwv.c +1 -10
index df6102b57734..9a4d55f703bb 100644
@@ -97,25 +97,16 @@ static const struct gpio_chip template_chip = {
 static int bd9571mwv_gpio_probe(struct platform_device *pdev)
 {
 	struct bd9571mwv_gpio *gpio;
-	int ret;
 
 	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
 	if (!gpio)
 		return -ENOMEM;
 
-	platform_set_drvdata(pdev, gpio);
-
 	gpio->regmap = dev_get_regmap(pdev->dev.parent, NULL);
 	gpio->chip = template_chip;
 	gpio->chip.parent = pdev->dev.parent;
 
-	ret = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
-		return ret;
-	}
-
-	return 0;
+	return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
 }
 
 static const struct platform_device_id bd9571mwv_gpio_id_table[] = {
Signature · 1 line
2.31.1
#1 lore raw
Quoted 46 lines · Alexandru Ardelean

The platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.

---
 drivers/gpio/gpio-bd9571mwv.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/gpio/gpio-bd9571mwv.c +1 -11
index df6102b57734..9a4d55f703bb 100644
@@ -97,25 +97,16 @@ static const struct gpio_chip template_chip = {
 static int bd9571mwv_gpio_probe(struct platform_device *pdev)
 {
        struct bd9571mwv_gpio *gpio;
-       int ret;
 
        gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
        if (!gpio)
                return -ENOMEM;
 
-       platform_set_drvdata(pdev, gpio);
-
        gpio->regmap = dev_get_regmap(pdev->dev.parent, NULL);
        gpio->chip = template_chip;
        gpio->chip.parent = pdev->dev.parent;
 
-       ret = devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
-       if (ret < 0) {
-               dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
-               return ret;
-       }
-
-       return 0;
+       return devm_gpiochip_add_data(&pdev->dev, &gpio->chip, gpio);
 }
 
 static const struct platform_device_id bd9571mwv_gpio_id_table[] = {
--
Quoted 2 lines

2.31.1

Applied, thanks!
Bartosz