Skip to contentSkip to conversation

staging: rtl8188eu: Drop unnecessary NULL check after container_of

PATCH New Guenter Roeck 1 participant 1 message May 14, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: Drop unnecessary NULL check after container_of

The result of container_of() operations is never NULL unless the extracted element is the first element of the embedded structure. This is not the case here. The NULL check is therefore unnecessary and misleading. Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
t v = container_of(...);
|
v = container_of(...);
)
...
when != v
- if (\( !v \| v == NULL \) ) s
...+>

---
 drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +0 -3
index fc991c8c16d2..b4d81d3a856c 100644
@@ -4038,9 +4038,6 @@ void free_mlme_ext_priv(struct mlme_ext_priv *pmlmeext)
 {
 	struct adapter *padapter = container_of(pmlmeext, struct adapter, mlmeextpriv);
 
-	if (!padapter)
-		return;
-
 	if (padapter->bDriverStopped) {
 		del_timer_sync(&pmlmeext->survey_timer);
 		del_timer_sync(&pmlmeext->link_timer);
Signature · 1 line
2.25.1