Skip to contentSkip to conversation

sched: Fix Dereference after null check

PATCH-next Khaled ROMDHANI 2 participants 2 messages May 15, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

The group_cfs_rq derefrence the 'se' variable that could be passed as NULL pointer. Fix this by adding a check against the sched entity 'se' before the derefrence.

Addresses-Coverity: ("Dereference after null check")

---
 kernel/sched/fair.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/sched/fair.c +2 -1
index 161b92aa1c79..9be6cdba351d 100644
@@ -7080,7 +7080,8 @@ static struct task_struct *pick_task_fair(struct rq *rq)
 		}
 
 		se = pick_next_entity(cfs_rq, curr);
-		cfs_rq = group_cfs_rq(se);
+		if (se)
+			cfs_rq = group_cfs_rq(se);
 	} while (cfs_rq);
 
 	return task_of(se);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 6 lines · Khaled ROMDHANI

The group_cfs_rq derefrence the 'se' variable that could be passed as NULL pointer. Fix this by adding a check against the sched entity 'se' before the derefrence.

Addresses-Coverity: ("Dereference after null check")

Please, burn that piece of garbage known as Coverity and go do something useful.