gpio: gpio-wm831x: remove platform_set_drvdata() + cleanup probe
Subsystems (2)
PATCH 1/1 gpio: gpio-wm831x: remove platform_set_drvdata() + cleanup probe
The platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.
--- drivers/gpio/gpio-wm831x.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/gpio/gpio-wm831x.c +1 -11
@@ -261,7 +261,6 @@ static int wm831x_gpio_probe(struct platform_device *pdev)struct wm831x *wm831x =dev_get_drvdata (pdev->dev.parent);struct wm831x_pdata *pdata = &wm831x->pdata;struct wm831x_gpio *wm831x_gpio; -int ret; wm831x_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm831x_gpio),GFP_KERNEL );
@@ -280,16 +279,7 @@ static int wm831x_gpio_probe(struct platform_device *pdev) wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node;#endif - ret =devm_gpiochip_add_data (&pdev->dev, &wm831x_gpio->gpio_chip, - wm831x_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, wm831x_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm831x_gpio->gpio_chip, wm831x_gpio); }static struct platform_driver wm831x_gpio_driver = {
Signature · 1 line
2.31.1
PATCH 1/1 gpio: gpio-wm8350: remove platform_set_drvdata() + cleanup probe
The platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.
--- drivers/gpio/gpio-wm8350.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/gpio/gpio-wm8350.c +1 -11
@@ -105,7 +105,6 @@ static int wm8350_gpio_probe(struct platform_device *pdev)struct wm8350 *wm8350 =dev_get_drvdata (pdev->dev.parent);struct wm8350_platform_data *pdata =dev_get_platdata (wm8350->dev);struct wm8350_gpio_data *wm8350_gpio; -int ret; wm8350_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm8350_gpio),GFP_KERNEL );
@@ -121,16 +120,7 @@ static int wm8350_gpio_probe(struct platform_device *pdev)else wm8350_gpio->gpio_chip.base =-1 ; - ret =devm_gpiochip_add_data (&pdev->dev, &wm8350_gpio->gpio_chip, - wm8350_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, wm8350_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm8350_gpio->gpio_chip, wm8350_gpio); }static struct platform_driver wm8350_gpio_driver = {
Signature · 1 line
2.31.1
Bartosz Golaszewski
AppliedRe: [PATCH] gpio: gpio-wm8350: remove platform_set_drvdata() + cleanup probe
Quoted 45 lines · Alexandru Ardelean
The
platform_set_drvdata()call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.Signed-off-by Alexandru Ardelean <[email protected]>--- drivers/gpio/gpio-wm8350.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)drivers/gpio/gpio-wm8350.c +1
-12@@ -105,7 +105,6 @@ static int wm8350_gpio_probe(struct platform_device *pdev)struct wm8350 *wm8350 =dev_get_drvdata (pdev->dev.parent);struct wm8350_platform_data *pdata =dev_get_platdata (wm8350->dev);struct wm8350_gpio_data *wm8350_gpio; -int ret; wm8350_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm8350_gpio),GFP_KERNEL );@@ -121,16 +120,7 @@ static int wm8350_gpio_probe(struct platform_device *pdev)else wm8350_gpio->gpio_chip.base =-1 ; - ret =devm_gpiochip_add_data (&pdev->dev, &wm8350_gpio->gpio_chip, - wm8350_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, wm8350_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm8350_gpio->gpio_chip, wm8350_gpio); }static struct platform_driver wm8350_gpio_driver = { --
Quoted 2 lines
2.31.1
Applied, thanks!
Bart
PATCH 1/1 gpio: gpio-wm8994: remove platform_set_drvdata() + cleanup probe
In reply to Alexandru ArdeleanThe platform_set_drvdata() call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.
--- drivers/gpio/gpio-wm8994.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)
drivers/gpio/gpio-wm8994.c +1 -12
@@ -263,7 +263,6 @@ static int wm8994_gpio_probe(struct platform_device *pdev)struct wm8994 *wm8994 =dev_get_drvdata (pdev->dev.parent);struct wm8994_pdata *pdata =dev_get_platdata (wm8994->dev);struct wm8994_gpio *wm8994_gpio; -int ret; wm8994_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm8994_gpio),GFP_KERNEL );
@@ -279,17 +278,7 @@ static int wm8994_gpio_probe(struct platform_device *pdev)else wm8994_gpio->gpio_chip.base =-1 ; - ret =devm_gpiochip_add_data (&pdev->dev, &wm8994_gpio->gpio_chip, - wm8994_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , - ret); -return ret; - } - -platform_set_drvdata (pdev, wm8994_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm8994_gpio->gpio_chip, wm8994_gpio); }static struct platform_driver wm8994_gpio_driver = {
Signature · 1 line
2.31.1
Bartosz Golaszewski
AppliedRe: [PATCH] gpio: gpio-wm8994: remove platform_set_drvdata() + cleanup probe
Quoted 46 lines · Alexandru Ardelean
The
platform_set_drvdata()call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.Signed-off-by Alexandru Ardelean <[email protected]>--- drivers/gpio/gpio-wm8994.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)drivers/gpio/gpio-wm8994.c +1
-13@@ -263,7 +263,6 @@ static int wm8994_gpio_probe(struct platform_device *pdev)struct wm8994 *wm8994 =dev_get_drvdata (pdev->dev.parent);struct wm8994_pdata *pdata =dev_get_platdata (wm8994->dev);struct wm8994_gpio *wm8994_gpio; -int ret; wm8994_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm8994_gpio),GFP_KERNEL );@@ -279,17 +278,7 @@ static int wm8994_gpio_probe(struct platform_device *pdev)else wm8994_gpio->gpio_chip.base =-1 ; - ret =devm_gpiochip_add_data (&pdev->dev, &wm8994_gpio->gpio_chip, - wm8994_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , - ret); -return ret; - } - -platform_set_drvdata (pdev, wm8994_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm8994_gpio->gpio_chip, wm8994_gpio); }static struct platform_driver wm8994_gpio_driver = { --
Quoted 2 lines
2.31.1
Applied, thanks!
Bart
Bartosz Golaszewski
AppliedQuoted 45 lines · Alexandru Ardelean
The
platform_set_drvdata()call is only useful if we need to retrieve back the private information.
Since the driver doesn't do that, it's not useful to have it.If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe.Signed-off-by Alexandru Ardelean <[email protected]>--- drivers/gpio/gpio-wm831x.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)drivers/gpio/gpio-wm831x.c +1
-12@@ -261,7 +261,6 @@ static int wm831x_gpio_probe(struct platform_device *pdev)struct wm831x *wm831x =dev_get_drvdata (pdev->dev.parent);struct wm831x_pdata *pdata = &wm831x->pdata;struct wm831x_gpio *wm831x_gpio; -int ret; wm831x_gpio =devm_kzalloc (&pdev->dev,sizeof (*wm831x_gpio),GFP_KERNEL );@@ -280,16 +279,7 @@ static int wm831x_gpio_probe(struct platform_device *pdev) wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node;#endif - ret =devm_gpiochip_add_data (&pdev->dev, &wm831x_gpio->gpio_chip, - wm831x_gpio); -if (ret <0 ) { -dev_err (&pdev->dev,"Could not register gpiochip, %d\n" , ret); -return ret; - } - -platform_set_drvdata (pdev, wm831x_gpio); - -return ret; +return devm_gpiochip_add_data (&pdev->dev, &wm831x_gpio->gpio_chip, wm831x_gpio); }static struct platform_driver wm831x_gpio_driver = { --
Quoted 2 lines
2.31.1
Applied, thanks!
Bart