PCI: tegra: Fix host initialization during resume
PATCH 1/1 PCI: tegra: Fix host initialization during resume
Commit 275e88b06a27 ("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the API dw_pcie_setup_rc() which is required for host and MSI initialization.
--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pci/controller/dwc/pcie-tegra194.c +2 -0
@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;
Signature · 1 line
2.17.1
Quoted 16 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.Fixes 275e88b06a27 ("PCI: tegra: Fix host link initialization")Signed-off-by Vidya Sagar <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +0
-0
drivers/pci/controller/dwc/pcie-tegra194.c static int tegra_pcie_dw_resume_noirq(struct device *dev) · line 2221
Quoted 8 lines
drivers/pci/controller/dwc/pcie-tegra194.c +2
-0@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;
Thanks for fixing!
We should also mark this for stable so that this gets back-ported.
Jon
Signature · 1 line
nvpublic
Jon Hunter
maintainerHi Lorenzo, Bjorn,
Quoted 30 lines · Jon Hunter
Quoted 16 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.Fixes 275e88b06a27 ("PCI: tegra: Fix host link initialization")Signed-off-by Vidya Sagar <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +0
-0drivers/pci/controller/dwc/pcie-tegra194.c static int tegra_pcie_dw_resume_noirq(struct device *dev) · line 2221
Quoted 8 lines
drivers/pci/controller/dwc/pcie-tegra194.c +2
-0@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;Thanks for fixing!
Quoted 3 lines
Tested-by Jon Hunter <[email protected]>We should also mark this for stable so that this gets back-ported.
Can we queue this as a fix for v5.13 and tag for stable?
Thanks!
Jon
Signature · 1 line
nvpublic
Quoted 33 lines · Jon Hunter
Hi Lorenzo, Bjorn,
Quoted 30 lines · Jon Hunter
Quoted 16 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.Fixes 275e88b06a27 ("PCI: tegra: Fix host link initialization")Signed-off-by Vidya Sagar <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +0
-0drivers/pci/controller/dwc/pcie-tegra194.c static int tegra_pcie_dw_resume_noirq(struct device *dev) · line 2221
Quoted 8 lines
drivers/pci/controller/dwc/pcie-tegra194.c +2
-0@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;Thanks for fixing!
Quoted 6 lines
Quoted 3 lines
Tested-by Jon Hunter <[email protected]>We should also mark this for stable so that this gets back-ported.
Can we queue this as a fix for v5.13 and tag for stable?
We usually send fixes for -rc* when the patches they are fixing were merged in the current cycle (ie merged for v5.13).
This is not the case so I shall send it for v5.14.
Lorenzo
Quoted 32 lines · Lorenzo Pieralisi
Quoted 31 lines · Jon Hunter
Hi Lorenzo, Bjorn,
Quoted 28 lines · Jon Hunter
Quoted 15 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.Fixes 275e88b06a27 ("PCI: tegra: Fix host link initialization")Signed-off-by Vidya Sagar <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +0
-0drivers/pci/controller/dwc/pcie-tegra194.c static int tegra_pcie_dw_resume_noirq(struct device *dev) · line 2221
Quoted 8 lines
drivers/pci/controller/dwc/pcie-tegra194.c +2
-0@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;Thanks for fixing!
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Tested-by Jon Hunter <[email protected]>We should also mark this for stable so that this gets back-ported.
Can we queue this as a fix for v5.13 and tag for stable?
We usually send fixes for -rc* when the patches they are fixing were merged in the current cycle (ie merged for v5.13).
Looks like this has been broken since v5.11-rc1 (December 27, 2020), when 275e88b06a27 was merged. Probably would be worth an occasional boot test to make sure things stay working.
Quoted 3 lines
This is not the case so I shall send it for v5.14.
Lorenzo
Jon Hunter
maintainerQuoted 37 lines · Bjorn Helgaas
Quoted 36 lines · Lorenzo Pieralisi
Quoted 35 lines · Jon Hunter
Hi Lorenzo, Bjorn,
Quoted 31 lines · Jon Hunter
Quoted 15 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.Fixes 275e88b06a27 ("PCI: tegra: Fix host link initialization")Signed-off-by Vidya Sagar <[email protected]>--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pci/controller/dwc/pcie-tegra194.c +0
-0drivers/pci/controller/dwc/pcie-tegra194.c static int tegra_pcie_dw_resume_noirq(struct device *dev) · line 2221
Quoted 8 lines
drivers/pci/controller/dwc/pcie-tegra194.c +2
-0@@ -2214,6 +2214,8 @@ static int tegra_pcie_dw_resume_noirq(struct device *dev) goto fail_host_init; } +dw_pcie_setup_rc (&pcie->pci.pp); + ret =tegra_pcie_dw_start_link (&pcie->pci);if (ret <0 ) goto fail_host_init;Thanks for fixing!
Tested-by Jon Hunter <[email protected]>We should also mark this for stable so that this gets back-ported.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Can we queue this as a fix for v5.13 and tag for stable?
We usually send fixes for -rc* when the patches they are fixing were merged in the current cycle (ie merged for v5.13).
Looks like this has been broken since v5.11-rc1 (December 27, 2020), when
275e88b06a27was merged. Probably would be worth an occasional boot test to make sure things stay working.
Yes exactly it has been broken for a while and unfortunately went unnoticed.
We do boot test -next, mainline and the various stable branches on our Tegra boards daily. The boot test did not catch this, but there is a error generated when resuming from suspend and I am working to ensure we catch such errors when resuming from suspend.
Cheers
Jon
Signature · 1 line
nvpublic
Lorenzo Pieralisi
AppliedQuoted 3 lines · Vidya Sagar
Commit
275e88b06a27("PCI: tegra: Fix host link initialization") broke host initialization during resume as it misses out calling the APIdw_pcie_setup_rc()which is required for host and MSI initialization.
Applied to pci/tegra, thanks!
[1/1] PCI: tegra: Fix host initialization during resume
https://git.kernel.org/lpieralisi/pci/c/d0180ba464
Thanks,
Lorenzo