Skip to contentSkip to conversation

scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

PATCH Applied Yang Yingliang 3 participants 4 messages May 18, 2021 – May 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

Use vzalloc() instead of vmalloc() and memset(0) to simpify the code.

---
 drivers/scsi/qedf/qedf_dbg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qedf/qedf_dbg.c +1 -2
index e0387e495261..0d2aed82882a 100644
@@ -106,11 +106,10 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line,
 int
 qedf_alloc_grc_dump_buf(u8 **buf, uint32_t len)
 {
-		*buf = vmalloc(len);
+		*buf = vzalloc(len);
 		if (!(*buf))
 			return -ENOMEM;
 
-		memset(*buf, 0, len);
 		return 0;
 }
 
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Yang Yingliang

Use vzalloc() instead of vmalloc() and memset(0) to simpify the code.

---
  drivers/scsi/qedf/qedf_dbg.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qedf/qedf_dbg.c +0 -0
index e0387e495261..0d2aed82882a 100644
@@ -106,11 +106,10 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line,
  int
  qedf_alloc_grc_dump_buf(u8 **buf, uint32_t len)

drivers/scsi/qedf/qedf_dbg.c qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line, · line 115

Quoted 10 lines
drivers/scsi/qedf/qedf_dbg.c +1 -2
  {
-		*buf = vmalloc(len);
+		*buf = vzalloc(len);
  		if (!(*buf))
  			return -ENOMEM;
 
-		memset(*buf, 0, len);
  		return 0;
  }
 

Looks Good.

Signature · 1 line
Himanshu Madhani                                Oracle Linux Engineering
#2 lore raw
In reply to Yang Yingliang

Yang,

Quoted 1 line

Use vzalloc() instead of vmalloc() and memset(0) to simpify the code.

Applied to 5.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering