Skip to contentSkip to conversation

linux-next: Fixes tag needs some work in the block tree

DISCUSSION Stephen Rothwell 3 participants 3 messages May 18, 2021 – May 19, 2021 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

In commit

1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

Fixes 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

- Subject does not match target commit subject

    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

or

Fixes 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")
Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

Hello!

On 5/19/21 1:01 AM, Stephen Rothwell wrote:

[...]

Quoted 10 lines

In commit

1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

Fixes 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

Quoted 7 lines

- Subject does not match target commit subject

    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

This one!

Quoted 3 lines

or

Fixes 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

Perhaps this could be fixed still, Jens?

MBR, Sergey

#2 lore raw
Quoted 23 lines · Sergey Shtylyov

Hello!

On 5/19/21 1:01 AM, Stephen Rothwell wrote:

[...]

Quoted 10 lines

In commit

1437568b56f8 ("pata_octeon_cf: avoid WARN_ON() in ata_host_activate()")

Fixes tag

Fixes 3c929c6f5aa7 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")

has these problem(s):

Quoted 7 lines

- Subject does not match target commit subject

    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
Quoted 7 lines

This one!

Quoted 3 lines

or

Fixes 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")

Perhaps this could be fixed still, Jens?

Yep, I fixed it up, thanks.

Signature · 1 line
Jens Axboe