Skip to contentSkip to conversation

staging: greybus: spi: add blank line after variable declaration

PATCH In review Philippe Dixon 3 participants 3 messages May 19, 2021 – May 20, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: spi: add blank line after variable declaration

This patch fixes the following checkpatch.pl warning:

WARNING: Missing a blank line after declarations

---
 drivers/staging/greybus/spilib.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/greybus/spilib.c +1 -0
index 30655153df6a..ad0700a0bb81 100644
@@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
 	xfer = spi->first_xfer;
 	while (msg->state != GB_SPI_STATE_OP_DONE) {
 		int xfer_delay;
+
 		if (xfer == spi->last_xfer)
 			xfer_len = spi->last_xfer_size;
 		else
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Philippe Dixon

This patch fixes the following checkpatch.pl warning:

WARNING: Missing a blank line after declarations

Looks good.

Quoted 17 lines
---
  drivers/staging/greybus/spilib.c | 1 +
  1 file changed, 1 insertion(+)
drivers/staging/greybus/spilib.c +1 -0
index 30655153df6a..ad0700a0bb81 100644
@@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
  	xfer = spi->first_xfer;
  	while (msg->state != GB_SPI_STATE_OP_DONE) {
  		int xfer_delay;
+
  		if (xfer == spi->last_xfer)
  			xfer_len = spi->last_xfer_size;
  		else
Acked-by on v1 1/1
#2 lore raw
In reply to Philippe Dixon
Quoted 14 lines · Philippe Dixon

This patch fixes the following checkpatch.pl warning:

WARNING: Missing a blank line after declarations

---
 drivers/staging/greybus/spilib.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/greybus/spilib.c +0 -0
index 30655153df6a..ad0700a0bb81 100644

drivers/staging/greybus/spilib.c static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi, · line 252

Quoted 7 lines
drivers/staging/greybus/spilib.c +1 -0
@@ -246,6 +246,7 @@ static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
 	xfer = spi->first_xfer;
 	while (msg->state != GB_SPI_STATE_OP_DONE) {
 		int xfer_delay;
+
 		if (xfer == spi->last_xfer)
 			xfer_len = spi->last_xfer_size;
 		else
Signature · 1 line
viresh