scsi: scsi_transport_fc: Remove double FC_FPORT_DELETED in mask creation
PATCH 1/1 scsi: scsi_transport_fc: Remove double FC_FPORT_DELETED in mask creation
Remove the double listed FC_FPORT_DELETING from the mask creation.
Commit 260f4aeddb48 ("scsi: scsi_transport_fc: return -EBUSY for deleted vport") added VC_VPORT_DELETING to the flag masks. This is not necessary as FC_FPORT_DEL is defined as VC_FPORT_DELETED | FC_FPORT_DELETING.
--- drivers/scsi/scsi_transport_fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_transport_fc.c +1 -1
@@ -1686,7 +1686,7 @@ store_fc_vport_delete(struct device *dev, struct device_attribute *attr,unsigned long flags;spin_lock_irqsave (shost->host_lock, flags); -if (vport->flags & (FC_VPORT_DEL |FC_VPORT_CREATING |FC_VPORT_DELETING )) { +if (vport->flags & (FC_VPORT_DEL |FC_VPORT_CREATING )) {spin_unlock_irqrestore (shost->host_lock, flags);return -EBUSY ; }
Signature · 1 line
2.29.2
Martin K. Petersen
AppliedDaniel,
Quoted 6 lines
Remove the double listed
FC_FPORT_DELETINGfrom the mask creation.Commit
260f4aeddb48("scsi:scsi_transport_fc: return-EBUSYfor deleted vport") addedVC_VPORT_DELETINGto the flag masks. This is not necessary asFC_FPORT_DELis defined asVC_FPORT_DELETED|FC_FPORT_DELETING.
Applied to 5.14/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 6 lines · Daniel Wagner
Remove the double listed
FC_FPORT_DELETINGfrom the mask creation.Commit
260f4aeddb48("scsi:scsi_transport_fc: return-EBUSYfor deleted vport") addedVC_VPORT_DELETINGto the flag masks. This is not necessary asFC_FPORT_DELis defined asVC_FPORT_DELETED|FC_FPORT_DELETING.
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: scsi_transport_fc: Remove double FC_FPORT_DELETED in mask creation
https://git.kernel.org/mkp/scsi/c/faa6c1d92cb0
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering