ath11k: v5.12.3 mhi regression

regressions Kalle Valo 4 participants 9 messages May 20, 2021 – May 24, 2021

Subsystems (3)

Stable branch Regressions Qualcomm Atheros ATH11K wireless driver

lore

Share & tools

lore

Kalle Valo

author

2021-05-20 09:48 UTC #0 lore raw

Hi,

I got several reports that this mhi commit broke ath11k in v5.12.3:

commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed

Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800

bus: mhi: core: Process execution environment changes serially

[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]

Here are the reports:

https://bugzilla.kernel.org/show_bug.cgi?id=213055

https://bugzilla.kernel.org/show_bug.cgi?id=212187

https://bugs.archlinux.org/task/70849?project=1&string=linux

Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?

Signature · 3 lines

https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Greg KH

maintainer

2021-05-20 10:23 UTC #1 lore raw

Quoted 16 lines · Kalle Valo

Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055

Quoted 7 lines

https://bugzilla.kernel.org/show_bug.cgi?id=212187
https://bugs.archlinux.org/task/70849?project=1&string=linux
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?

How does the mhi bus code relate to a ath11k driver? What bus is that on?

This seems odd...

greg k-h

Manivannan Sadhasivam

2021-05-20 10:43 UTC #2 lore raw

Quoted 19 lines · Greg KH

Quoted 18 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187

Quoted 9 lines

Quoted 5 lines
https://bugs.archlinux.org/task/70849?project=1&string=linux
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that on?

MHI is the transport used by the ath11k driver to work with the WLAN devices over PCIe.

Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5) to comment on the possible commit which needs backporting from mainline.

Thanks,
Mani

Quoted 3 lines

This seems odd...
greg k-h

Kalle Valo

author

2021-05-20 12:36 UTC #3 lore raw

Quoted 30 lines · Manivannan Sadhasivam

Quoted 19 lines · Greg KH
Quoted 18 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
Quoted 9 lines
Quoted 5 lines
https://bugs.archlinux.org/task/70849?project=1&string=linux
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that on?

Quoted 5 lines

MHI is the transport used by the ath11k driver to work with the WLAN devices over PCIe.
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5) to comment on the possible commit which needs backporting from mainline.

Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:

https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11

Signature · 3 lines

https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Bhaumik Bhatt

2021-05-20 17:38 UTC #4 lore raw

Quoted 35 lines · Kalle Valo

Quoted 33 lines · Manivannan Sadhasivam
Quoted 19 lines · Greg KH
Quoted 18 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
Quoted 9 lines
Quoted 5 lines
https://bugs.archlinux.org/task/70849?project=1&string=linux
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that on?
MHI is the transport used by the ath11k driver to work with the WLAN devices over PCIe.

Quoted 8 lines

Quoted 2 lines
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5) to comment on the possible commit which needs backporting from mainline.
Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:
https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11

Please pick [1] as the dependency to [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].

That is missing in older kernels and did not get backported. This explains why 5.13.x works.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/bus/mhi/core?h=v5.13-rc2&id=4884362f6977fc05cbec736625665241c0e0732f

Greg KH

maintainer

2021-05-20 17:58 UTC #5 lore raw

Quoted 43 lines · Bhaumik Bhatt

Quoted 42 lines · Kalle Valo
Quoted 39 lines · Manivannan Sadhasivam
Quoted 21 lines · Greg KH
Quoted 20 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
https://bugs.archlinux.org/task/70849?project=1&string=linux
Quoted 8 lines
Quoted 3 lines
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that
on?
MHI is the transport used by the ath11k driver to work with the WLAN devices
over PCIe.
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
to comment on the possible commit which needs backporting from mainline.

Quoted 8 lines

Quoted 5 lines
Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:
https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
Please pick [1] as the dependency to [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].

what is [1]???

What commit do I need to backport, a commit id would be nice...

thanks,

greg k-h

Bhaumik Bhatt

2021-05-20 18:04 UTC #6 lore raw

Quoted 53 lines · Greg KH

Quoted 43 lines · Bhaumik Bhatt
Quoted 42 lines · Kalle Valo
Quoted 39 lines · Manivannan Sadhasivam
Quoted 21 lines · Greg KH
Quoted 20 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
https://bugs.archlinux.org/task/70849?project=1&string=linux
Quoted 8 lines
Quoted 3 lines
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that
on?
MHI is the transport used by the ath11k driver to work with the WLAN devices
over PCIe.
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
to comment on the possible commit which needs backporting from mainline.
Quoted 8 lines
Quoted 5 lines
Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:
https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
Please pick [1] as the dependency to [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].

Quoted 7 lines

what is [1]???
What commit do I need to backport, a commit id would be nice...
thanks,
greg k-h

Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f

Title of patch:
bus: mhi: core: Download AMSS image from appropriate function

It was supposed to be a link but not sure why it's not seen.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Greg KH

maintainer

2021-05-20 18:17 UTC #7 lore raw

Quoted 60 lines · Bhaumik Bhatt

Quoted 59 lines · Greg KH
Quoted 43 lines · Bhaumik Bhatt
Quoted 42 lines · Kalle Valo
Quoted 39 lines · Manivannan Sadhasivam
Quoted 21 lines · Greg KH
Quoted 20 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
https://bugs.archlinux.org/task/70849?project=1&string=linux
Quoted 8 lines
Quoted 3 lines
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that
on?
MHI is the transport used by the ath11k driver to work with the WLAN devices
over PCIe.
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
to comment on the possible commit which needs backporting from mainline.
Quoted 8 lines
Quoted 5 lines
Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:
https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
Please pick [1] as the dependency to [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
what is [1]???
What commit do I need to backport, a commit id would be nice...
thanks,

Quoted 7 lines

Quoted 1 line
greg k-h
Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f
Title of patch:
bus: mhi: core: Download AMSS image from appropriate function
It was supposed to be a link but not sure why it's not seen.

Text email doesn't have links :)

Anyway, thanks, now queued up.

Also note, it's nice to write kernel commit ids as 4884362f6977 ("bus:
mhi: core: Download AMSS image from appropriate function") which is the preferred way to reference them in a emails and commit logs.

thanks,

greg k-h

Kalle Valo

author

2021-05-24 05:56 UTC #8 lore raw

Quoted 64 lines · Greg KH

Quoted 63 lines · Bhaumik Bhatt
Quoted 53 lines · Greg KH
Quoted 43 lines · Bhaumik Bhatt
Quoted 42 lines · Kalle Valo
Quoted 39 lines · Manivannan Sadhasivam
Quoted 21 lines · Greg KH
Quoted 20 lines · Kalle Valo
Hi,
I got several reports that this mhi commit broke ath11k in v5.12.3:
commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date:   Wed Feb 24 15:23:04 2021 -0800
bus: mhi: core: Process execution environment changes serially
[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
Here are the reports:
https://bugzilla.kernel.org/show_bug.cgi?id=213055
https://bugzilla.kernel.org/show_bug.cgi?id=212187
https://bugs.archlinux.org/task/70849?project=1&string=linux
Quoted 8 lines
Quoted 3 lines
Interestingly v5.13-rc1 seems to work fine, at least for me, though I have not tested v5.12.3 myself. Can someone revert this commit in the stable release so that people get their wifi working again, please?
How does the mhi bus code relate to a ath11k driver? What bus is that
on?
MHI is the transport used by the ath11k driver to work with the WLAN devices
over PCIe.
Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
to comment on the possible commit which needs backporting from mainline.
Quoted 8 lines
Quoted 5 lines
Ok, but if a quick fix is not available I think we should just revert this in the stable releases. I also got a report that v5.11.21 is broken:
https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
Please pick [1] as the dependency to [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
Quoted 7 lines
what is [1]???
What commit do I need to backport, a commit id would be nice...
thanks,
greg k-h
Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f

Quoted 8 lines

Quoted 4 lines
Title of patch:
bus: mhi: core: Download AMSS image from appropriate function
It was supposed to be a link but not sure why it's not seen.
Text email doesn't have links :)
Anyway, thanks, now queued up.

I'm now getting confirmations that this issue is fixed in v5.12.6. Thanks for the quick fix and the quick new release!

Signature · 3 lines

https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches