Update sd card pinconf for sc7180 DT
Subsystems (4)
v2 cover Update sd card pinconf for sc7180 DT
This patch series contains change to move sdc pinconf from SoC specific DT file to board specific DT file. It also contain change to set sdc GPIO pin to bias-pull up
Tested sd card working on sc7180 based board
Changes in v2:
- added pull-up for IDP
Sujit Kautkar (2):
arm64: dts: qcom: sc7180: Move sdc pinconf to board specific DT files
arm64: dts: qcom: sc7180: trogdor: SD-card GPIO pin set bias-pull up
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 102 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 102 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 102 ------------------- 3 files changed, 204 insertions(+), 102 deletions(-)
Signature · 1 line
2.31.1.818.g46aad6cb9e-goog
PATCH v2 1/2 arm64: dts: qcom: sc7180: Move sdc pinconf to board specific DT files
Move sdc1/sdc2 pinconf from SoC specific DT file to board specific DT files
---
(no changes since v1)
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 102 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 102 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 102 ------------------- 3 files changed, 204 insertions(+), 102 deletions(-)
arch/arm64/boot/dts/qcom/sc7180-idp.dts +102 -0
@@ -598,4 +598,106 @@ pinconf-rx { bias-pull-up; }; }; + + sdc1_on: sdc1-on { + pinconf-clk { + pins = "sdc1_clk"; + bias-disable; + drive-strength = <16>; + }; + + pinconf-cmd { + pins = "sdc1_cmd"; + bias-pull-up; + drive-strength = <10>; + }; + + pinconf-data { + pins = "sdc1_data"; + bias-pull-up; + drive-strength = <10>; + }; + + pinconf-rclk { + pins = "sdc1_rclk"; + bias-pull-down; + }; + }; + + sdc1_off: sdc1-off { + pinconf-clk { + pins = "sdc1_clk"; + bias-disable; + drive-strength = <2>; + }; + + pinconf-cmd { + pins = "sdc1_cmd"; + bias-pull-up; + drive-strength = <2>; + }; + + pinconf-data { + pins = "sdc1_data"; + bias-pull-up; + drive-strength = <2>; + }; + + pinconf-rclk { + pins = "sdc1_rclk"; + bias-pull-down; + }; + }; + + sdc2_on: sdc2-on { + pinconf-clk { + pins = "sdc2_clk"; + bias-disable; + drive-strength = <16>; + }; + + pinconf-cmd { + pins = "sdc2_cmd"; + bias-pull-up; + drive-strength = <10>; + }; + + pinconf-data { + pins = "sdc2_data"; + bias-pull-up; + drive-strength = <10>; + }; + + pinconf-sd-cd { + pins = "gpio69"; + bias-pull-up; + drive-strength = <2>; + }; + }; + + sdc2_off: sdc2-off { + pinconf-clk { + pins = "sdc2_clk"; + bias-disable; + drive-strength = <2>; + }; + + pinconf-cmd { + pins = "sdc2_cmd"; + bias-pull-up; + drive-strength = <2>; + }; + + pinconf-data { + pins = "sdc2_data"; + bias-pull-up; + drive-strength = <2>; + }; + + pinconf-sd-cd { + pins = "gpio69"; + bias-disable; + drive-strength = <2>; + }; + }; };
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +102 -0
106 lines not on this page · raw message
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -102
108 lines not on this page · raw message
Signature · 1 line
2.31.1.818.g46aad6cb9e-goog
PATCH v2 2/2 arm64: dts: qcom: sc7180: trogdor: SD-card GPIO pin set bias-pull up
In reply to Sujit KautkarTrogdor board does not have external pull-up for cd-gpio. Set this pin to internal pull-up for sleep config to avoid frequent regulator toggle events.
This change is aligned with Qualcomm's DT change posted at:
https://patchwork.kernel.org/patch/11675347/
---
Changes in v2:
- added pull-up for IDP
(no changes since v1)
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180-idp.dts +1 -1
@@ -696,7 +696,7 @@ pinconf-data { pinconf-sd-cd { pins = "gpio69"; - bias-disable; + bias-pull-up; drive-strength = <2>; }; };
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +1 -1
@@ -1638,7 +1638,7 @@ pinconf-data { pinconf-sd-cd { pins = "gpio69"; - bias-disable; + bias-pull-up; drive-strength = <2>; }; };
Signature · 1 line
2.31.1.818.g46aad6cb9e-goog
Re: [PATCH v2 2/2] arm64: dts: qcom: sc7180: trogdor: SD-card GPIO pin set bias-pull up
Quoted 1 line · Sujit Kautkar
Trogdor board does not have external pull-up for cd-gpio. Set this pin
This says "Trogdor" specifically, but the diffstats says "all 7180 devices".
Quoted 6 lines
to internal pull-up for sleep config to avoid frequent regulator toggle events.
This change is aligned with Qualcomm's DT change posted at:
https://patchwork.kernel.org/patch/11675347/
I'm sorry, but afacit this says that your v2 is Qualcomm's v2 but with the change I asked for. If this is the case, then your patch is either v3 or you could just mention this below the '---', as I don't see any benefit of carrying this in the git history.
Regards,
Bjorn
Quoted 41 lines
Signed-off-by Sujit Kautkar <[email protected]>Reviewed-by Douglas Anderson <[email protected]>---
Changes in v2:
- added pull-up for IDP(no changes since v1)
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/qcom/sc7180-idp.dts +1
-1@@ -696,7 +696,7 @@ pinconf-data { pinconf-sd-cd { pins = "gpio69"; - bias-disable; + bias-pull-up; drive-strength = <2>; }; };arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +1
-1@@ -1638,7 +1638,7 @@ pinconf-data { pinconf-sd-cd { pins = "gpio69"; - bias-disable; + bias-pull-up; drive-strength = <2>; }; };Signature · 1 line
2.31.1.818.g46aad6cb9e-goog