Skip to contentSkip to conversation

package/vlc: fix build with latest live555

PATCH New Fabrice Fontaine 3 participants 3 messages May 22, 2021 – Jun 7, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/vlc: fix build with latest live555

Fix build failure with live555 raised since commit 6ad1c7f12e57ab7c6f022470e0aacec442d14267

Fixes:
- http://autobuild.buildroot.org/results/83170984f96238756c45bf1f4e542363afafd45f

---
 ...ive555.cpp-fix-build-with-live555-20.patch | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/vlc/0010-modules-access-live555.cpp-fix-build-with-live555-20.patch
package/vlc/0010-modules-access-live555.cpp-fix-build-with-live555-20.patch new file +36 -0
new file mode 100644
index 0000000000..5f046648d4
@@ -0,0 +1,36 @@
+From eba390d13ec4089cd6b9d8687ab3f8905b9d3ac8 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Sat, 22 May 2021 22:56:04 +0200
+Subject: [PATCH] modules/access/live555.cpp: fix build with live555 >=
+ 2020.12.11
+
+Since live555-2020.12.11, connectionEndpointAddress() member function
+use a "struct sockaddr_storage" in preparation for eventual support of
+IPv6: http://www.live555.com/liveMedia/public/changelog.txt
+
+Fixes:
+ - http://autobuild.buildroot.org/results/83170984f96238756c45bf1f4e542363afafd45f
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+---
+ modules/access/live555.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/modules/access/live555.cpp b/modules/access/live555.cpp
+index 9d6e01ae32..32a6c294eb 100644
+--- a/modules/access/live555.cpp
++++ b/modules/access/live555.cpp
+@@ -850,7 +850,9 @@ static int SessionsSetup( demux_t *p_demux )
+             if( !p_sys->b_multicast )
+             {
+                 /* We need different rollover behaviour for multicast */
+-                p_sys->b_multicast = IsMulticastAddress( sub->connectionEndpointAddress() );
++                struct sockaddr_storage tempAddr;
++                sub->getConnectionEndpointAddress( tempAddr );
++                p_sys->b_multicast = IsMulticastAddress( tempAddr );
+             }
+ 
+             tk = (live_track_t*)malloc( sizeof( live_track_t ) );
+-- 
+2.30.2
+
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/vlc: fix build with latest live555

Fabrice, All,

On 2021-05-22 23:41 +0200, Fabrice Fontaine spake thusly:

Quoted 7 lines

Fix build failure with live555 raised since commit 6ad1c7f12e57ab7c6f022470e0aacec442d14267

Fixes:
- http://autobuild.buildroot.org/results/83170984f96238756c45bf1f4e542363afafd45f

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 54 lines
---
 ...ive555.cpp-fix-build-with-live555-20.patch | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 package/vlc/0010-modules-access-live555.cpp-fix-build-with-live555-20.patch
package/vlc/0010-modules-access-live555.cpp-fix-build-with-live555-20.patch new file +36 -0
new file mode 100644
index 0000000000..5f046648d4
@@ -0,0 +1,36 @@
+From eba390d13ec4089cd6b9d8687ab3f8905b9d3ac8 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Sat, 22 May 2021 22:56:04 +0200
+Subject: [PATCH] modules/access/live555.cpp: fix build with live555 >=
+ 2020.12.11
+
+Since live555-2020.12.11, connectionEndpointAddress() member function
+use a "struct sockaddr_storage" in preparation for eventual support of
+IPv6: http://www.live555.com/liveMedia/public/changelog.txt
+
+Fixes:
+ - http://autobuild.buildroot.org/results/83170984f96238756c45bf1f4e542363afafd45f
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+---
+ modules/access/live555.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/modules/access/live555.cpp b/modules/access/live555.cpp
+index 9d6e01ae32..32a6c294eb 100644
+--- a/modules/access/live555.cpp
++++ b/modules/access/live555.cpp
+@@ -850,7 +850,9 @@ static int SessionsSetup( demux_t *p_demux )
+             if( !p_sys->b_multicast )
+             {
+                 /* We need different rollover behaviour for multicast */
+-                p_sys->b_multicast = IsMulticastAddress( sub->connectionEndpointAddress() );
++                struct sockaddr_storage tempAddr;
++                sub->getConnectionEndpointAddress( tempAddr );
++                p_sys->b_multicast = IsMulticastAddress( tempAddr );
+             }
+ 
+             tk = (live_track_t*)malloc( sizeof( live_track_t ) );
+-- 
+2.30.2
+
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/vlc: fix build with latest live555

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Fix build failure with live555 raised since commit 6ad1c7f12e57ab7c6f022470e0aacec442d14267

Fixes:
- http://autobuild.buildroot.org/results/83170984f96238756c45bf1f4e542363afafd45f

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard