Skip to contentSkip to conversation

Makefile: fix GDB warning with CONFIG_RELR

PATCH Superseded Nick Desaulniers 5 participants 8 messages Mar 19, 2021 – Jun 8, 2021 1 message not in the archive Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: fix GDB warning with CONFIG_RELR

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

---
 Makefile                      | 2 +-
 scripts/tools-support-relr.sh | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Makefile +1 -1
index 5160ff8903c1..47741cb60995 100644
@@ -1088,7 +1088,7 @@ LDFLAGS_vmlinux	+= $(call ld-option, -X,)
 endif
 
 ifeq ($(CONFIG_RELR),y)
-LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr
+LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr --use-android-relr-tags
 endif
 
 # We never want expected sections to be placed heuristically by the
scripts/tools-support-relr.sh +2 -1
index 45e8aa360b45..cb55878bd5b8 100755
@@ -7,7 +7,8 @@ trap "rm -f $tmp_file.o $tmp_file $tmp_file.bin" EXIT
 cat << "END" | $CC -c -x c - -o $tmp_file.o >/dev/null 2>&1
 void *p = &p;
 END
-$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr -o $tmp_file
+$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr \
+  --use-android-relr-tags -o $tmp_file
 
 # Despite printing an error message, GNU nm still exits with exit code 0 if it
 # sees a relr section. So we need to check that nothing is printed to stderr.
Signature · 1 line
2.31.0.rc2.261.g7f71774620-goog
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

Quoted 3 lines
Quoted 35 lines
---
 Makefile                      | 2 +-
 scripts/tools-support-relr.sh | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Makefile +1 -1
index 5160ff8903c1..47741cb60995 100644
@@ -1088,7 +1088,7 @@ LDFLAGS_vmlinux	+= $(call ld-option, -X,)
 endif
 
 ifeq ($(CONFIG_RELR),y)
-LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr
+LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr --use-android-relr-tags
 endif
 
 # We never want expected sections to be placed heuristically by the
scripts/tools-support-relr.sh +2 -1
index 45e8aa360b45..cb55878bd5b8 100755
@@ -7,7 +7,8 @@ trap "rm -f $tmp_file.o $tmp_file $tmp_file.bin" EXIT
 cat << "END" | $CC -c -x c - -o $tmp_file.o >/dev/null 2>&1
 void *p = &p;
 END
-$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr -o $tmp_file
+$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr \
+  --use-android-relr-tags -o $tmp_file
 
 # Despite printing an error message, GNU nm still exits with exit code 0 if it
 # sees a relr section. So we need to check that nothing is printed to stderr.
Signature · 1 line
2.31.0.rc2.261.g7f71774620-goog

A message that is not in the archive (sent off-list or not yet received): CAF2Aj3i3-bev_iS6OrBUTzt==4d0f7UiTeY1YPur6eKFqToFYQ@mail.gmail.com

#3 lore raw
Quoted 22 lines · Lee Jones
Quoted 20 lines · Nathan Chancellor
Quoted 17 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

Quoted 7 lines
Quoted 1 line

Masahiro,

Would you mind sharing your plans for this reviewed patch please?

Do you want me to pick up this?

Or, do you think it should be done by the committer of 5cf896fb6be3effd9aea455b22213e27be8bdb1d ?

Signature · 2 lines
Best Regards
Masahiro Yamada
#4 lore raw

PATCH v2 1/1 Makefile: fix GDB warning with CONFIG_RELR

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

---
Changes V1 -> V2:
* rebase
* pick up Nathan's reviewed by tag.

 Makefile                      | 2 +-
 scripts/tools-support-relr.sh | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Makefile +1 -1
index 0ed7e061c8e9..2dbb56f831d4 100644
@@ -1031,7 +1031,7 @@ LDFLAGS_vmlinux	+= $(call ld-option, -X,)
 endif
 
 ifeq ($(CONFIG_RELR),y)
-LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr
+LDFLAGS_vmlinux	+= --pack-dyn-relocs=relr --use-android-relr-tags
 endif
 
 # We never want expected sections to be placed heuristically by the
scripts/tools-support-relr.sh +2 -1
index 45e8aa360b45..cb55878bd5b8 100755
@@ -7,7 +7,8 @@ trap "rm -f $tmp_file.o $tmp_file $tmp_file.bin" EXIT
 cat << "END" | $CC -c -x c - -o $tmp_file.o >/dev/null 2>&1
 void *p = &p;
 END
-$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr -o $tmp_file
+$LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=relr \
+  --use-android-relr-tags -o $tmp_file
 
 # Despite printing an error message, GNU nm still exits with exit code 0 if it
 # sees a relr section. So we need to check that nothing is printed to stderr.

base-commit: 45af60e7ced07ae3def41368c3d260dbf496fbce

Signature · 1 line
2.31.1.818.g46aad6cb9e-goog
#5 lore raw
Quoted 18 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

Quoted 8 lines

---
Changes V1 -> V2:
* rebase
* pick up Nathan's reviewed by tag.

 Makefile                      | 2 +-
 scripts/tools-support-relr.sh | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Does lld support RELR relocations for any architectures other than arm64? If so, is the "--use-android-relr-tags" option supported on all of those as well?

Will

#6 lore raw
Quoted 25 lines · Will Deacon
Quoted 23 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

---
Changes V1 -> V2:
* rebase
* pick up Nathan's reviewed by tag.

Quoted 5 lines
Quoted 3 lines
 Makefile                      | 2 +-
 scripts/tools-support-relr.sh | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Does lld support RELR relocations for any architectures other than arm64? If

Yes; from what I can tell it's not an architecture specific relocation type. Combing through LLVM's sources, it seems Fuchsia sets it always (at least when using lld) and I'm pretty sure they support x86. At least I don't get any errors out of LLD when building with --pack-dyn-relocs=relr on x86.

I can force on RELR for x86 kernel builds with:

```
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 0045e1b44190..513272c77827 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2117,6 +2117,7 @@ config PHYSICAL_START

 config RELOCATABLE
        bool "Build a relocatable kernel"
+       select ARCH_HAS_RELR
        default y
        help
          This builds a kernel image that retains relocation information
```

That builds (it won't boot because we don't have the machinery in the kernel to self relocate that type, yet).

Quoted 2 lines

so, is the "--use-android-relr-tags" option supported on all of those as well?

I believe so; no issues building with this patch and with the above diff applied on x86. All that flag does is change the elf section type from SHT_RELR to SHT_ANDROID_RELR.

pcc@ can correct me if I'm wrong.

Signature · 2 lines
Thanks,
~Nick Desaulniers
#7 lore raw
In reply to Nick Desaulniers
Quoted 9 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

[...]

Applied to arm64 (for-next/build), thanks!

[1/1] Makefile: fix GDB warning with CONFIG_RELR

      https://git.kernel.org/arm64/c/27f2a4db76e8

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
#8 lore raw
In reply to Masahiro Yamada
Quoted 28 lines · Masahiro Yamada
Quoted 27 lines · Lee Jones
Quoted 16 lines · Nathan Chancellor
Quoted 14 lines · Nick Desaulniers

GDB produces the following warning when debugging kernels built with CONFIG_RELR:

BFD: /android0/linux-next/vmlinux: unknown type [0x13] section `.relr.dyn'

when loading a kernel built with CONFIG_RELR into GDB. It can also prevent debugging symbols using such relocations.

Peter sugguests:
[That flag] means that lld will use dynamic tags and section type numbers in the OS-specific range rather than the generic range. The kernel itself doesn't care about these numbers; it determines the location of the RELR section using symbols defined by a linker script.

Quoted 5 lines
Quoted 3 lines

Masahiro,

Quoted 7 lines
Quoted 1 line

Would you mind sharing your plans for this reviewed patch please?

Do you want me to pick up this?

Or, do you think it should be done by the committer of 5cf896fb6be3effd9aea455b22213e27be8bdb1d ?

Not sure it matters a whole bunch TBH. If you have the bandwidth and are willing to merge it, please feel free to do so.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog