Skip to contentSkip to conversation

arm64: smccc: Support SMCCC v1.3 SVE register saving hint

PATCH Superseded Mark Brown 3 participants 7 messages May 24, 2021 – Jun 1, 2021

Subsystems (2)

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH v4 1/1 arm64: smccc: Support SMCCC v1.3 SVE register saving hint

SMCCC v1.2 requires that all SVE state be preserved over SMC calls which introduces substantial overhead in the common case where there is no SVE state in the registers. To avoid this SMCCC v1.3 introduces a flag which allows the caller to say that there is no state that needs to be preserved in the registers. Make use of this flag, setting it if the SMCCC version indicates support for it and the TIF_ flags indicate that there is no live SVE state in the registers, this avoids placing any constraints on when SMCCC calls can be done or triggering extra saving and reloading of SVE register state in the kernel.

This would be straightforward enough except for the rather entertaining inline assembly we use to do SMCCC v1.1 calls to allow us to take advantage of the limited number of registers it clobbers. Deal with this by having a function which we call immediately before issuing the SMCCC call to make our checks and set the flag. Using alternatives the overhead if SVE is supported but not detected at runtime can be reduced to a single NOP.

---

v4:
- Also clobber cc as per suggestion from Ard.
- Rebase onto v5.13-rc3.

 arch/arm64/kernel/smccc-call.S | 26 ++++++++++++++++++++++++++
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)
arch/arm64/kernel/smccc-call.S +26 -0
index d62447964ed9..dbc96dbe2be2 100644
@@ -7,8 +7,34 @@
 
 #include <asm/asm-offsets.h>
 #include <asm/assembler.h>
+#include <asm/thread_info.h>
+
+/*
+ * If we have SMCCC v1.3 and (as is likely) no SVE state in
+ * the registers then set the SMCCC hint bit to say there's no
+ * need to preserve it.  Do this by directly adjusting the SMCCC
+ * function value which is already stored in x0 ready to be called.
+ */
+SYM_FUNC_START(__smccc_sve_check)
+
+	ldr_l	x16, smccc_has_sve_hint
+	cbz	x16, 2f
+
+	get_current_task x16
+	ldr	x16, [x16, #TSK_TI_FLAGS]
+	tbnz	x16, #TIF_FOREIGN_FPSTATE, 1f	// Any live FP state?
+	tbnz	x16, #TIF_SVE, 2f		// Does that state include SVE?
+
+1:	orr	x0, x0, ARM_SMCCC_1_3_SVE_HINT
+
+2:	ret
+SYM_FUNC_END(__smccc_sve_check)
+EXPORT_SYMBOL(__smccc_sve_check)
 
 	.macro SMCCC instr
+alternative_if ARM64_SVE
+	bl	__smccc_sve_check
+alternative_else_nop_endif
 	\instr	#0
 	ldr	x4, [sp]
 	stp	x0, x1, [x4, #ARM_SMCCC_RES_X0_OFFS]
drivers/firmware/smccc/smccc.c +4 -0
index 028f81d702cc..9f937b125ab0 100644
@@ -15,6 +15,7 @@ static u32 smccc_version = ARM_SMCCC_VERSION_1_0;
 static enum arm_smccc_conduit smccc_conduit = SMCCC_CONDUIT_NONE;
 
 bool __ro_after_init smccc_trng_available = false;
+u64 __ro_after_init smccc_has_sve_hint = false;
 
 void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit)
 {
@@ -22,6 +23,9 @@ void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit)
 	smccc_conduit = conduit;
 
 	smccc_trng_available = smccc_probe_trng();
+	if (IS_ENABLED(CONFIG_ARM64_SVE) &&
+	    smccc_version >= ARM_SMCCC_VERSION_1_3)
+		smccc_has_sve_hint = true;
 }
 
 enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
include/linux/arm-smccc.h +22 -2
index 6861489a1890..407610021a56 100644
@@ -63,6 +63,9 @@
 #define ARM_SMCCC_VERSION_1_0		0x10000
 #define ARM_SMCCC_VERSION_1_1		0x10001
 #define ARM_SMCCC_VERSION_1_2		0x10002
+#define ARM_SMCCC_VERSION_1_3		0x10003
+
+#define ARM_SMCCC_1_3_SVE_HINT		0x10000
 
 #define ARM_SMCCC_VERSION_FUNC_ID					\
 	ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL,				\
@@ -216,6 +219,8 @@ u32 arm_smccc_get_version(void);
 
 void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit);
 
+extern u64 smccc_has_sve_hint;
+
 /**
  * struct arm_smccc_res - Result from SMC/HVC call
  * @a0-a3 result values from registers 0 to 3
@@ -297,6 +302,20 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
 
 #endif
 
+/* nVHE hypervisor doesn't have a current thread so needs separate checks */
+#if defined(CONFIG_ARM64_SVE) && !defined(__KVM_NVHE_HYPERVISOR__)
+
+#define SMCCC_SVE_CHECK ALTERNATIVE("nop \n",  "bl __smccc_sve_check \n", \
+				    ARM64_SVE)
+#define smccc_sve_clobbers "x16", "lr", "cc",
+
+#else
+
+#define SMCCC_SVE_CHECK
+#define smccc_sve_clobbers
+
+#endif
+
 #define ___count_args(_0, _1, _2, _3, _4, _5, _6, _7, _8, x, ...) x
 
 #define __count_args(...)						\
@@ -364,7 +383,7 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
 
 #define ___constraints(count)						\
 	: __constraint_read_ ## count					\
-	: "memory"
+	: smccc_sve_clobbers "memory"
 #define __constraints(count)	___constraints(count)
 
 /*
@@ -379,7 +398,8 @@ asmlinkage void __arm_smccc_hvc(unsigned long a0, unsigned long a1,
 		register unsigned long r2 asm("r2");			\
 		register unsigned long r3 asm("r3"); 			\
 		__declare_args(__count_args(__VA_ARGS__), __VA_ARGS__);	\
-		asm volatile(inst "\n" :				\
+		asm volatile(SMCCC_SVE_CHECK				\
+			     inst "\n" :				\
 			     "=r" (r0), "=r" (r1), "=r" (r2), "=r" (r3)	\
 			     __constraints(__count_args(__VA_ARGS__)));	\
 		if (___res)						\
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw
Quoted 21 lines · Mark Brown

SMCCC v1.2 requires that all SVE state be preserved over SMC calls which introduces substantial overhead in the common case where there is no SVE state in the registers. To avoid this SMCCC v1.3 introduces a flag which allows the caller to say that there is no state that needs to be preserved in the registers. Make use of this flag, setting it if the SMCCC version indicates support for it and the TIF_ flags indicate that there is no live SVE state in the registers, this avoids placing any constraints on when SMCCC calls can be done or triggering extra saving and reloading of SVE register state in the kernel.

This would be straightforward enough except for the rather entertaining inline assembly we use to do SMCCC v1.1 calls to allow us to take advantage of the limited number of registers it clobbers. Deal with this by having a function which we call immediately before issuing the SMCCC call to make our checks and set the flag. Using alternatives the overhead if SVE is supported but not detected at runtime can be reduced to a single NOP.

---

Quoted 8 lines

v4:
- Also clobber cc as per suggestion from Ard.
- Rebase onto v5.13-rc3.

 arch/arm64/kernel/smccc-call.S | 26 ++++++++++++++++++++++++++
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)

This fails to build for me:

Failed to build : cfc21861dca9 arm64: smccc: Support SMCCC v1.3 SVE register saving hint
Configuration: "defconfig-arm64-aarch64-linux-gnu-".

  592 |  arm_smccc_1_1_invoke(ARM_SMCCC_ARCH_WORKAROUND_2, true, NULL);
      |  ^~~~~~~~~~~~~~~~~~~~
include/linux/arm-smccc.h:456:3: error: unknown register name ‘lr’ in ‘asm’
  456 |   asm volatile(SMCCC_SVE_CHECK    \
      |   ^~~
include/linux/arm-smccc.h:478:32: note: in expansion of macro ‘__arm_smccc_1_1’
  478 | #define arm_smccc_1_1_smc(...) __arm_smccc_1_1(SMCCC_SMC_INST, __VA_ARGS__)
      |                                ^~~~~~~~~~~~~~~
include/linux/arm-smccc.h:531:4: note: in expansion of macro ‘arm_smccc_1_1_smc’
  531 |    arm_smccc_1_1_smc(__VA_ARGS__);   \
      |    ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/proton-pack.c:592:2: note: in expansion of macro ‘arm_smccc_1_1_invoke’
  592 |  arm_smccc_1_1_invoke(ARM_SMCCC_ARCH_WORKAROUND_2, true, NULL);
      |  ^~~~~~~~~~~~~~~~~~~~
include/linux/arm-smccc.h:504:3: error: unknown register name ‘lr’ in ‘asm’
  504 |   asm ("" : __constraints(__count_args(__VA_ARGS__))); \
      |   ^~~
include/linux/arm-smccc.h:534:4: note: in expansion of macro ‘__fail_smccc_1_1’
  534 |    __fail_smccc_1_1(__VA_ARGS__);   \
      |    ^~~~~~~~~~~~~~~~
arch/arm64/kernel/proton-pack.c:592:2: note: in expansion of macro ‘arm_smccc_1_1_invoke’
  592 |  arm_smccc_1_1_invoke(ARM_SMCCC_ARCH_WORKAROUND_2, true, NULL);
      |  ^~~~~~~~~~~~~~~~~~~~

make[3]: *** [scripts/Makefile.build:272: arch/arm64/kernel/proton-pack.o] Error 1

Maybe need an x30 instead of lr?

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#2 lore raw
Quoted 7 lines · Will Deacon
Quoted 3 lines · Mark Brown
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)

This fails to build for me:

Interesting... which toolchain are you using here?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 7 lines · Will Deacon
Quoted 3 lines · Mark Brown
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)

This fails to build for me:

Interesting... which toolchain are you using here?

That's a good question.

/me digs into scripts

I think it's:

gcc version 9.2.1 20191025 (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10))

But note that we actually have a register alias in asm/assembler.h so maybe just a missing include?

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#4 lore raw
Quoted 12 lines · Will Deacon
Quoted 10 lines · Mark Brown
Quoted 7 lines · Will Deacon
Quoted 3 lines · Mark Brown
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)

This fails to build for me:

Interesting... which toolchain are you using here?

Quoted 7 lines

That's a good question.

/me digs into scripts

I think it's:

gcc version 9.2.1 20191025 (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10))

Duh, I suppose you're probably more interested in the assembler:

GNU assembler (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10)) 2.33.1.20191209

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw
Quoted 18 lines · Will Deacon
Quoted 16 lines · Will Deacon
Quoted 10 lines · Mark Brown
Quoted 7 lines · Will Deacon
Quoted 3 lines · Mark Brown
 drivers/firmware/smccc/smccc.c |  4 ++++
 include/linux/arm-smccc.h      | 24 ++++++++++++++++++++++--
 3 files changed, 52 insertions(+), 2 deletions(-)

This fails to build for me:

Interesting... which toolchain are you using here?

That's a good question.

/me digs into scripts

Quoted 8 lines
Quoted 3 lines

I think it's:

gcc version 9.2.1 20191025 (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10))

Duh, I suppose you're probably more interested in the assembler:

GNU assembler (GNU Toolchain for the A-profile Architecture 9.2-2019.12 (arm-9.10)) 2.33.1.20191209

Didn't we run into this before?

IIRC, lr was never defined as a register alias for x30, which is why we have the .req in 8f5c9037a55b. This caused breakage when the GNU folks tried to add the lr alias, as the .req would be rejected now, so they removed it again. (I might be misremembering, but something along those lines did occur)

In summary, let's just use x30 in the clobber list and be done with it.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel