Skip to contentSkip to conversation

p7zip: build and package lib7z.so needed for fastboot

PATCH New Nisha Parrakat 1 participant 2 messages May 26, 2021 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 p7zip: build and package lib7z.so needed for fastboot

From: Nisha Parrakat <[email protected]>

a) use option 7z to build the lib7z.so library This is needed for android-tools for building fastboot from android-tools

b) Packaged the lib7z.so and codec libraries as a part of this recipe Fastboot RDepends on it lib7z.so

c) Fixed a C++17 forbidden error when lib7z.so is built

fixes the below error

| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp: In member function 'virtual LONG NArchive::NWim::CHandler::GetArchiveProperty(PROPID, PROPVARIANT*)':
| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp:308:11: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
|   308 |           numMethods++;
|       |           ^~~~~~~~~~
| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp:318:9: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
|   318 |         numMethods++;
---
 ...nge_numMethods_from_bool_to_unsigned.patch | 25 +++++++++++++++++++
 meta-oe/recipes-extended/p7zip/p7zip_16.02.bb | 21 ++++++++++++++--
 2 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 meta-oe/recipes-extended/p7zip/files/change_numMethods_from_bool_to_unsigned.patch
meta-oe/recipes-extended/p7zip/files/change_numMethods_from_bool_to_unsigned.patch new file +25 -0
new file mode 100644
index 000000000..edde52593
@@ -0,0 +1,25 @@
+fixes the below error
+
+| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp: In member function 'virtual LONG NArchive::NWim::CHandler::GetArchiveProperty(PROPID, PROPVARIANT*)':
+| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp:308:11: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
+|   308 |           numMethods++;
+|       |           ^~~~~~~~~~
+| ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp:318:9: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
+|   318 |         numMethods++;
+
+
+use unsigned instead of bool
+Signed-off-by: Nisha Parrakat <[email protected]>
+
+Upstream-Status: Pending
+--- ./CPP/7zip/Archive/Wim/WimHandler.cpp       2021-05-20 10:51:56.997402701 +0000
++++ ./CPP/7zip/Archive/Wim/WimHandler.cpp       2021-05-20 10:52:16.665604125 +0000
+@@ -298,7 +298,7 @@
+
+       AString res;
+
+-      bool numMethods = 0;
++      unsigned numMethods = 0;
+       for (unsigned i = 0; i < ARRAY_SIZE(k_Methods); i++)
+       {
+         if (methodMask & ((UInt32)1 << i
meta-oe/recipes-extended/p7zip/p7zip_16.02.bb +19 -2
index 13479a90f..ada49114c 100644
@@ -9,6 +9,7 @@ SRC_URI = "http://downloads.sourceforge.net/p7zip/p7zip/${PV}/p7zip_${PV}_src_al
            file://do_not_override_compiler_and_do_not_strip.patch \
            file://CVE-2017-17969.patch \
            file://0001-Fix-narrowing-errors-Wc-11-narrowing.patch \
+           file://change_numMethods_from_bool_to_unsigned.patch \
            "
 
 SRC_URI[md5sum] = "a0128d661cfe7cc8c121e73519c54fbf"
@@ -16,10 +17,26 @@ SRC_URI[sha256sum] = "5eb20ac0e2944f6cb9c2d51dd6c4518941c185347d4089ea89087ffdd6
 
 S = "${WORKDIR}/${BPN}_${PV}"
 
+do_compile_append() {
+    oe_runmake 7z
+}
+FILES_${PN} += "${libdir}/* ${bindir}/7z"
+
+FILES_SOLIBSDEV = ""
+INSANE_SKIP_${PN} += "dev-so"
+
 do_install() {
        install -d ${D}${bindir}
-       install -m 0755 ${S}/bin/* ${D}${bindir}
+       install -d ${D}${bindir}/Codecs
+       install -d ${D}${libdir}
+       install -d ${D}${libdir}/Codecs
+       install -m 0755 ${S}/bin/7za ${D}${bindir}
        ln -s 7za ${D}${bindir}/7z
+       install -m 0755 ${S}/bin/Codecs/* ${D}${libdir}/Codecs/
+       install -m 0755 ${S}/bin/7z.so ${D}${libdir}/lib7z.so
 }
 
-BBCLASSEXTEND = "native"
+RPROVIDES_${PN} += "lib7z.so()(64bit) 7z lib7z.so"
+RPROVIDES_${PN}-dev += "lib7z.so()(64bit) 7z lib7z.so"
+
+BBCLASSEXTEND = "native nativesdk"

--
2.17.1

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

#1 lore raw

PATCH 2/2 android-tools: upgrade android-tools to latest debian 10.0.0.r36

From: Nisha Parrakat <[email protected]>

upgrade of android-tools to 10.0.0.r36

Delete all the old patches that were applicable for old version.

Use all the makefiles that come with the new version directly from the source code, just modifying them to install output to a specific folder

a)added rules_yocto.mk that will mimic the debian/rules b)modified the makefiles of the components to output to a common dir.
c)
Built boringssl crypto with the option -DOPENSSL_NO_ASM to solve the below errors

libcrypto.so.0: undefined reference to aes_hw_encrypt' libcrypto.so.0: undefined reference to aes_hw_set_encrypt_key' libcrypto.so.0: undefined reference to gcm_gmult_v8' libcrypto.so.0: undefined reference to gcm_init_v8' libcrypto.so.0: undefined reference to sha256_block_data_order' libcrypto.so.0: undefined reference to aes_hw_ctr32_encrypt_blocks' libcrypto.so.0: undefined reference to aes_hw_cbc_encrypt' libcrypto.so.0: undefined reference to vpaes_decrypt' libcrypto.so.0: undefined reference to vpaes_encrypt' libcrypto.so.0: undefined reference to gcm_gmult_neon' libcrypto.so.0: undefined reference to sha1_block_data_order' libcrypto.so.0: undefined reference to sha512_block_data_order' libcrypto.so.0: undefined reference to gcm_init_neon' libcrypto.so.0: undefined reference to aes_hw_set_decrypt_key' libcrypto.so.0: undefined reference to vpaes_set_decrypt_key' libcrypto.so.0: undefined reference to gcm_ghash_neon' libcrypto.so.0: undefined reference to bn_mul_mont' libcrypto.so.0: undefined reference to aes_hw_decrypt' libcrypto.so.0: undefined reference to gcm_ghash_v8' libcrypto.so.0: undefined reference to vpaes_cbc_encrypt' libcrypto.so.0: undefined reference to ChaCha20_ctr32' libcrypto.so.0: undefined reference to vpaes_ctr32_encrypt_blocks' libcrypto.so.0: undefined reference to `vpaes_set_encrypt_key'

Attention : https://github.com/grpc/grpc/issues/9440

d) compiled android compatible version of libunwind to be used to build libbacktrace
e) REQUIRES meta-selinux for libselinux
f) checked compilation and packaging for for x86_64 and aarch64
g) UNTESTED android-tools-adbd.service , couldn't find how to build adbd that is needed by the service with the new version of android-tools. At present the service is still packaged but may not work.
h) tested the adb and fastboot on the core-image-minimal by including the android-tools in the image and ran the commands with 'help'

---
 .../android-tools/android-tools/adb.mk        |  72 ----
 .../android-tools/adb_mk_change_out_dir.patch |  50 +++
 .../android-tools/android-tools/adbd.mk       | 164 --------
 ...scv-Add-risc-v-Android-config-header.patch | 359 ------------------
 .../0001-adb-remove-selinux-extensions.patch  |  44 ---
 ...-Use-local-sockets-where-appropriate.patch |  70 ----
 .../core/0003-adb-define-shell-command.patch  |  29 --
 ...-adb-Fix-build-on-big-endian-systems.patch |  45 ---
 .../0005-adb-add-base64-implementation.patch  | 348 -----------------
 .../core/0006-adb-Musl-fixes.patch            | 131 -------
 ...sb_linux.c-fix-build-with-glibc-2.28.patch |  24 --
 ...008-adb-Allow-adbd-to-be-ran-as-root.patch |  21 -
 ...Add-dt-parameter-to-specify-DT-image.patch | 110 ------
 ...ux-capability.h-on-linux-systems-too.patch |  23 --
 .../0011-Remove-bionic-specific-calls.patch   |  64 ----
 ...laration-of-stlcat-strlcopy-function.patch |  50 ---
 .../core/0013-adb-Support-riscv64.patch       | 189 ---------
 .../android-tools/core/adb_libssl_11.diff     |  39 --
 .../android-tools/android-tools/ext4_utils.mk | 103 -----
 ...ext4_utils-remove-selinux-extensions.patch |  39 --
 ...add-o-argument-to-preserve-ownership.patch |  78 ----
 .../android-tools/android-tools/fastboot.mk   |  89 -----
 .../fastboot_compile_remove_gtest.patch       |  51 +++
 .../fastboot_mk_change_out_dir.patch          |  52 +++
 .../android-tools/android-tools/gitignore     |  59 ---
 .../img2simg_change_out_dir.patch             |  41 ++
 .../libadb_mk_change_out_dir.patch            |  44 +++
 .../libbacktrace_mk_change_out_dir.patch      |  60 +++
 .../libbase_mk_change_out_dir.patch           |  33 ++
 .../libcrypto_mk_change_out_dir.patch         |  30 ++
 .../libcrypto_utils_mk_change_out_dir.patch   |  38 ++
 .../libcutils_mk_change_out_dir.patch         |  27 ++
 .../libext4_utils_mk_change_out_dir.patch     |  42 ++
 .../libfec_mk_change_out_dir.patch            |  35 ++
 .../liblog_mk_change_out_dir.patch            |  42 ++
 .../0001-Remove-bionic-specific-calls.patch   |  25 --
 ...t-define-gettid-if-glibc-2.30-is-use.patch |  49 ---
 .../libsparse_mk_change_out_dir.patch         |  47 +++
 .../libunwind_mk_change_out_dir.patch         |  47 +++
 .../libziparchive_mk_change_out_dir.patch     |  47 +++
 .../android-tools/android-tools/mkbootimg.mk  |  29 --
 .../android-tools/rules_yocto.mk              |   4 +
 .../simg2img_change_out_dir.patch             |  41 ++
 ...me_space_std_to_compile_libbacktrace.patch |  19 +
 .../android-tools/android-tools_10.0.0.r36.bb | 204 ++++++++++
 .../android-tools/android-tools_5.1.1.r37.bb  | 182 ---------
 46 files changed, 954 insertions(+), 2435 deletions(-)
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/adb.mk
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/adb_mk_change_out_dir.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/adbd.mk
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/build/0001-Riscv-Add-risc-v-Android-config-header.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0001-adb-remove-selinux-extensions.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0002-adb-Use-local-sockets-where-appropriate.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0003-adb-define-shell-command.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0004-adb-Fix-build-on-big-endian-systems.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0005-adb-add-base64-implementation.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0006-adb-Musl-fixes.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0007-adb-usb_linux.c-fix-build-with-glibc-2.28.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0008-adb-Allow-adbd-to-be-ran-as-root.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0009-mkbootimg-Add-dt-parameter-to-specify-DT-image.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0010-Use-linux-capability.h-on-linux-systems-too.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0011-Remove-bionic-specific-calls.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0012-Fix-implicit-declaration-of-stlcat-strlcopy-function.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/0013-adb-Support-riscv64.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/core/adb_libssl_11.diff
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/ext4_utils.mk
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/extras/0001-ext4_utils-remove-selinux-extensions.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/fastboot.mk
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/fastboot_compile_remove_gtest.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/fastboot_mk_change_out_dir.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/gitignore
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/img2simg_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libadb_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libbacktrace_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libbase_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libcrypto_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libcrypto_utils_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libcutils_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libext4_utils_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libfec_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/liblog_mk_change_out_dir.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libselinux/0001-Remove-bionic-specific-calls.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libselinux/0001-libselinux-Do-not-define-gettid-if-glibc-2.30-is-use.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libsparse_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libunwind_mk_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/libziparchive_mk_change_out_dir.patch
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/mkbootimg.mk
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/rules_yocto.mk
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/simg2img_change_out_dir.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools/use_name_space_std_to_compile_libbacktrace.patch
 create mode 100644 meta-oe/recipes-devtools/android-tools/android-tools_10.0.0.r36.bb
 delete mode 100644 meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb
meta-oe/recipes-devtools/android-tools/android-tools/adb.mk deleted +0 -72
deleted file mode 100644
index 0687c22c1..000000000
@@ -1,72 +0,0 @@
-# Makefile for adb
-
-SRCDIR ?= $(S)
-
-VPATH += $(SRCDIR)/system/core/adb
-adb_SRC_FILES += adb.c
-adb_SRC_FILES += console.c
-adb_SRC_FILES += transport.c
-adb_SRC_FILES += transport_local.c
-adb_SRC_FILES += transport_usb.c
-adb_SRC_FILES += commandline.c
-adb_SRC_FILES += adb_client.c
-adb_SRC_FILES += adb_auth_host.c
-adb_SRC_FILES += sockets.c
-adb_SRC_FILES += services.c
-adb_SRC_FILES += file_sync_client.c
-adb_SRC_FILES += get_my_path_linux.c
-adb_SRC_FILES += usb_linux.c
-adb_SRC_FILES += usb_vendors.c
-adb_SRC_FILES += fdevent.c
-adb_OBJS := $(adb_SRC_FILES:.c=.o)
-
-VPATH += $(SRCDIR)/system/core/libcutils
-libcutils_SRC_FILES += atomic.c
-libcutils_SRC_FILES += hashmap.c
-libcutils_SRC_FILES += native_handle.c
-libcutils_SRC_FILES += config_utils.c
-libcutils_SRC_FILES += cpu_info.c
-libcutils_SRC_FILES += load_file.c
-# libcutils_SRC_FILES += open_memstream.c
-# libcutils_SRC_FILES += strdup16to8.c
-# libcutils_SRC_FILES += strdup8to16.c
-# libcutils_SRC_FILES += record_stream.c
-# libcutils_SRC_FILES += process_name.c
-# libcutils_SRC_FILES += threads.c
-# libcutils_SRC_FILES += sched_policy.c
-# libcutils_SRC_FILES += iosched_policy.c
-libcutils_SRC_FILES += str_parms.c
-libcutils_SRC_FILES += fs.c
-libcutils_SRC_FILES += multiuser.c
-libcutils_SRC_FILES += socket_inaddr_any_server.c
-libcutils_SRC_FILES += socket_local_client.c
-libcutils_SRC_FILES += socket_local_server.c
-libcutils_SRC_FILES += socket_loopback_client.c
-libcutils_SRC_FILES += socket_loopback_server.c
-libcutils_SRC_FILES += socket_network_client.c
-libcutils_SRC_FILES += sockets.c
-libcutils_SRC_FILES += ashmem-host.c
-libcutils_SRC_FILES += dlmalloc_stubs.c
-libcutils_OBJS := $(libcutils_SRC_FILES:.c=.o)
-
-CFLAGS += -DANDROID
-CFLAGS += -DWORKAROUND_BUG6558362
-CFLAGS += -DADB_HOST=1
-CFLAGS += -D_XOPEN_SOURCE -D_GNU_SOURCE
-CFLAGS += -DANDROID_SMP=0
-CFLAGS += -I$(SRCDIR)/system/core/adb
-CFLAGS += -I$(SRCDIR)/system/core/include
-CFLAGS += -include $(SRCDIR)/build/core/combo/include/arch/$(android_arch)/AndroidConfig.h
-
-LIBS += libcutils.a -lpthread -lcrypto
-
-all: adb
-
-adb: libcutils.a $(adb_OBJS)
-       $(CC) -o $@ $(LDFLAGS) $(adb_OBJS) $(LIBS)
-
-libcutils.a: $(libcutils_OBJS)
-       $(AR) rcs $@ $(libcutils_OBJS)
-
-clean:
-       $(RM) $(adb_OBJS) $(libcutils_OBJS) adb *.a
meta-oe/recipes-devtools/android-tools/android-tools/adb_mk_change_out_dir.patch new file +50 -0

50 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/adbd.mk deleted +0 -164

164 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/build/0001-Riscv-Add-risc-v-Android-config-header.patch deleted +0 -359

359 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0001-adb-remove-selinux-extensions.patch deleted +0 -44

44 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0002-adb-Use-local-sockets-where-appropriate.patch deleted +0 -70

70 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0003-adb-define-shell-command.patch deleted +0 -29
deleted file mode 100644
index cf1d9cbc3..000000000
@@ -1,29 +0,0 @@
-From 4421c2e19946dcd651fd8ac022b96627fc526149 Mon Sep 17 00:00:00 2001
-From: Fathi Boudra <[email protected]>
-Date: Wed, 7 Sep 2016 12:58:47 +0300
-Subject: [PATCH] adb: define shell command
-
-we intend to run on Linux system so the shell is always /bin/sh,
-for the host or the target.
-
-Upstream-Status: Inappropriate
----
- adb/services.c | 4 ----
- 1 file changed, 4 deletions(-)
-
-diff --git a/adb/services.c b/adb/services.c
-index 21b08dc201..d44b0c5068 100644
---- a/adb/services.c
-+++ b/adb/services.c
-@@ -299,11 +299,7 @@ static int create_subproc_raw(const char *cmd, const char *arg0, const char *arg
- }
- #endif  /* !ABD_HOST */
-
--#if ADB_HOST
- #define SHELL_COMMAND "/bin/sh"
--#else
--#define SHELL_COMMAND "/system/bin/sh"
--#endif
-
- #if !ADB_HOST
- static void subproc_waiter_service(int fd, void *cookie)
meta-oe/recipes-devtools/android-tools/android-tools/core/0004-adb-Fix-build-on-big-endian-systems.patch deleted +0 -45

45 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0005-adb-add-base64-implementation.patch deleted +0 -348

348 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0006-adb-Musl-fixes.patch deleted +0 -131

131 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0007-adb-usb_linux.c-fix-build-with-glibc-2.28.patch deleted +0 -24
deleted file mode 100644
index e02a95687..000000000
@@ -1,24 +0,0 @@
-From de393bba41c8feff932c77d6c30233945f380d42 Mon Sep 17 00:00:00 2001
-From: Martin Jansa <[email protected]>
-Date: Sat, 11 Aug 2018 13:23:37 +0000
-Subject: [PATCH] adb: usb_linux.c: fix build with glibc-2.28
-
-* include sysmacros for major, minor
-
-Signed-off-by: Martin Jansa <[email protected]>
----
- adb/usb_linux.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/adb/usb_linux.c b/adb/usb_linux.c
-index f16bdd0361..c8a7732441 100644
---- a/adb/usb_linux.c
-+++ b/adb/usb_linux.c
-@@ -22,6 +22,7 @@
- #include <sys/ioctl.h>
- #include <sys/types.h>
- #include <sys/time.h>
-+#include <sys/sysmacros.h>
- #include <dirent.h>
- #include <fcntl.h>
- #include <errno.h>
meta-oe/recipes-devtools/android-tools/android-tools/core/0008-adb-Allow-adbd-to-be-ran-as-root.patch deleted +0 -21
deleted file mode 100644
index 7d223e05f..000000000
@@ -1,21 +0,0 @@
-From 3a788e9168c9b9eac66c4fa479413f4a95c61be4 Mon Sep 17 00:00:00 2001
-From: Florent Revest <[email protected]>
-Date: Mon, 30 Oct 2017 21:05:46 +0100
-Subject: [PATCH] adb: Allow adbd to be ran as root
-
----
- adb/adb.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/adb/adb.c b/adb/adb.c
-index 027edd9359..e0f7ecde45 100644
---- a/adb/adb.c
-+++ b/adb/adb.c
-@@ -1271,6 +1271,7 @@ static int should_drop_privileges() {
-     int secure = 0;
-     char value[PROPERTY_VALUE_MAX];
-
-+    return 0;
-    /* run adbd in secure mode if ro.secure is set and
-     ** we are not in the emulator
-     */
meta-oe/recipes-devtools/android-tools/android-tools/core/0009-mkbootimg-Add-dt-parameter-to-specify-DT-image.patch deleted +0 -110

110 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0010-Use-linux-capability.h-on-linux-systems-too.patch deleted +0 -23
deleted file mode 100644
index 2c607ff67..000000000
@@ -1,23 +0,0 @@
-From ef743c9c3c7452ae904a5c343ee2b759ab3a87cb Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <[email protected]>
-Date: Wed, 7 Sep 2016 12:58:47 +0300
-Subject: [PATCH] Use linux/capability.h on linux systems too
-
-Upstream-Status: Inappropriate
----
- include/private/android_filesystem_config.h | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/include/private/android_filesystem_config.h b/include/private/android_filesystem_config.h
-index 2f528b95c8..3e0b00928e 100644
---- a/include/private/android_filesystem_config.h
-+++ b/include/private/android_filesystem_config.h
-@@ -27,7 +27,7 @@
- #include <sys/types.h>
- #include <stdint.h>
-
--#ifdef HAVE_ANDROID_OS
-+#if defined(HAVE_ANDROID_OS) || defined(__linux__)
- #include <linux/capability.h>
- #else
- #include "android_filesystem_capability.h"
meta-oe/recipes-devtools/android-tools/android-tools/core/0011-Remove-bionic-specific-calls.patch deleted +0 -64

64 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0012-Fix-implicit-declaration-of-stlcat-strlcopy-function.patch deleted +0 -50

50 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/0013-adb-Support-riscv64.patch deleted +0 -189

189 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/core/adb_libssl_11.diff deleted +0 -39
deleted file mode 100644
index 3ead649b1..000000000
@@ -1,39 +0,0 @@
-Description: adb: Make compatible with openssl 1.1
- OpenSSL version 1.1 brought some API changes which broke the build here,
- fix that by accessing rsa->n (and e) directly, using RSA_get0_key instead.
-Author: Chirayu Desai <[email protected]
-Last-Update: 2016-11-10
----
-This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
----
- system/core/adb/adb_auth_host.c |    5 +++--
- 1 file changed, 3 insertions(+), 2 deletions(-)
-
---- a/adb/adb_auth_host.c
-+++ b/adb/adb_auth_host.c
-@@ -75,6 +75,7 @@ static int RSA_to_RSAPublicKey(RSA *rsa,
-     BIGNUM* rem = BN_new();
-     BIGNUM* n = BN_new();
-     BIGNUM* n0inv = BN_new();
-+    BIGNUM* e = BN_new();
-
-     if (RSA_size(rsa) != RSANUMBYTES) {
-         ret = 0;
-@@ -82,7 +83,7 @@ static int RSA_to_RSAPublicKey(RSA *rsa,
-     }
-
-     BN_set_bit(r32, 32);
--    BN_copy(n, rsa->n);
-+    RSA_get0_key(rsa, &n, &e, NULL);
-     BN_set_bit(r, RSANUMWORDS * 32);
-     BN_mod_sqr(rr, r, n, ctx);
-     BN_div(NULL, rem, n, r32, ctx);
-@@ -96,7 +97,7 @@ static int RSA_to_RSAPublicKey(RSA *rsa,
-         BN_div(n, rem, n, r32, ctx);
-         pkey->n[i] = BN_get_word(rem);
-     }
--    pkey->exponent = BN_get_word(rsa->e);
-+    pkey->exponent = BN_get_word(e);
-
- out:
-     BN_free(n0inv);
meta-oe/recipes-devtools/android-tools/android-tools/ext4_utils.mk deleted +0 -103

103 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/extras/0001-ext4_utils-remove-selinux-extensions.patch deleted +0 -39
deleted file mode 100644
index 4a19a5d65..000000000
@@ -1,39 +0,0 @@
-From 354604da9d152f1931e91991d3f34197fc8fc759 Mon Sep 17 00:00:00 2001
-From: Sergio Schvezov <[email protected]>
-Date: Tue, 2 Oct 2018 16:36:54 +0000
-Subject: [PATCH] ext4_utils: remove selinux extensions
-
-* drop useless includes of Android SELINUX extensions
-* avoids having to clone another module
-* this should be sent upstream
-
-Upstream-Status: Inappropriate
----
- ext4_utils/make_ext4fs.c      | 1 -
- ext4_utils/make_ext4fs_main.c | 1 -
- 2 files changed, 2 deletions(-)
-
-diff --git a/ext4_utils/make_ext4fs.c b/ext4_utils/make_ext4fs.c
-index 2f89ae8a0..732afbed7 100644
---- a/ext4_utils/make_ext4fs.c
-+++ b/ext4_utils/make_ext4fs.c
-@@ -62,7 +62,6 @@
-
- #include <selinux/selinux.h>
- #include <selinux/label.h>
--#include <selinux/android.h>
-
- #define O_BINARY 0
-
-diff --git a/ext4_utils/make_ext4fs_main.c b/ext4_utils/make_ext4fs_main.c
-index a6c5f6160..f8e7b9da9 100644
---- a/ext4_utils/make_ext4fs_main.c
-+++ b/ext4_utils/make_ext4fs_main.c
-@@ -32,7 +32,6 @@
- #ifndef USE_MINGW
- #include <selinux/selinux.h>
- #include <selinux/label.h>
--#include <selinux/android.h>
- #else
- struct selabel_handle;
- #endif
meta-oe/recipes-devtools/android-tools/android-tools/extras/0002-ext4_utils-add-o-argument-to-preserve-ownership.patch deleted +0 -78

78 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/fastboot.mk deleted +0 -89

89 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/fastboot_compile_remove_gtest.patch new file +51 -0

51 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/fastboot_mk_change_out_dir.patch new file +52 -0

52 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/gitignore deleted +0 -59

59 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/img2simg_change_out_dir.patch new file +41 -0

41 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libadb_mk_change_out_dir.patch new file +44 -0

44 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libbacktrace_mk_change_out_dir.patch new file +60 -0

60 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libbase_mk_change_out_dir.patch new file +33 -0
new file mode 100644
index 000000000..37c93d6d0
@@ -0,0 +1,33 @@
+libbase.mk: modifications to make it build in yocto environment
+
+Adding an include file that is setting the common flags.
+Changed the cppflag to include the headers from other components
+of android-tools
+
+Modified LDflags so that the libraries that are coming from other android-tools
+are searched in the output folder.
+
+Modified the build rule so that it outputs the binary to the OUT_DIR
+
+Signed-off-by: Nisha Parrakat <[email protected]>
+
+--- git/system/core/debian/libbase.mk  2021-04-29 22:01:13.664181133 +0200
++++ git/system/core/debian/libbase.mk  2021-04-29 22:04:52.328123833 +0200
+@@ -1,3 +1,4 @@
++include ../../rules_yocto.mk
+ NAME = libbase
+ SOURCES = \
+           chrono_utils.cpp \
+@@ -20,8 +21,9 @@
+ LDFLAGS += -shared -Wl,-soname,$(NAME).so.0
+
+ build: $(SOURCES)
+-      $(CXX) $^ -o $(NAME).so.0 $(CXXFLAGS) $(CPPFLAGS) $(LDFLAGS)
+-      ln -s $(NAME).so.0 $(NAME).so
++      $(CXX) $^ -o $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so.0 $(CXXFLAGS) $(CPPFLAGS) $(LDFLAGS)
++      ln -s $(NAME).so.0 $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so
++      cp -r base/include/* $(OUT_DIR)/usr/include/
+
+ clean:
+-      $(RM) $(NAME).so*
++      $(RM) $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so*
meta-oe/recipes-devtools/android-tools/android-tools/libcrypto_mk_change_out_dir.patch new file +30 -0
new file mode 100644
index 000000000..f70590977
@@ -0,0 +1,30 @@
+libcrypto.mk: modifications to make it build in yocto environment
+
+Adding an include file that is setting the common flags.
+
+Modified the build rule so that it outputs the binary and include
+to the OUT_DIR
+
+
+Signed-off-by: Nisha Parrakat <[email protected]>
+
+--- git/external/boringssl/debian/libcrypto.mk 2021-04-30 11:32:40.610312307 +0000
++++ git/external/boringssl/debian/libcrypto.mk 2021-04-30 11:36:47.738318880 +0000
+@@ -1,3 +1,4 @@
++include ../../rules_yocto.mk
+ include sources.mk
+
+ NAME = libcrypto
+@@ -26,6 +27,8 @@
+ LDFLAGS += -shared -Wl,-soname,$(NAME).so.0 -lpthread
+
+ build: $(SOURCES)
+-      mkdir --parents debian/out
+-      $(CC) $^ -o debian/out/$(NAME).so.0 $(CFLAGS) $(CPPFLAGS) $(LDFLAGS)
+-      ln -s $(NAME).so.0 debian/out/$(NAME).so
+\ No newline at end of file
++      mkdir --parents $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/
++      mkdir --parents $(OUT_DIR)/usr/include
++      $(CC) $^ -o $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so.0 $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) -DOPENSSL_NO_ASM
++      ln -s $(NAME).so.0 $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so
++      cp -r include/openssl $(OUT_DIR)/usr/include
meta-oe/recipes-devtools/android-tools/android-tools/libcrypto_utils_mk_change_out_dir.patch new file +38 -0
new file mode 100644
index 000000000..a0dd34876
@@ -0,0 +1,38 @@
+libcrypto_utils.mk: modifications to make it build in yocto environment
+
+Adding an include file that is setting the common flags.
+Changed the cppflag to include the headers from other components
+of android-tools
+
+Modified LDflags so that the libraries that are coming from other android-tools
+are searched in the output folder.
+
+Modified the build rule so that it outputs the binary and header to the OUT_DIR
+
+Signed-off-by: Nisha Parrakat <[email protected]>
+
+--- git/system/core/debian/libcrypto_utils.mk  2021-04-30 14:18:54.071379767 +0200
++++ git/system/core/debian/libcrypto_utils.mk  2021-04-30 14:22:46.179047308 +0200
+@@ -1,15 +1,17 @@
++include ../../rules_yocto.mk
+ NAME:= libcrypto_utils
+ SOURCES := android_pubkey.c
+ SOURCES := $(foreach source, $(SOURCES), libcrypto_utils/$(source))
+-CPPFLAGS += -Ilibcrypto_utils/include -Iinclude
++CPPFLAGS += -Ilibcrypto_utils/include -Iinclude -I$(OUT_DIR)/usr/include
+ LDFLAGS += -shared -Wl,-soname,$(NAME).so.0 \
+       -Wl,-rpath=/usr/lib/$(DEB_HOST_MULTIARCH)/android \
+-      -L/usr/lib/$(DEB_HOST_MULTIARCH)/android \
++      -L$(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android \
+       -lcrypto -Wl,-z,defs
+
+ build: $(SOURCES)
+-      $(CC) $^ -o $(NAME).so.0  $(CPPFLAGS) $(LDFLAGS)
+-      ln -s $(NAME).so.0 $(NAME).so
++      $(CC) $^ -o $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so.0  $(CPPFLAGS) $(LDFLAGS)
++      ln -s $(NAME).so.0 $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so
++      cp -r libcrypto_utils/include/* $(OUT_DIR)/usr/include/
+
+ clean:
+-      $(RM) $(NAME).so*
++      $(RM) $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so*
meta-oe/recipes-devtools/android-tools/android-tools/libcutils_mk_change_out_dir.patch new file +27 -0
new file mode 100644
index 000000000..5539eb91d
@@ -0,0 +1,27 @@
+--- git/system/core/debian/libcutils.mk        2021-05-17 06:38:40.105161629 +0000
++++ git/system/core/debian/libcutils.mk        2021-05-17 06:42:37.141912366 +0000
+@@ -1,3 +1,4 @@
++include ../../rules_yocto.mk
+ NAME = libcutils
+
+ # copied from libcutils/Android.bp
+@@ -50,14 +51,15 @@
+             -Iinclude \
+
+ LDFLAGS += -shared -Wl,-soname,$(NAME).so.0 \
+-           -Wl,-rpath=/usr/lib/$(DEB_HOST_MULTIARCH)/android -lpthread -L. -llog -lbase
++           -Wl,-rpath=/usr/lib/$(DEB_HOST_MULTIARCH)/android -lpthread -L$(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/ -llog -lbase
+
+ build: $(COBJECTS) $(CXXOBJECTS)
+-      $(CXX) $^ -o $(NAME).so.0 $(LDFLAGS)
+-      ln -s $(NAME).so.0 $(NAME).so
++      $(CXX) $^ -o $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so.0 $(LDFLAGS)
++      ln -s $(NAME).so.0 $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so
++      cp -r libcutils/include/cutils $(OUT_DIR)/usr/include/
+
+ clean:
+-      $(RM) $(CXXOBJECTS) $(COBJECTS) $(NAME).so*
++      $(RM) $(CXXOBJECTS) $(COBJECTS) $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so*
+
+ $(COBJECTS): %.o: %.c
+       $(CC) $< -o $@ $(CFLAGS) $(CPPFLAGS)
meta-oe/recipes-devtools/android-tools/android-tools/libext4_utils_mk_change_out_dir.patch new file +42 -0

42 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libfec_mk_change_out_dir.patch new file +35 -0
new file mode 100644
index 000000000..0f8184d41
@@ -0,0 +1,35 @@
+--- git/system/extras/debian/libfec.mk 2021-05-17 06:55:51.973044031 +0000
++++ git/system/extras/debian/libfec.mk 2021-05-17 06:56:41.940185413 +0000
+@@ -1,3 +1,4 @@
++include ../../rules_yocto.mk
+ NAME = libfec
+
+ # copied from libfec/Android.bp
+@@ -12,20 +13,21 @@
+ CXXFLAGS += -fno-strict-aliasing -std=g++17
+ CPPFLAGS += \
+             -Iext4_utils/include \
+-            -Ilibfec/include \
++            -Ilibfec/include -I $(OUT_DIR)/usr/include \
+             -D_GNU_SOURCE -DFEC_NO_KLOG -D_LARGEFILE64_SOURCE
+ LDFLAGS += -shared -Wl,-soname,$(NAME).so.0 \
+            -Wl,-rpath=/usr/lib/$(DEB_HOST_MULTIARCH)/android \
+-           -L/usr/lib/$(DEB_HOST_MULTIARCH)/android \
++           -L$(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android \
+            -lbase -lsparse -lselinux
+
+ build: $(COBJECTS) $(CXXOBJECTS)
+-      mkdir -p $(OUT_DIR)
+-      $(CXX) $^ -o $(OUT_DIR)/$(NAME).so.0 $(LDFLAGS)
+-      ln -s $(NAME).so.0 $(OUT_DIR)/$(NAME).so
++      mkdir -p $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android
++      $(CXX) $^ -o $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so.0 $(LDFLAGS)
++      ln -s $(NAME).so.0 $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so
++      cp -r libfec/include/* $(OUT_DIR)/usr/include/
+
+ clean:
+-      $(RM) $(CXXOBJECTS) $(COBJECTS) $(NAME).so*
++      $(RM) $(CXXOBJECTS) $(COBJECTS) $(OUT_DIR)/usr/lib/$(DEB_HOST_MULTIARCH)/android/$(NAME).so*
+
+ $(COBJECTS): %.o: %.c
+       $(CC) $< -o $@ $(CFLAGS) $(CPPFLAGS)
meta-oe/recipes-devtools/android-tools/android-tools/liblog_mk_change_out_dir.patch new file +42 -0

42 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libselinux/0001-Remove-bionic-specific-calls.patch deleted +0 -25
deleted file mode 100644
index 9de2593df..000000000
@@ -1,25 +0,0 @@
-From 36654a4484117e5f4d63a810c0d94bc9c7ee3a83 Mon Sep 17 00:00:00 2001
-From: Fathi Boudra <[email protected]>
-Date: Tue, 2 Oct 2018 16:36:54 +0000
-Subject: [PATCH] Remove bionic specific calls
-
-Upstream-Status: Inappropriate
-
-Signed-off-by: Martin Jansa <[email protected]>
----
- src/procattr.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/procattr.c b/src/procattr.c
-index f350808..761cf8e 100644
---- a/src/procattr.c
-+++ b/src/procattr.c
-@@ -8,7 +8,7 @@
- #include "selinux_internal.h"
- #include "policy.h"
-
--#ifdef HOST
-+#ifndef __BIONIC__
- static pid_t gettid(void)
- {
-       return syscall(__NR_gettid);
meta-oe/recipes-devtools/android-tools/android-tools/libselinux/0001-libselinux-Do-not-define-gettid-if-glibc-2.30-is-use.patch deleted +0 -49

49 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libsparse_mk_change_out_dir.patch new file +47 -0

47 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libunwind_mk_change_out_dir.patch new file +47 -0

47 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/libziparchive_mk_change_out_dir.patch new file +47 -0

47 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/mkbootimg.mk deleted +0 -29
deleted file mode 100644
index 519f609fd..000000000
@@ -1,29 +0,0 @@
-# Makefile for mkbootimg
-
-SRCDIR ?= $(S)
-
-VPATH += $(SRCDIR)/system/core/mkbootimg
-mkbootimg_SRC_FILES += mkbootimg.c
-mkbootimg_OBJS := $(mkbootimg_SRC_FILES:.c=.o)
-
-VPATH += $(SRCDIR)/system/core/libmincrypt
-libmincrypt_SRC_FILES := dsa_sig.c p256.c p256_ec.c p256_ecdsa.c rsa.c sha.c sha256.c
-libmincrypt_OBJS := $(libmincrypt_SRC_FILES:.c=.o)
-
-CFLAGS += -DANDROID
-CFLAGS += -I$(SRCDIR)/system/core/mkbootimg
-CFLAGS += -I$(SRCDIR)/system/core/include
-CFLAGS += -include $(SRCDIR)/build/core/combo/include/arch/$(android_arch)/AndroidConfig.h
-
-LIBS += libmincrypt.a
-
-all: mkbootimg
-
-mkbootimg: libmincrypt.a $(mkbootimg_OBJS)
-       $(CC) -o $@ $(LDFLAGS) $(mkbootimg_OBJS) $(LIBS)
-
-libmincrypt.a: $(libmincrypt_OBJS)
-       $(AR) rcs $@ $(libmincrypt_OBJS)
-
-clean:
-       $(RM) $(mkbootimg_OBJS) $(libmincrypt_OBJS) mkbootimg *.a
meta-oe/recipes-devtools/android-tools/android-tools/rules_yocto.mk new file +4 -0
new file mode 100644
index 000000000..5e217f47f
@@ -0,0 +1,4 @@
+CPPFLAGS += -fPIC
+ifndef OUT_DIR
+OUT_DIR = ../../debian/out
+endif
meta-oe/recipes-devtools/android-tools/android-tools/simg2img_change_out_dir.patch new file +41 -0

41 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools/use_name_space_std_to_compile_libbacktrace.patch new file +19 -0
new file mode 100644
index 000000000..079ade46b
@@ -0,0 +1,19 @@
+To Fix the below error
+
+ In file included from libunwindstack/DwarfSection.cpp:21:
+| libunwindstack/include/unwindstack/DwarfMemory.h:32:29: error: unknown type name 'size_t'; did you mean 'std::size_t'?
+|   bool ReadBytes(void* dst, size_t num_bytes);
+|                             ^~~~~~
+|                             std::size_t
+
+--- ./system/core/libunwindstack/include/unwindstack/DwarfMemory.h     2021-05-22 00:52:15.132452862 +0000
++++ ./system/core/libunwindstack/include/unwindstack/DwarfMemory.h     2021-05-22 00:53:09.793416724 +0000
+@@ -23,7 +23,7 @@
+
+ // Forward declarations.
+ class Memory;
+-
++using namespace std;
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

meta-oe/recipes-devtools/android-tools/android-tools_10.0.0.r36.bb new file +204 -0

204 lines not on this page · raw message

meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb deleted +0 -182

182 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
2.17.1

This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.

Part of the diff is not shown here. View the raw message.