Skip to contentSkip to conversation

dt-bindings: i2c: Move i2c-omap.txt to YAML format

PATCH Applied Vignesh Raghavendra 3 participants 3 messages May 26, 2021 – Jun 4, 2021

Subsystems (3)
lore
Share & tools
lore

Vignesh Raghavendra

author maintainer
#0 lore raw

PATCH v3 1/1 dt-bindings: i2c: Move i2c-omap.txt to YAML format

Convert i2c-omap.txt to YAML schema for better checks and documentation.

Following properties were used in DT but were not documented in txt bindings and has been included in YAML schema:
1. Include ti,am4372-i2c compatible
2. Document clocks property

---

Note that am335x-myirtech*.dtsi needs fixing to drop scl/sda-gpios which are not supported by i2c-omap driver.
omap2/3 dmas property is being dropped by:
https://lore.kernel.org/[email protected]

v3:
Add conditions around ti,hwmods usage
drop dmas property as it was never used/supported
set additionalProperties: False
Address Rob H comments

v2:
Fix issues with make dt_bindings_check
Add description on usage of ti,hwmods

v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

 .../devicetree/bindings/i2c/i2c-omap.txt      |  37 -------
 .../devicetree/bindings/i2c/ti,omap4-i2c.yaml | 102 ++++++++++++++++++
 MAINTAINERS                                   |   2 +-
 3 files changed, 103 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-omap.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml
Documentation/devicetree/bindings/i2c/i2c-omap.txt deleted +0 -37
deleted file mode 100644
index a425b91af48f..000000000000
@@ -1,37 +0,0 @@
-I2C for OMAP platforms
-
-Required properties :
-- compatible : Must be
-	"ti,omap2420-i2c" for OMAP2420 SoCs
-	"ti,omap2430-i2c" for OMAP2430 SoCs
-	"ti,omap3-i2c" for OMAP3 SoCs
-	"ti,omap4-i2c" for OMAP4+ SoCs
-	"ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
-	"ti,j721e-i2c", "ti,omap4-i2c" for J721E SoCs
-	"ti,am64-i2c", "ti,omap4-i2c" for AM64 SoCs
-- ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
-- #address-cells = <1>;
-- #size-cells = <0>;
-
-Recommended properties :
-- clock-frequency : Desired I2C bus clock frequency in Hz. Otherwise
-  the default 100 kHz frequency will be used.
-
-Optional properties:
-- Child nodes conforming to i2c bus binding
-
-Note: Current implementation will fetch base address, irq and dma
-from omap hwmod data base during device registration.
-Future plan is to migrate hwmod data base contents into device tree
-blob so that, all the required data will be used from device tree dts
-file.
-
-Examples :
-
-i2c1: i2c@0 {
-    compatible = "ti,omap3-i2c";
-    #address-cells = <1>;
-    #size-cells = <0>;
-    ti,hwmods = "i2c1";
-    clock-frequency = <400000>;
-};
Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml new file +102 -0

102 lines not on this page · raw message

MAINTAINERS +1 -1
index 710203d794d7..33625bb83b21 100644
@@ -13424,7 +13424,7 @@ M:	Vignesh R <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Maintained
-F:	Documentation/devicetree/bindings/i2c/i2c-omap.txt
+F:	Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml
 F:	drivers/i2c/busses/i2c-omap.c
 
 OMAP IMAGING SUBSYSTEM (OMAP3 ISP and OMAP4 ISS)
Signature · 1 line
2.31.1
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 28 lines · Vignesh Raghavendra

Convert i2c-omap.txt to YAML schema for better checks and documentation.

Following properties were used in DT but were not documented in txt bindings and has been included in YAML schema:
1. Include ti,am4372-i2c compatible
2. Document clocks property

---

Note that am335x-myirtech*.dtsi needs fixing to drop scl/sda-gpios which are not supported by i2c-omap driver.
omap2/3 dmas property is being dropped by:
https://lore.kernel.org/[email protected]

v3:
Add conditions around ti,hwmods usage
drop dmas property as it was never used/supported
set additionalProperties: False
Address Rob H comments

v2:
Fix issues with make dt_bindings_check
Add description on usage of ti,hwmods

v2: https://lore.kernel.org/r/[email protected]
v1: https://lore.kernel.org/r/[email protected]

Quoted 7 lines
 .../devicetree/bindings/i2c/i2c-omap.txt      |  37 -------
 .../devicetree/bindings/i2c/ti,omap4-i2c.yaml | 102 ++++++++++++++++++
 MAINTAINERS                                   |   2 +-
 3 files changed, 103 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-omap.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/ti,omap4-i2c.yaml