Skip to contentSkip to conversation

arm64: dts: ipq8074: disable USB phy by default

PATCH In review Robert Marko 2 participants 2 messages May 26, 2021 – May 31, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: ipq8074: disable USB phy by default

One of the QUSB USB PHY-s has been left enabled by default, this is probably just a mistake as other USB PHY-s are disabled by default.

It makes no sense to have it enabled by default as not all board implement USB ports, so disable it.

---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index 555a107959831..20059d0f7d714 100644
@@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
 			clock-names = "cfg_ahb", "ref";
 
 			resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
+			status = "disabled";
 		};
 
 		qmp_pcie_phy0: phy@84000 {
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Robert Marko

One of the QUSB USB PHY-s has been left enabled by default, this is probably just a mistake as other USB PHY-s are disabled by default.

It makes no sense to have it enabled by default as not all board implement USB ports, so disable it.

Always, it is better to disable in SOC DTS and enable only in the board DTS files.

Quoted 17 lines
---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/ipq8074.dtsi +1 -0
index 555a107959831..20059d0f7d714 100644
@@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
 			clock-names = "cfg_ahb", "ref";
 
 			resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
+			status = "disabled";
 		};
 
 		qmp_pcie_phy0: phy@84000 {
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation