USB: gr_udc: remove dentry storage for debugfs file

PATCH New Greg Kroah-Hartman 1 participant 1 message May 27, 2021 USB

Share & tools

Greg Kroah-Hartman

author maintainer

2021-05-27 10:14 UTC #0 lore raw

PATCH 1/1 USB: gr_udc: remove dentry storage for debugfs file

There is no need to store the dentry pointer for a debugfs file that we only use to remove it when the device goes away. debugfs can do the lookup for us instead, saving us some trouble, and making things smaller overall.

Cc Felipe Balbi <[email protected]>

Signed-off-by Greg Kroah-Hartman <[email protected]>

---
 drivers/usb/gadget/udc/gr_udc.c | 7 ++++---
 drivers/usb/gadget/udc/gr_udc.h | 2 --
 2 files changed, 4 insertions(+), 5 deletions(-)

drivers/usb/gadget/udc/gr_udc.c +4 -3

index f8f3aa52383b..4b35739d3695 100644
@@ -207,14 +207,15 @@ DEFINE_SHOW_ATTRIBUTE(gr_dfs);
 static void gr_dfs_create(struct gr_udc *dev)
 {
 	const char *name = "gr_udc_state";
+	struct dentry *root;
 
-	dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root);
-	debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops);
+	root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root);
+	debugfs_create_file(name, 0444, root, dev, &gr_dfs_fops);
 }
 
 static void gr_dfs_delete(struct gr_udc *dev)
 {
-	debugfs_remove_recursive(dev->dfs_root);
+	debugfs_remove(debugfs_lookup(dev_name(dev->dev), usb_debug_root));
 }
 
 #else /* !CONFIG_USB_GADGET_DEBUG_FS */

drivers/usb/gadget/udc/gr_udc.h +0 -2

index ac5b3f65adb5..70134239179e 100644
@@ -215,8 +215,6 @@ struct gr_udc {
 	struct list_head ep_list;
 
 	spinlock_t lock; /* General lock, a.k.a. "dev->lock" in comments */
-
-	struct dentry *dfs_root;
 };
 
 #define to_gr_udc(gadget)	(container_of((gadget), struct gr_udc, gadget))

Signature · 1 line

2.31.1