Skip to contentSkip to conversation

of: property: Add fw_devlink support for pwms

PATCH In review Orson Zhai 2 participants 3 messages May 27, 2021 – May 28, 2021 Device tree

lore
Share & tools
lore

Orson Zhai

author
#0 lore raw

PATCH 1/1 of: property: Add fw_devlink support for pwms

From: Orson Zhai <[email protected]>

pwms is often required by backlight in embedded devices. Add device link support for pwms as well.

---
 drivers/of/property.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/of/property.c +2 -0
index 6c02863..93be977 100644
@@ -1287,6 +1287,7 @@ DEFINE_SIMPLE_PROP(pinctrl6, "pinctrl-6", NULL)
 DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL)
 DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL)
 DEFINE_SIMPLE_PROP(remote_endpoint, "remote-endpoint", NULL)
+DEFINE_SIMPLE_PROP(pwms, "pwms", NULL)
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 
@@ -1371,6 +1372,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
 	{ .parse_prop = parse_pinctrl7, },
 	{ .parse_prop = parse_pinctrl8, },
 	{ .parse_prop = parse_remote_endpoint, .node_not_dev = true, },
+	{ .parse_prop = parse_pwms, },
 	{ .parse_prop = parse_gpio_compat, },
 	{ .parse_prop = parse_interrupts, },
 	{ .parse_prop = parse_regulators, },
Signature · 1 line
2.7.4
#1 lore raw
Quoted 24 lines · Orson Zhai

From: Orson Zhai <[email protected]>

pwms is often required by backlight in embedded devices. Add device link support for pwms as well.

---
 drivers/of/property.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/of/property.c +1 -0
index 6c02863..93be977 100644
@@ -1287,6 +1287,7 @@ DEFINE_SIMPLE_PROP(pinctrl6, "pinctrl-6", NULL)
 DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL)
 DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL)
 DEFINE_SIMPLE_PROP(remote_endpoint, "remote-endpoint", NULL)
+DEFINE_SIMPLE_PROP(pwms, "pwms", NULL)
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 

drivers/of/property.c static const struct supplier_bindings of_supplier_bindings[] = { · line 1378

Quoted 7 lines
drivers/of/property.c +1 -0
@@ -1371,6 +1372,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_pinctrl7, },
        { .parse_prop = parse_pinctrl8, },
        { .parse_prop = parse_remote_endpoint, .node_not_dev = true, },
+       { .parse_prop = parse_pwms, },
        { .parse_prop = parse_gpio_compat, },
        { .parse_prop = parse_interrupts, },
        { .parse_prop = parse_regulators, },

I already have a local patch for this and "reset" bindings. But I'm holding off on adding support for new properties till fw_devlink=on fully lands in 5.13. Trying to avoid inadvertently adding new dependency issues. For example, the remote_endpoint binding I added to fix one issue caused more dependency issues. So far I've fixed them all.

So, yeah, temporary Nak for this.

-Saravana

author
#2 lore raw
Quoted 24 lines · Saravana Kannan
Quoted 23 lines · Orson Zhai

From: Orson Zhai <[email protected]>

pwms is often required by backlight in embedded devices. Add device link support for pwms as well.

---
 drivers/of/property.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/of/property.c +1 -0
index 6c02863..93be977 100644
@@ -1287,6 +1287,7 @@ DEFINE_SIMPLE_PROP(pinctrl6, "pinctrl-6", NULL)
 DEFINE_SIMPLE_PROP(pinctrl7, "pinctrl-7", NULL)
 DEFINE_SIMPLE_PROP(pinctrl8, "pinctrl-8", NULL)
 DEFINE_SIMPLE_PROP(remote_endpoint, "remote-endpoint", NULL)
+DEFINE_SIMPLE_PROP(pwms, "pwms", NULL)
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 
Quoted 15 lines

drivers/of/property.c static const struct supplier_bindings of_supplier_bindings[] = { · line 1378

Quoted 8 lines
drivers/of/property.c +1 -0
@@ -1371,6 +1372,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_pinctrl7, },
        { .parse_prop = parse_pinctrl8, },
        { .parse_prop = parse_remote_endpoint, .node_not_dev = true, },
+       { .parse_prop = parse_pwms, },
        { .parse_prop = parse_gpio_compat, },
        { .parse_prop = parse_interrupts, },
        { .parse_prop = parse_regulators, },

I already have a local patch for this and "reset" bindings. But I'm holding off on adding support for new properties till fw_devlink=on fully lands in 5.13. Trying to avoid inadvertently adding new dependency issues. For example, the remote_endpoint binding I added to fix one issue caused more dependency issues. So far I've fixed them all.

Got it. Good to know your plan.

Quoted 2 lines

So, yeah, temporary Nak for this.

No problem.

-Orson

Quoted 2 lines

-Saravana