Skip to contentSkip to conversation

char: xillybus: Fix condition for invoking the xillybus/ subdirectory

PATCH New [email protected] 1 participant 2 messages May 28, 2021

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/2 char: xillybus: Fix condition for invoking the xillybus/ subdirectory

From: Eli Billauer <[email protected]>

As Xillybus' configuration symbol hierarchy has been reorganized recently, the correct condition for compiling the xillybus/ subdirectory is now CONFIG_XILLYBUS_CLASS, and not CONFIG_XILLYBUS.

---
 drivers/char/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/Makefile +1 -1
index ffce287ef415..c7e4fc733a37 100644
@@ -44,6 +44,6 @@ obj-$(CONFIG_TCG_TPM)		+= tpm/
 
 obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
 
-obj-$(CONFIG_XILLYBUS)		+= xillybus/
+obj-$(CONFIG_XILLYBUS_CLASS)	+= xillybus/
 obj-$(CONFIG_POWERNV_OP_PANEL)	+= powernv-op-panel.o
 obj-$(CONFIG_ADI)		+= adi.o
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/2 char: xillybus: Remove unneeded MODULE_VERSION() usage

From: Eli Billauer <[email protected]>

MODULE_VERSION is useless for in-kernel drivers, so these are removed from files in drivers/char/xillybus/

---
 drivers/char/xillybus/xillybus_class.c | 1 -
 drivers/char/xillybus/xillybus_core.c  | 1 -
 drivers/char/xillybus/xillybus_of.c    | 1 -
 drivers/char/xillybus/xillybus_pcie.c  | 1 -
 drivers/char/xillybus/xillyusb.c       | 1 -
 5 files changed, 5 deletions(-)
drivers/char/xillybus/xillybus_class.c +0 -1
index ea74da84bf19..5046486011c8 100644
@@ -18,7 +18,6 @@
 
 MODULE_DESCRIPTION("Driver for Xillybus class");
 MODULE_AUTHOR("Eli Billauer, Xillybus Ltd.");
-MODULE_VERSION("1.0");
 MODULE_ALIAS("xillybus_class");
 MODULE_LICENSE("GPL v2");
 
drivers/char/xillybus/xillybus_core.c +0 -1
index 0efc4fddaa94..931d0bf4cec6 100644
@@ -33,7 +33,6 @@
 
 MODULE_DESCRIPTION("Xillybus core functions");
 MODULE_AUTHOR("Eli Billauer, Xillybus Ltd.");
-MODULE_VERSION("1.10");
 MODULE_ALIAS("xillybus_core");
 MODULE_LICENSE("GPL v2");
 
drivers/char/xillybus/xillybus_of.c +0 -1
index 96b6de8a30e5..1a20b286fd1d 100644
@@ -17,7 +17,6 @@
 
 MODULE_DESCRIPTION("Xillybus driver for Open Firmware");
 MODULE_AUTHOR("Eli Billauer, Xillybus Ltd.");
-MODULE_VERSION("1.06");
 MODULE_ALIAS("xillybus_of");
 MODULE_LICENSE("GPL v2");
 
drivers/char/xillybus/xillybus_pcie.c +0 -1
index 18b0c392bc93..bdf1c366b4fc 100644
@@ -14,7 +14,6 @@
 
 MODULE_DESCRIPTION("Xillybus driver for PCIe");
 MODULE_AUTHOR("Eli Billauer, Xillybus Ltd.");
-MODULE_VERSION("1.06");
 MODULE_ALIAS("xillybus_pcie");
 MODULE_LICENSE("GPL v2");
 
drivers/char/xillybus/xillyusb.c +0 -1
index 1e15706af749..1210a4ef97fa 100644
@@ -33,7 +33,6 @@
 
 MODULE_DESCRIPTION("Driver for XillyUSB FPGA IP Core");
 MODULE_AUTHOR("Eli Billauer, Xillybus Ltd.");
-MODULE_VERSION("1.1");
 MODULE_ALIAS("xillyusb");
 MODULE_LICENSE("GPL v2");
 
Signature · 1 line
2.17.1