openat2: flag fixes
Subsystems (3)
Christian Brauner
maintainerv2 cover openat2: flag fixes
From: Christian Brauner <[email protected]>
Hey,
A few fixes and tests to openat2 to prevent silent truncation when passing in flags in the upper 32 bits.
With the feedback from Richard worked in I picked this up so it can sit in -next for a bit.
Thanks!
Christian
Christian Brauner (3):
fcntl: remove unused VALID_UPGRADE_FLAGS
open: don't silently ignore unknown O-flags in openat2()
test: add openat2() test for invalid upper 32 bit flag value
fs/open.c | 14 +++++++++++--- include/linux/fcntl.h | 4 ---- tools/testing/selftests/openat2/openat2_test.c | 7 ++++++- 3 files changed, 17 insertions(+), 8 deletions(-)
base-commit: c4681547bcce777daf576925a966ffa824edd09d
Signature · 1 line
2.27.0
Christian Brauner
maintainerPATCH v2 1/3 fcntl: remove unused VALID_UPGRADE_FLAGS
From: Christian Brauner <[email protected]>
We currently do not maky use of this feature and should we implement something like this in the future it's trivial to add it back.
---
/* v2 */
unchanged
--- include/linux/fcntl.h | 4 ---- 1 file changed, 4 deletions(-)
include/linux/fcntl.h +0 -4
@@ -12,10 +12,6 @@ FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \ O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE) -/* List of all valid flags for the how->upgrade_mask argument: */ -#define VALID_UPGRADE_FLAGS \ - (UPGRADE_NOWRITE | UPGRADE_NOREAD) -/* List of all valid flags for the how->resolve argument: */ #define VALID_RESOLVE_FLAGS \ (RESOLVE_NO_XDEV | RESOLVE_NO_MAGICLINKS | RESOLVE_NO_SYMLINKS | \
Signature · 1 line
2.27.0
Christian Brauner
maintainerPATCH v2 2/3 open: don't silently ignore unknown O-flags in openat2()
In reply to Christian BraunerFrom: Christian Brauner <[email protected]>
The new openat2() syscall verifies that no unknown O-flag values are set and returns an error to userspace if they are while the older open syscalls like open() and openat() simply ignore unknown flag values:
#define O_FLAG_CURRENTLY_INVALID (1 << 31)
struct open_how how = {
.flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID,
.resolve = 0,
};
/* fails */
fd = openat2(-EBADF, "/dev/null", &how, sizeof(how));
/* succeeds */
fd = openat(-EBADF, "/dev/null", O_RDONLY | O_FLAG_CURRENTLY_INVALID);However, openat2() silently truncates the upper 32 bits meaning:
#define O_FLAG_CURRENTLY_INVALID_LOWER32 (1 << 31)
#define O_FLAG_CURRENTLY_INVALID_UPPER32 (1 << 40)
struct open_how how_lowe32 = {
.flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_LOWER32,
};
struct open_how how_upper32 = {
.flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_UPPER32,
};
/* fails */
fd = openat2(-EBADF, "/dev/null", &how_lower32, sizeof(how_lower32));
/* succeeds */
fd = openat2(-EBADF, "/dev/null", &how_upper32, sizeof(how_upper32));Fix this by preventing the immediate truncation in build_open_flags().
There's a snafu here though stripping FMODE_* directly from flags would cause the upper 32 bits to be truncated as well due to integer promotion rules since FMODE_* is unsigned int, O_* are signed ints (yuck).
In addition, struct open_flags currently defines flags to be 32 bit which is reasonable. If we simply were to bump it to 64 bit we would need to change a lot of code preemptively which doesn't seem worth it. So simply add a compile-time check verifying that all currently known O_* flags are within the 32 bit range and fail to build if they aren't anymore.
This change shouldn't regress old open syscalls since they silently truncate any unknown values anyway. It is a tiny semantic change for openat2() but it is very unlikely people pass ing > 32 bit unknown flags and the syscall is relatively new too.
---
/* v2 */
- Richard Guy Briggs <[email protected]>:
- Add an explicit BUILD_BUG_ON() to check when we need to change struct open_flags to account for O_* flags > 32 bits.
--- fs/open.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
fs/open.c +11 -3
@@ -1002,12 +1002,20 @@ inline struct open_how build_open_how(int flags, umode_t mode)inline int build_open_flags (const struct open_how *how,struct open_flags *op) { -int flags = how->flags; +u64 flags = how->flags; +u64 strip =FMODE_NONOTIFY |O_CLOEXEC ;int lookup_flags =0 ;int acc_mode =ACC_MODE (flags); -/* Must never be set by userspace */ - flags &= ~(FMODE_NONOTIFY |O_CLOEXEC ); +BUILD_BUG_ON_MSG (upper_32_bits (VALID_OPEN_FLAGS ), +"struct open_flags doesn't yet handle flags > 32 bits" ); + +/* +* Strip flags that either shouldn't be set by userspace like +* FMODE_NONOTIFY or that aren't relevant in determining struct +* open_flags like O_CLOEXEC. +*/ + flags &= ~strip;/* * Older syscalls implicitly clear all of the invalid flags or argument
Signature · 1 line
2.27.0
Re: [PATCH v2 2/3] open: don't silently ignore unknown O-flags in openat2()
Quoted 55 lines · Christian Brauner
From: Christian Brauner <[email protected]>
The new
openat2()syscall verifies that no unknown O-flag values are set and returns an error to userspace if they are while the older open syscalls likeopen()andopenat()simply ignore unknown flag values:#define O_FLAG_CURRENTLY_INVALID (1 << 31) struct open_how how = { .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID, .resolve = 0, }; /* fails */ fd = openat2(-EBADF, "/dev/null", &how, sizeof(how)); /* succeeds */ fd = openat(-EBADF, "/dev/null", O_RDONLY | O_FLAG_CURRENTLY_INVALID);However,
openat2()silently truncates the upper 32 bits meaning:#define O_FLAG_CURRENTLY_INVALID_LOWER32 (1 << 31) #define O_FLAG_CURRENTLY_INVALID_UPPER32 (1 << 40) struct open_how how_lowe32 = { .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_LOWER32, }; struct open_how how_upper32 = { .flags = O_RDONLY | O_FLAG_CURRENTLY_INVALID_UPPER32, }; /* fails */ fd = openat2(-EBADF, "/dev/null", &how_lower32, sizeof(how_lower32)); /* succeeds */ fd = openat2(-EBADF, "/dev/null", &how_upper32, sizeof(how_upper32));Fix this by preventing the immediate truncation in
build_open_flags().There's a snafu here though stripping FMODE_* directly from flags would cause the upper 32 bits to be truncated as well due to integer promotion rules since FMODE_* is unsigned int, O_* are signed ints (yuck).
In addition, struct
open_flagscurrently defines flags to be 32 bit which is reasonable. If we simply were to bump it to 64 bit we would need to change a lot of code preemptively which doesn't seem worth it. So simply add a compile-time check verifying that all currently known O_* flags are within the 32 bit range and fail to build if they aren't anymore.This change shouldn't regress old open syscalls since they silently truncate any unknown values anyway. It is a tiny semantic change for
openat2()but it is very unlikely people pass ing > 32 bit unknown flags and the syscall is relatively new too.
Quoted 8 lines
Cc Christoph Hellwig <[email protected]>Cc Aleksa Sarai <[email protected]>Cc Al Viro <[email protected]>Reported-by Richard Guy Briggs <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by Aleksa Sarai <[email protected]>Signed-off-by Christian Brauner <[email protected]>
Quoted 40 lines
---
/* v2 */
- Richard Guy Briggs <[email protected]>:
- Add an explicitBUILD_BUG_ON()to check when we need to change structopen_flagsto account for O_* flags > 32 bits.--- fs/open.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)fs/open.c +11
-3@@ -1002,12 +1002,20 @@ inline struct open_how build_open_how(int flags, umode_t mode)inline int build_open_flags (const struct open_how *how,struct open_flags *op) { -int flags = how->flags; +u64 flags = how->flags; +u64 strip =FMODE_NONOTIFY |O_CLOEXEC ;int lookup_flags =0 ;int acc_mode =ACC_MODE (flags); -/* Must never be set by userspace */ - flags &= ~(FMODE_NONOTIFY |O_CLOEXEC ); +BUILD_BUG_ON_MSG (upper_32_bits (VALID_OPEN_FLAGS ), +"struct open_flags doesn't yet handle flags > 32 bits" ); + +/* +* Strip flags that either shouldn't be set by userspace like +* FMODE_NONOTIFY or that aren't relevant in determining struct +* open_flags like O_CLOEXEC. +*/ + flags &= ~strip;/* * Older syscalls implicitly clear all of the invalid flags or argument Signature · 1 line
2.27.0
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
Christian Brauner
maintainerPATCH v2 3/3 test: add openat2() test for invalid upper 32 bit flag value
In reply to Christian BraunerFrom: Christian Brauner <[email protected]>
Test that openat2() rejects unknown flags in the upper 32 bit range.
---
/* v2 */
- Richard Guy Briggs <[email protected]>:
- Rename test to clarify what it actually tests.
--- tools/testing/selftests/openat2/openat2_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
tools/testing/selftests/openat2/openat2_test.c +6 -1
@@ -155,7 +155,7 @@ struct flag_test {int err; }; -#define NUM_OPENAT2_FLAG_TESTS 24 +#define NUM_OPENAT2_FLAG_TESTS 25void test_openat2_flags (void ) {
@@ -229,6 +229,11 @@ void test_openat2_flags(void) { .name = "invalid how.resolve and O_PATH", .how.flags = O_PATH, .how.resolve = 0x1337, .err = -EINVAL }, + + /* currently unknown upper 32 bit rejected. */ + { .name = "currently unknown bit (1 << 63)", + .how.flags = O_RDONLY | (1ULL << 63), + .how.resolve = 0, .err = -EINVAL }, };BUILD_BUG_ON (ARRAY_LEN (tests) !=NUM_OPENAT2_FLAG_TESTS );
Signature · 1 line
2.27.0
Re: [PATCH v2 3/3] test: add openat2() test for invalid upper 32 bit flag value
Quoted 8 lines · Christian Brauner
From: Christian Brauner <[email protected]>
Test that
openat2()rejects unknown flags in the upper 32 bit range.Cc Richard Guy Briggs <[email protected]>Cc Aleksa Sarai <[email protected]>Signed-off-by Christian Brauner <[email protected]>
Quoted 36 lines
---
/* v2 */
- Richard Guy Briggs <[email protected]>:
- Rename test to clarify what it actually tests.--- tools/testing/selftests/openat2/openat2_test.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)tools/testing/selftests/openat2/openat2_test.c +6
-1@@ -155,7 +155,7 @@ struct flag_test {int err; }; -#define NUM_OPENAT2_FLAG_TESTS 24 +#define NUM_OPENAT2_FLAG_TESTS 25void test_openat2_flags (void ) {@@ -229,6 +229,11 @@ void test_openat2_flags(void) { .name = "invalid how.resolve and O_PATH", .how.flags = O_PATH, .how.resolve = 0x1337, .err = -EINVAL }, + + /* currently unknown upper 32 bit rejected. */ + { .name = "currently unknown bit (1 << 63)", + .how.flags = O_RDONLY | (1ULL << 63), + .how.resolve = 0, .err = -EINVAL }, };BUILD_BUG_ON (ARRAY_LEN (tests) !=NUM_OPENAT2_FLAG_TESTS );Signature · 1 line
2.27.0
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635