lpfc: Fix failure to transmit ABTS on FC link
Subsystems (3)
PATCH 1/1 lpfc: Fix failure to transmit ABTS on FC link
The abort_cmd_ia flag in an abort wqe describes whether an ABTS basic link service should be transmitted on the FC link or not. Code added in lpfc_sli4_issue_abort_iotag() set the abort_cmd_ia flag incorrectly, surpressing ABTS transmission.
A previous LPFC change to build an abort wqe inverted prior logic that determined whether an ABTS was to be issued on the FC link.
Revert this logic to its proper state.
--- drivers/scsi/lpfc/lpfc_sli.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/lpfc/lpfc_sli.c +1 -3
@@ -20615,10 +20615,8 @@ lpfc_sli4_issue_abort_iotag(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, abtswqe = &abtsiocb->wqe;memset (abtswqe,0 ,sizeof (*abtswqe)); -if (lpfc_is_link_up (phba)) +if (!lpfc_is_link_up (phba))bf_set (abort_cmd_ia, &abtswqe->abort_cmd,1 ); -else -bf_set (abort_cmd_ia, &abtswqe->abort_cmd,0 );bf_set (abort_cmd_criteria, &abtswqe->abort_cmd,T_XRI_TAG ); abtswqe->abort_cmd.rsrvd5 =0 ; abtswqe->abort_cmd.wqe_com.abort_tag = xritag;
Signature · 1 line
2.26.2
Martin K. Petersen
AppliedQuoted 9 lines · James Smart
The
abort_cmd_iaflag in an abort wqe describes whether an ABTS basic link service should be transmitted on the FC link or not. Code added inlpfc_sli4_issue_abort_iotag()set theabort_cmd_iaflag incorrectly, surpressing ABTS transmission.A previous LPFC change to build an abort wqe inverted prior logic that determined whether an ABTS was to be issued on the FC link.
[...]
Applied to 5.13/scsi-fixes, thanks!
[1/1] lpfc: Fix failure to transmit ABTS on FC link
https://git.kernel.org/mkp/scsi/c/696770e72f2b
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering