generic/042: f2fs-utils 1.14.0 needs at least 52 MB
PATCH 1/1 generic/042: f2fs-utils 1.14.0 needs at least 52 MB
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again. But at least we need to configure mininum size of f2fs image to 52MB now.
--- tests/generic/042 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tests/generic/042 +5 -2
@@ -43,9 +43,12 @@ _crashtest() file=$mnt/file size=25M - # 25M is too small for f2fs. + # f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, + # f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change + # again. But at least we need to configure mininum size of f2fs image + # to 52MB now. if [ $FSTYP == "f2fs" ]; then - size=38M + size=52M fi # Create an fs on a small, initialized image. The pattern is written to
Signature · 1 line
2.25.4
Quoted 15 lines · Sun Ke
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again. But at least we need to configure mininum size of f2fs image to 52MB now.
Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>--- tests/generic/042 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)tests/generic/042 +0
-0
tests/generic/042 _crashtest() · line 49
Quoted 8 lines
tests/generic/042 +4
-1@@ -43,9 +43,12 @@ _crashtest() file=$mnt/file size=25M - # 25M is too small for f2fs. + # f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, + # f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change + # again. But at least we need to configure mininum size of f2fs image + # to 52MB now.
It'd be better to specify a slightly bigger fs size for f2fs then. I don't think this test depends on the fs size, just that smaller size makes test run faster.
Maybe 64M or 128M, any suggestions from f2fs folks?
Thanks,
Eryu
Quoted 8 lines
tests/generic/042 +1
-1if [ $FSTYP == "f2fs" ]; then - size=38M + size=52M fi # Create an fs on a small, initialized image. The pattern is written toSignature · 1 line
2.25.4
Quoted 29 lines · Eryu Guan
Quoted 15 lines · Sun Ke
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again. But at least we need to configure mininum size of f2fs image to 52MB now.
Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>--- tests/generic/042 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)tests/generic/042 +0
-0tests/generic/042 _crashtest() · line 49
Quoted 8 lines
tests/generic/042 +4
-1@@ -43,9 +43,12 @@ _crashtest() file=$mnt/file size=25M - # 25M is too small for f2fs. + # f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, + # f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change + # again. But at least we need to configure mininum size of f2fs image + # to 52MB now.It'd be better to specify a slightly bigger fs size for f2fs then. I don't think this test depends on the fs size, just that smaller size makes test run faster.
Quoted 4 lines
Maybe 64M or 128M, any suggestions from f2fs folks?
Thanks,
Eryu
I tested both of them, they both take 5s. So, the bigger is the better, I choose 128M.
[root@localhost xfstests-dev]# git diff
tests/generic/042 +0 -0
@@ -48,7 +48,7 @@ _crashtest() # again. But at least we need to configure mininum size of f2fs
image
# to 52MB now.
if [ $FSTYP == "f2fs" ]; then
- size=52M
+ size=64M
fi # Create an fs on a small, initialized image. The pattern is
written to
[root@localhost xfstests-dev]# ./check tests/generic/042
FSTYP -- f2fs PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021 MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/042 5s ... 5s
Ran: generic/042
Passed all 1 tests
[root@localhost xfstests-dev]# git diff
tests/generic/042 +0 -0
@@ -48,7 +48,7 @@ _crashtest() # again. But at least we need to configure mininum size of f2fs
image
# to 52MB now.
if [ $FSTYP == "f2fs" ]; then
- size=52M
+ size=128M
fi # Create an fs on a small, initialized image. The pattern is
written to
[root@localhost xfstests-dev]# ./check tests/generic/042
FSTYP -- f2fs PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021 MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/042 5s ... 5s
Ran: generic/042
Passed all 1 tests
Thanks,
Sun Ke
Quoted 11 lines
Quoted 9 lines
tests/generic/042 +1
-1if [ $FSTYP == "f2fs" ]; then - size=38M + size=52M fi # Create an fs on a small, initialized image. The pattern is written toSignature · 1 line
2.25.4.