Skip to contentSkip to conversation

powerpc/spider-pci: Remove set but not used variable 'val'

PATCH Applied Baokun Li 3 participants 4 messages Jun 1, 2021 – Jun 18, 2021

Subsystems (2)
lore
Share & tools
lore

Baokun Li

author
#0 lore raw

PATCH 1/1 powerpc/spider-pci: Remove set but not used variable 'val'

Fixes gcc '-Wunused-but-set-variable' warning:

arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
variable ‘val’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

---
 arch/powerpc/platforms/cell/spider-pci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/platforms/cell/spider-pci.c +1 -2
index 93ea41680f54..a1c293f42a1f 100644
@@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
 static void spiderpci_io_flush(struct iowa_bus *bus)
 {
 	struct spiderpci_iowa_private *priv;
-	u32 val;
 
 	priv = bus->private;
-	val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
+	in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
 	iosync();
 }
 
Signature · 1 line
2.31.1
#1 lore raw

ping

Quoted 29 lines · Baokun Li

Fixes gcc '-Wunused-but-set-variable' warning:

arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
variable ‘val’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

---
  arch/powerpc/platforms/cell/spider-pci.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/platforms/cell/spider-pci.c +1 -2
index 93ea41680f54..a1c293f42a1f 100644
@@ -25,10 +25,9 @@ struct spiderpci_iowa_private {
  static void spiderpci_io_flush(struct iowa_bus *bus)
  {
  	struct spiderpci_iowa_private *priv;
-	u32 val;
 
  	priv = bus->private;
-	val = in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
+	in_be32(priv->regs + SPIDER_PCI_DUMMY_READ);
  	iosync();
  }
 
#3 lore raw
In reply to Baokun Li
Quoted 7 lines · Baokun Li

Fixes gcc '-Wunused-but-set-variable' warning:

arch/powerpc/platforms/cell/spider-pci.c: In function 'spiderpci_io_flush':
arch/powerpc/platforms/cell/spider-pci.c:28:6: warning:
variable ‘val’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Applied to powerpc/next.

[1/1] powerpc/spider-pci: Remove set but not used variable 'val'

      https://git.kernel.org/powerpc/c/f377f7da26d2af87e2ddc39190546f62ecdb2bd8

cheers