Skip to contentSkip to conversation

net/mlx5: add TCP and IPv6 to supported flow items list in Windows

PATCH Superseded Tal Shnaiderman 3 participants 7 messages Jun 1, 2021 – Jun 28, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: add TCP and IPv6 to supported flow items list in Windows

WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD.

---
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/mlx5/windows/mlx5_flow_os.h +2 -0
index 26c3e59789..df92f25ce6 100644
@@ -42,6 +42,8 @@ mlx5_flow_os_item_supported(int item)
 	case RTE_FLOW_ITEM_TYPE_ETH:
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 	case RTE_FLOW_ITEM_TYPE_UDP:
+	case RTE_FLOW_ITEM_TYPE_TCP:
+	case RTE_FLOW_ITEM_TYPE_IPV6:
 		return true;
 	default:
 		return false;
Signature · 1 line
2.16.1.windows.4
#1 lore raw

v2 cover Add types to supported flow items in Windows

---
v2: Added a docu patch.
---

Tal Shnaiderman (2):
net/mlx5: add TCP and IPv6 to supported flow items list in Windows
doc: description of new steering rules support in Windows

 doc/guides/nics/mlx5.rst                | 3 +++
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 2 files changed, 5 insertions(+)
Signature · 1 line
2.16.1.windows.4
#2 lore raw

PATCH v2 1/2 net/mlx5: add TCP and IPv6 to supported flow items list in Windows

WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD.

---
v2: Added a docu patch.
---

---
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/mlx5/windows/mlx5_flow_os.h +2 -0
index 26c3e59789..df92f25ce6 100644
@@ -42,6 +42,8 @@ mlx5_flow_os_item_supported(int item)
 	case RTE_FLOW_ITEM_TYPE_ETH:
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 	case RTE_FLOW_ITEM_TYPE_UDP:
+	case RTE_FLOW_ITEM_TYPE_TCP:
+	case RTE_FLOW_ITEM_TYPE_IPV6:
 		return true;
 	default:
 		return false;
Signature · 1 line
2.16.1.windows.4
#3 lore raw

PATCH v3 1/1 net/mlx5: add TCP and IPv6 to supported flow items list in Windows

WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD.

Added description of new rules support in Windows kernel driver WINOF2 2.70 to the mlx5 driver guide.

---
v3 merge code and docu changes to a single patch.
---

---
 doc/guides/nics/mlx5.rst                | 3 +++
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 2 files changed, 5 insertions(+)
doc/guides/nics/mlx5.rst +3 -0
index 83299646dd..eb44a070b1 100644
@@ -123,6 +123,9 @@ Limitations
 
     - IPv4/UDP with CVLAN filtering
     - Unicast MAC filtering
+  - Additional rules are supported from WinOF2 version 2.70:
+    - IPv4/TCP with CVLAN filtering
+    - L4 steering rules for port RSS of UDP, TCP and IP
 
 - For secondary process:
 
drivers/net/mlx5/windows/mlx5_flow_os.h +2 -0
index 26c3e59789..df92f25ce6 100644
@@ -42,6 +42,8 @@ mlx5_flow_os_item_supported(int item)
 	case RTE_FLOW_ITEM_TYPE_ETH:
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 	case RTE_FLOW_ITEM_TYPE_UDP:
+	case RTE_FLOW_ITEM_TYPE_TCP:
+	case RTE_FLOW_ITEM_TYPE_IPV6:
 		return true;
 	default:
 		return false;
Signature · 1 line
2.16.1.windows.4
Acked-by on v3 1/1
#4 lore raw

From: Tal Shnaiderman

Quoted 10 lines

WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD.

Added description of new rules support in Windows kernel driver WINOF2 2.70 to the mlx5 driver guide.

#5 lore raw
In reply to Tal Shnaiderman

Hi,

Quoted 9 lines

-----Original Message-----
From: Tal Shnaiderman <[email protected]>
Sent: Tuesday, June 22, 2021 6:35 PM
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon <[email protected]>; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Asaf Penso <[email protected]>; Odi Assli <[email protected]>
Subject: [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

Title too long:
Changing to :
net/mlx5: add TCP and IPv6 to supported items in Windows

Quoted 12 lines

WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported to allow them to be created in the PMD.

Added description of new rules support in Windows kernel driver WINOF2 2.70 to the mlx5 driver guide.

Quoted 7 lines

---
v3 merge code and docu changes to a single patch.
---

---
 doc/guides/nics/mlx5.rst                | 3 +++
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 2 files changed, 5 insertions(+)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

#6 lore raw

PATCH v2 2/2 doc: description of new steering rules support in Windows

In reply to Tal Shnaiderman

Added description of new rules support in Windows
kernel driver WINOF2 2.70

---
 doc/guides/nics/mlx5.rst | 3 +++
 1 file changed, 3 insertions(+)
doc/guides/nics/mlx5.rst +3 -0
index 83299646dd..eb44a070b1 100644
@@ -123,6 +123,9 @@ Limitations
 
     - IPv4/UDP with CVLAN filtering
     - Unicast MAC filtering
+  - Additional rules are supported from WinOF2 version 2.70:
+    - IPv4/TCP with CVLAN filtering
+    - L4 steering rules for port RSS of UDP, TCP and IP
 
 - For secondary process:
 
Signature · 1 line
2.16.1.windows.4