Skip to contentSkip to conversation

Add ICSSG MDIO nodes on AM65x & J721E SoCs

PATCH Applied Suman Anna 2 participants 4 messages Jun 1, 2021 – Jun 7, 2021

Subsystems (2)
lore
Share & tools
lore

Suman Anna

author
#0 lore raw

v2 cover Add ICSSG MDIO nodes on AM65x & J721E SoCs

Hi Nishanth,

he following series is a resend of the ICSSG DT nodes [1] for the 5.14 merge window. Patches are just rebased on top of 5.13-rc1 + your latest ti-k3-dts-next branch HEAD commit 69db725cdb2b ("arm64: dts: ti:
k3-am654x/j721e/j7200-common-proc-board: Fix MCU_RGMII1_TXC direction")
+ Aswath's AM65x MMCSD1 UHS-I patch [2]. There are no code changes w.r.t v1, I have picked up Reviewed-by tags from Jan and Grygorii.

regards
Suman

[1] https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
[2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/[email protected]/

Roger Quadros (1):
arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes

Suman Anna (1):
arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes

 .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 12 ++++++++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 30 +++++++++++++++++++
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++
 .../dts/ti/k3-j721e-common-proc-board.dts     |  8 +++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 20 +++++++++++++
 5 files changed, 82 insertions(+)
Signature · 1 line
2.30.1
author
#1 lore raw

PATCH v2 1/2 arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes

From: Roger Quadros <[email protected]>

The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can be used to control external PHYs associated with the Industrial Ethernet peripherals within each ICSSG instance. The MDIO module used within the ICSSG is similar to the MDIO Controller used in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the MDIO operations.

The nodes are added and enabled in the common k3-am65-main.dtsi file by default, and disabled in the existing AM65 board dts files. These nodes need pinctrl lines, and so should be enabled only on boards where they are actually wired and pinned out for ICSSG Ethernet. Any new board dts file should disable these if they are not sure.

---
 .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 12 ++++++++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 30 +++++++++++++++++++
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++
 3 files changed, 54 insertions(+)
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi +12 -0
index d90abda1de84..8c6b538c53f3 100644
@@ -702,3 +702,15 @@ &mailbox0_cluster10 {
 &mailbox0_cluster11 {
 	status = "disabled";
 };
+
+&icssg0_mdio {
+	status = "disabled";
+};
+
+&icssg1_mdio {
+	status = "disabled";
+};
+
+&icssg2_mdio {
+	status = "disabled";
+};
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +30 -0
index f97fc00c00ca..e679394d0b7e 100644
@@ -1052,6 +1052,16 @@ tx_pru0_1: txpru@c000 {
 			reg-names = "iram", "control", "debug";
 			firmware-name = "am65x-txpru0_1-fw";
 		};
+
+		icssg0_mdio: mdio@32400 {
+			compatible = "ti,davinci_mdio";
+			reg = <0x32400 0x100>;
+			clocks = <&k3_clks 62 3>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			bus_freq = <1000000>;
+		};
 	};
 
 	icssg1: icssg@b100000 {
@@ -1183,6 +1193,16 @@ tx_pru1_1: txpru@c000 {
 			reg-names = "iram", "control", "debug";
 			firmware-name = "am65x-txpru1_1-fw";
 		};
+
+		icssg1_mdio: mdio@32400 {
+			compatible = "ti,davinci_mdio";
+			reg = <0x32400 0x100>;
+			clocks = <&k3_clks 63 3>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			bus_freq = <1000000>;
+		};
 	};
 
 	icssg2: icssg@b200000 {
@@ -1314,5 +1334,15 @@ tx_pru2_1: txpru@c000 {
 			reg-names = "iram", "control", "debug";
 			firmware-name = "am65x-txpru2_1-fw";
 		};
+
+		icssg2_mdio: mdio@32400 {
+			compatible = "ti,davinci_mdio";
+			reg = <0x32400 0x100>;
+			clocks = <&k3_clks 64 3>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			bus_freq = <1000000>;
+		};
 	};
 };
arch/arm64/boot/dts/ti/k3-am654-base-board.dts +12 -0
index 60e43fd7af12..fa057a85e833 100644
@@ -539,3 +539,15 @@ &mcasp2 {
 &dss {
 	status = "disabled";
 };
+
+&icssg0_mdio {
+	status = "disabled";
+};
+
+&icssg1_mdio {
+	status = "disabled";
+};
+
+&icssg2_mdio {
+	status = "disabled";
+};
Signature · 1 line
2.30.1
author
#2 lore raw

PATCH v2 2/2 arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes

In reply to Suman Anna

The ICSSGs on K3 J721E SoCs contain an MDIO controller that can be used to control external PHYs associated with the Industrial Ethernet peripherals within each ICSSG instance. The MDIO module used within the ICSSG is similar to the MDIO Controller used in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the MDIO operations.

The nodes are added and enabled in the common k3-j721e-main.dtsi file by default, and disabled in the existing J721E board dts file. These nodes need pinctrl lines, and so should be enabled only on boards where they are actually wired and pinned out for ICSSG Ethernet. Any new board dts file should disable these if they are not sure.

---
 .../dts/ti/k3-j721e-common-proc-board.dts     |  8 ++++++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 20 +++++++++++++++++++
 2 files changed, 28 insertions(+)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +8 -0
index 351bb84db65b..1991f620d94b 100644
@@ -718,3 +718,11 @@ &pcie3_ep {
 &dss {
 	status = "disabled";
 };
+
+&icssg0_mdio {
+	status = "disabled";
+};
+
+&icssg1_mdio {
+	status = "disabled";
+};
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +20 -0
index 3bcafe4c1742..598613876b0f 100644
@@ -1794,6 +1794,16 @@ tx_pru0_1: txpru@c000 {
 			reg-names = "iram", "control", "debug";
 			firmware-name = "j7-txpru0_1-fw";
 		};
+
+		icssg0_mdio: mdio@32400 {
+			compatible = "ti,davinci_mdio";
+			reg = <0x32400 0x100>;
+			clocks = <&k3_clks 119 1>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			bus_freq = <1000000>;
+		};
 	};
 
 	icssg1: icssg@b100000 {
@@ -1925,5 +1935,15 @@ tx_pru1_1: txpru@c000 {
 			reg-names = "iram", "control", "debug";
 			firmware-name = "j7-txpru1_1-fw";
 		};
+
+		icssg1_mdio: mdio@32400 {
+			compatible = "ti,davinci_mdio";
+			reg = <0x32400 0x100>;
+			clocks = <&k3_clks 120 4>;
+			clock-names = "fck";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			bus_freq = <1000000>;
+		};
 	};
 };
Signature · 1 line
2.30.1
maintainer Applied
#3 lore raw
In reply to Suman Anna
Quoted 8 lines · Suman Anna

he following series is a resend of the ICSSG DT nodes [1] for the 5.14 merge window. Patches are just rebased on top of 5.13-rc1 + your latest ti-k3-dts-next branch HEAD commit 69db725cdb2b ("arm64: dts: ti:
k3-am654x/j721e/j7200-common-proc-board: Fix MCU_RGMII1_TXC direction")
+ Aswath's AM65x MMCSD1 UHS-I patch [2]. There are no code changes w.r.t v1, I have picked up Reviewed-by tags from Jan and Grygorii.

[...]

Hi Suman Anna,

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes

      commit: d49a769dcddd4224bd631792a4d2e5bbb160aa20
[2/2] arm64: dts: ti: k3-j721e-main: Add ICSSG MDIO nodes
      commit: 7ce11d4704c080ab890831b8255fbba4d2b0c5ec

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D