Skip to contentSkip to conversation

ASoC: rk817: fix a warning in rk817_probe()

PATCH Applied Chris Morgan 2 participants 2 messages Jun 1, 2021 – Jun 2, 2021

Subsystems (3)
Sound ASoC Arm Rockchip
lore
Share & tools
lore

Chris Morgan

author
#0 lore raw

PATCH 1/1 ASoC: rk817: fix a warning in rk817_probe()

From: Chris Morgan <[email protected]>

The return value of snd_soc_component_write() is stored but not evaluated and this results in a warning when W=1 is set. Stop storing the return value to be consistent with all other calls of snd_soc_component_write() and to remove the warning.

Fixes 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
Signed-off-by Chris Morgan <[email protected]>
---
 sound/soc/codecs/rk817_codec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/rk817_codec.c +1 -2
index 17e672b85ee5..fd3a5ba034a9 100644
@@ -415,12 +415,11 @@ static int rk817_probe(struct snd_soc_component *component)
 {
 	struct rk817_codec_priv *rk817 = snd_soc_component_get_drvdata(component);
 	struct rk808 *rk808 = dev_get_drvdata(component->dev->parent);
-	int ret;
 
 	snd_soc_component_init_regmap(component, rk808->regmap);
 	rk817->component = component;
 
-	ret = snd_soc_component_write(component, RK817_CODEC_DTOP_LPT_SRST, 0x40);
+	snd_soc_component_write(component, RK817_CODEC_DTOP_LPT_SRST, 0x40);
 
 	rk817_init(component);
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 7 lines · Chris Morgan

From: Chris Morgan <[email protected]>

The return value of snd_soc_component_write() is stored but not evaluated and this results in a warning when W=1 is set. Stop storing the return value to be consistent with all other calls of snd_soc_component_write() and to remove the warning.

Quoted 6 lines
Fixes 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")
Signed-off-by Chris Morgan <[email protected]>
---
 sound/soc/codecs/rk817_codec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

Mark, I'll send out another PR shortly.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog