scsi: qedi: use DEVICE_ATTR_RO macro
Subsystems (2)
PATCH 1/1 scsi: qedi: use DEVICE_ATTR_RO macro
Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes the code a bit shorter and easier to read.
Signed-off-by Zhen Lei <[email protected]>
--- drivers/scsi/qedi/qedi_sysfs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/scsi/qedi/qedi_sysfs.c +7 -7
@@ -16,9 +16,9 @@ static inline struct qedi_ctx *qedi_dev_to_hba(struct device *dev)return iscsi_host_priv (shost); } -static ssize_t qedi_show_port_state (struct device *dev, -struct device_attribute *attr, -char *buf) +static ssize_t port_state_show (struct device *dev, +struct device_attribute *attr, +char *buf) {struct qedi_ctx *qedi =qedi_dev_to_hba (dev);
@@ -28,8 +28,8 @@ static ssize_t qedi_show_port_state(struct device *dev,return sprintf (buf,"Linkdown\n" ); } -static ssize_t qedi_show_speed (struct device *dev, -struct device_attribute *attr,char *buf) +static ssize_t speed_show (struct device *dev, +struct device_attribute *attr,char *buf) {struct qedi_ctx *qedi =qedi_dev_to_hba (dev);struct qed_link_output if_link;
@@ -39,8 +39,8 @@ static ssize_t qedi_show_speed(struct device *dev,return sprintf (buf,"%d Gbit\n" , if_link.speed /1000 ); } -static DEVICE_ATTR(port_state, 0444, qedi_show_port_state, NULL); -static DEVICE_ATTR(speed, 0444, qedi_show_speed, NULL); +static DEVICE_ATTR_RO (port_state); +static DEVICE_ATTR_RO (speed);struct device_attribute *qedi_shost_attrs[] = { &dev_attr_port_state,
Signature · 1 line
2.26.0.106.g9fadedd