Skip to contentSkip to conversation

net/ice: fix wrong FDIR flow type for IPv4 fragment

PATCH Applied Ting Xu 2 participants 2 messages Jun 2, 2021 – Jun 7, 2021 Network drivers

lore
Share & tools
lore

Ting Xu

author
#0 lore raw

PATCH 1/1 net/ice: fix wrong FDIR flow type for IPv4 fragment

When creating FDIR rule and parsing the pattern, if IPv4 fragment type is detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with other FDIR rules for IPv4 other type.

Fixes b7e8781de768 ("net/ice: support flow director for IP fragment packet")
---
 drivers/net/ice/ice_fdir_filter.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ice/ice_fdir_filter.c +1 -0
index 092c704503..5cba56918a 100644
@@ -1780,6 +1780,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
 				 * ethertype, if the spec is for all valid
 				 * packet id, set ethertype into input set.
 				 */
+				flow_type = ICE_FLTR_PTYPE_FRAG_IPV4;
 				*input_set |= ICE_INSET_ETHERTYPE;
 				input_set_o |= ICE_INSET_ETHERTYPE;
 			} else if (ipv4_mask->hdr.packet_id == UINT16_MAX) {
Signature · 1 line
2.17.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 15 lines

-----Original Message-----
From: Xu, Ting <[email protected]>
Sent: Wednesday, June 2, 2021 4:21 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>; Xu, Ting <[email protected]>; [email protected]
Subject: [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment

When creating FDIR rule and parsing the pattern, if IPv4 fragment type is detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with other FDIR rules for IPv4 other type.

Quoted 4 lines
Fixes b7e8781de768 ("net/ice: support flow director for IP fragment packet")

Applied to dpdk-next-net-intel.

Thanks
Qi