mm, tracing: Unify PFN format strings
Subsystems (6)
PATCH 1/1 mm, tracing: Unify PFN format strings
Some trace event formats print PFNs as hex while others print them as decimal. This is rather annoying when attempting to grep through traces to understand what's going on with a particular page.
$ git grep -ho 'pfn=[0x%lu]\+' include/trace/events/ | sort | uniq -c
11 pfn=0x%lx
12 pfn=%lu
2 pfn=%lxPrinting as hex is in the majority in the trace events, and all the normal printks in mm/ also print PFNs as hex, so change all the PFN formats in the trace events to use 0x%lx.
Signed-off-by Vincent Whitchurch <[email protected]>
--- include/trace/events/cma.h | 4 ++-- include/trace/events/filemap.h | 2 +- include/trace/events/kmem.h | 12 ++++++------ include/trace/events/page_pool.h | 4 ++-- include/trace/events/pagemap.h | 4 ++-- include/trace/events/vmscan.h | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-)
include/trace/events/cma.h +2 -2
@@ -31,7 +31,7 @@ DECLARE_EVENT_CLASS(cma_alloc_class, __entry->align = align; ), - TP_printk("name=%s pfn=%lx page=%p count=%lu align=%u", + TP_printk("name=%s pfn=0x%lx page=%p count=%lu align=%u", __get_str(name), __entry->pfn, __entry->page,
@@ -60,7 +60,7 @@ TRACE_EVENT(cma_release, __entry->count = count; ), - TP_printk("name=%s pfn=%lx page=%p count=%lu", + TP_printk("name=%s pfn=0x%lx page=%p count=%lu", __get_str(name), __entry->pfn, __entry->page,
include/trace/events/filemap.h +1 -1
@@ -36,7 +36,7 @@ DECLARE_EVENT_CLASS(mm_filemap_op_page_cache, __entry->s_dev = page->mapping->host->i_rdev; ), - TP_printk("dev %d:%d ino %lx page=%p pfn=%lu ofs=%lu", + TP_printk("dev %d:%d ino %lx page=%p pfn=0x%lx ofs=%lu", MAJOR(__entry->s_dev), MINOR(__entry->s_dev), __entry->i_ino, pfn_to_page(__entry->pfn),
include/trace/events/kmem.h +6 -6
@@ -173,7 +173,7 @@ TRACE_EVENT(mm_page_free, __entry->order = order; ), -TP_printk ("page=%p pfn=%lu order=%d" , +TP_printk ("page=%p pfn=0x%lx order=%d" ,pfn_to_page (__entry->pfn), __entry->pfn, __entry->order)
@@ -193,7 +193,7 @@ TRACE_EVENT(mm_page_free_batched, __entry->pfn =page_to_pfn (page); ), -TP_printk ("page=%p pfn=%lu order=0" , +TP_printk ("page=%p pfn=0x%lx order=0" ,pfn_to_page (__entry->pfn), __entry->pfn) );
@@ -219,7 +219,7 @@ TRACE_EVENT(mm_page_alloc, __entry->migratetype = migratetype; ), - TP_printk("page=%p pfn=%lu order=%d migratetype=%d gfp_flags=%s", + TP_printk("page=%p pfn=0x%lx order=%d migratetype=%d gfp_flags=%s", __entry->pfn != -1UL ? pfn_to_page(__entry->pfn) : NULL, __entry->pfn != -1UL ? __entry->pfn : 0, __entry->order,
@@ -245,7 +245,7 @@ DECLARE_EVENT_CLASS(mm_page, __entry->migratetype = migratetype; ), - TP_printk("page=%p pfn=%lu order=%u migratetype=%d percpu_refill=%d", + TP_printk("page=%p pfn=0x%lx order=%u migratetype=%d percpu_refill=%d", __entry->pfn != -1UL ? pfn_to_page(__entry->pfn) : NULL, __entry->pfn != -1UL ? __entry->pfn : 0, __entry->order,
@@ -278,7 +278,7 @@ TRACE_EVENT(mm_page_pcpu_drain, __entry->migratetype = migratetype; ), -TP_printk ("page=%p pfn=%lu order=%d migratetype=%d" , +TP_printk ("page=%p pfn=0x%lx order=%d migratetype=%d" ,pfn_to_page (__entry->pfn), __entry->pfn, __entry->order, __entry->migratetype) );
@@ -312,7 +312,7 @@ TRACE_EVENT(mm_page_alloc_extfrag, get_pageblock_migratetype(page)); ), - TP_printk("page=%p pfn=%lu alloc_order=%d fallback_order=%d pageblock_order=%d alloc_migratetype=%d fallback_migratetype=%d fragmenting=%d change_ownership=%d", + TP_printk("page=%p pfn=0x%lx alloc_order=%d fallback_order=%d pageblock_order=%d alloc_migratetype=%d fallback_migratetype=%d fragmenting=%d change_ownership=%d", pfn_to_page(__entry->pfn), __entry->pfn, __entry->alloc_order,
include/trace/events/page_pool.h +2 -2
@@ -60,7 +60,7 @@ TRACE_EVENT(page_pool_state_release, __entry->pfn =page_to_pfn (page); ), -TP_printk ("page_pool=%p page=%p pfn=%lu release=%u" , +TP_printk ("page_pool=%p page=%p pfn=0x%lx release=%u" , __entry->pool, __entry->page, __entry->pfn, __entry->release) );
@@ -85,7 +85,7 @@ TRACE_EVENT(page_pool_state_hold, __entry->pfn =page_to_pfn (page); ), -TP_printk ("page_pool=%p page=%p pfn=%lu hold=%u" , +TP_printk ("page_pool=%p page=%p pfn=0x%lx hold=%u" , __entry->pool, __entry->page, __entry->pfn, __entry->hold) );
include/trace/events/pagemap.h +2 -2
@@ -46,7 +46,7 @@ TRACE_EVENT(mm_lru_insertion, ),/* Flag format is based on page-types.c formatting for pagemap */ - TP_printk("page=%p pfn=%lu lru=%d flags=%s%s%s%s%s%s", + TP_printk("page=%p pfn=0x%lx lru=%d flags=%s%s%s%s%s%s", __entry->page, __entry->pfn, __entry->lru,
@@ -75,7 +75,7 @@ TRACE_EVENT(mm_lru_activate, ),/* Flag format is based on page-types.c formatting for pagemap */ -TP_printk ("page=%p pfn=%lu" , __entry->page, __entry->pfn) +TP_printk ("page=%p pfn=0x%lx" , __entry->page, __entry->pfn) );
include/trace/events/vmscan.h +1 -1
@@ -330,7 +330,7 @@ TRACE_EVENT(mm_vmscan_writepage, page_is_file_lru(page)); ), -TP_printk ("page=%p pfn=%lu flags=%s" , +TP_printk ("page=%p pfn=0x%lx flags=%s" ,pfn_to_page (__entry->pfn), __entry->pfn,show_reclaim_flags (__entry->reclaim_flags))
Signature · 1 line
2.28.0