drm/mediatek: remove redundant error log print
Subsystems (3)
PATCH 1/1 drm/mediatek: remove redundant error log print
Fix coccicheck warning:
drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is redundant because platform_get_irq() already prints an error.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/mediatek/mtk_dsi.c +1 -3
@@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, irq_num, mtk_dsi_irq,IRQF_TRIGGER_NONE ,dev_name (&pdev->dev), dsi); -if (ret) { -dev_err (&pdev->dev,"failed to request mediatek dsi irq\n" ); +if (ret) goto err_unregister_host; - }init_waitqueue_head (&dsi->irq_wait_queue);
Signature · 1 line
2.31.0
Chun-Kuang Hu
maintainerHi, Bernard:
Bernard Zhao <[email protected]> 於 2021年6月3日 週四 下午7:15寫道:
Quoted 15 lines
Fix coccicheck warning:
drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is redundant becauseplatform_get_irq()already prints an error.Signed-off-by Bernard Zhao <[email protected]>--- drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/mediatek/mtk_dsi.c +0
-0
drivers/gpu/drm/mediatek/mtk_dsi.c static int mtk_dsi_probe(struct platform_device *pdev) · line 1084
Quoted 3 lines
drivers/gpu/drm/mediatek/mtk_dsi.c +0
-0@@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, irq_num, mtk_dsi_irq,IRQF_TRIGGER_NONE ,dev_name (&pdev->dev), dsi);
devm_request_irq() would have below call stack to allocate memory. When allocate memory fail, it would not print any error message, doesn't it?
devm_request_irq() -> devm_request_threaded_irq() -> devres_alloc() -> devres_alloc_node() -> alloc_dr() -> kmalloc_node_track_caller()
Regards,
Chun-Kuang.
Quoted 11 lines
drivers/gpu/drm/mediatek/mtk_dsi.c +1
-4-if (ret) { -dev_err (&pdev->dev,"failed to request mediatek dsi irq\n" ); +if (ret) goto err_unregister_host; - }init_waitqueue_head (&dsi->irq_wait_queue); --2.31.0