Skip to contentSkip to conversation

drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

PATCH Superseded Jani Nikula 3 participants 8 messages Jun 3, 2021 – Jun 9, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

Add a single point of truth for figuring out the primary/secondary crtc for bigjoiner instead of duplicating the magic pipe +/- 1 in multiple places.

Also fix the pipe validity checks to properly take non-contiguous pipes into account. The current checks may theoretically overflow i915->pipe_to_crtc_mapping[pipe], albeit with a warning, due to fused off pipes, as INTEL_NUM_PIPES() returns the actual number of pipes on the platform, and the check is for INTEL_NUM_PIPES() == pipe + 1.

Prefer primary/secondary terminology going forward.

Fixes 8a029c113b17 ("drm/i915/dp: Modify VDSC helpers to configure DSC for Bigjoiner slave")
Fixes d961eb20adb6 ("drm/i915/bigjoiner: atomic commit changes for uncompressed joiner")
Cc Animesh Manna <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Vandita Kulkarni <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++--
 drivers/gpu/drm/i915/display/intel_vdsc.c    | 42 ++++++++++++++------
 drivers/gpu/drm/i915/display/intel_vdsc.h    |  2 +
 3 files changed, 35 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +3 -4
index caf0414e0b50..1b213ed42396 100644
@@ -9603,7 +9603,6 @@ static int intel_atomic_check_bigjoiner(struct intel_atomic_state *state,
 					struct intel_crtc_state *old_crtc_state,
 					struct intel_crtc_state *new_crtc_state)
 {
-	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *slave_crtc_state, *master_crtc_state;
 	struct intel_crtc *slave, *master;
 
@@ -9619,15 +9618,15 @@ static int intel_atomic_check_bigjoiner(struct intel_atomic_state *state,
 	if (!new_crtc_state->bigjoiner)
 		return 0;
 
-	if (1 + crtc->pipe >= INTEL_NUM_PIPES(dev_priv)) {
+	slave = intel_dsc_get_bigjoiner_secondary(crtc);
+	if (!slave) {
 		DRM_DEBUG_KMS("[CRTC:%d:%s] Big joiner configuration requires "
 			      "CRTC + 1 to be used, doesn't exist\n",
 			      crtc->base.base.id, crtc->base.name);
 		return -EINVAL;
 	}
 
-	slave = new_crtc_state->bigjoiner_linked_crtc =
-		intel_get_crtc_for_pipe(dev_priv, crtc->pipe + 1);
+	new_crtc_state->bigjoiner_linked_crtc = slave;
 	slave_crtc_state = intel_atomic_get_crtc_state(&state->base, slave);
 	master = crtc;
 	if (IS_ERR(slave_crtc_state))
drivers/gpu/drm/i915/display/intel_vdsc.c +30 -12

64 lines not on this page · raw message

drivers/gpu/drm/i915/display/intel_vdsc.h +2 -0
index fe4d45561253..da95944f4de2 100644
@@ -22,5 +22,7 @@ void intel_uncompressed_joiner_get_config(struct intel_crtc_state *crtc_state);
 void intel_dsc_get_config(struct intel_crtc_state *crtc_state);
 enum intel_display_power_domain
 intel_dsc_power_domain(const struct intel_crtc_state *crtc_state);
+struct intel_crtc *intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc);
+struct intel_crtc *intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc);
 
 #endif /* __INTEL_VDSC_H__ */
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915/dsc: use crtc index for bigjoiner primary/secondary crtc

Pipe numbering isn't guaranteed to be contiguous; there may be fused off pipes in the middle. The current bigjoiner primary/secondary crtc lookup with pipe +/- 1 does not take this into account, and may fail unexpectedly. Fixing this while using pipe numbering gets complicated.

Switch to using crtc index +/- 1 instead. They are contiguous, and the crtc lookup neatly handles overflows and underflows. The performance penalty from the crtc list lookup is neglible.

Fixes 8a029c113b17 ("drm/i915/dp: Modify VDSC helpers to configure DSC for Bigjoiner slave")
Fixes d961eb20adb6 ("drm/i915/bigjoiner: atomic commit changes for uncompressed joiner")
Cc Animesh Manna <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Vandita Kulkarni <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_vdsc.c | 31 +++++++++++------------
 1 file changed, 15 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +15 -16
index 1fd81bd3ea09..1d757b040bce 100644
@@ -1106,30 +1106,29 @@ static i915_reg_t dss_ctl2_reg(const struct intel_crtc_state *crtc_state)
 	return is_pipe_dsc(crtc_state) ? ICL_PIPE_DSS_CTL2(pipe) : DSS_CTL2;
 }
 
-struct intel_crtc *
-intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
+static struct intel_crtc *
+get_linked_crtc(const struct intel_crtc *crtc, int index)
 {
-	struct drm_i915_private *i915 = to_i915(primary_crtc->base.dev);
-	enum pipe pipe = primary_crtc->pipe + 1;
+	struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+	struct intel_crtc *linked_crtc;
 
-	if (drm_WARN_ON(&i915->drm, pipe >= I915_MAX_PIPES ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	linked_crtc = to_intel_crtc(drm_crtc_from_index(&i915->drm, index));
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+	drm_WARN_ON(&i915->drm, !linked_crtc);
+
+	return linked_crtc;
 }
 
 struct intel_crtc *
-intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
 {
-	struct drm_i915_private *i915 = to_i915(secondary_crtc->base.dev);
-	enum pipe pipe = secondary_crtc->pipe - 1;
-
-	if (drm_WARN_ON(&i915->drm, pipe <= INVALID_PIPE ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	return get_linked_crtc(primary_crtc, primary_crtc->base.index + 1);
+}
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+struct intel_crtc *
+intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+{
+	return get_linked_crtc(secondary_crtc, secondary_crtc->base.index - 1);
 }
 
 void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsc: use crtc index for bigjoiner primary/secondary crtc

Quoted 4 lines · Jani Nikula

Pipe numbering isn't guaranteed to be contiguous; there may be fused off pipes in the middle. The current bigjoiner primary/secondary crtc lookup with pipe +/- 1 does not take this into account, and may fail unexpectedly. Fixing this while using pipe numbering gets complicated.

This is broken; pipes need to be contiguous for big joiner regardless of whether pipes have been fused off.

BR,
Jani.

Quoted 65 lines

Switch to using crtc index +/- 1 instead. They are contiguous, and the crtc lookup neatly handles overflows and underflows. The performance penalty from the crtc list lookup is neglible.

Fixes 8a029c113b17 ("drm/i915/dp: Modify VDSC helpers to configure DSC for Bigjoiner slave")
Fixes d961eb20adb6 ("drm/i915/bigjoiner: atomic commit changes for uncompressed joiner")
Cc Animesh Manna <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Vandita Kulkarni <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_vdsc.c | 31 +++++++++++------------
 1 file changed, 15 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +15 -16
index 1fd81bd3ea09..1d757b040bce 100644
@@ -1106,30 +1106,29 @@ static i915_reg_t dss_ctl2_reg(const struct intel_crtc_state *crtc_state)
 	return is_pipe_dsc(crtc_state) ? ICL_PIPE_DSS_CTL2(pipe) : DSS_CTL2;
 }
 
-struct intel_crtc *
-intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
+static struct intel_crtc *
+get_linked_crtc(const struct intel_crtc *crtc, int index)
 {
-	struct drm_i915_private *i915 = to_i915(primary_crtc->base.dev);
-	enum pipe pipe = primary_crtc->pipe + 1;
+	struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+	struct intel_crtc *linked_crtc;
 
-	if (drm_WARN_ON(&i915->drm, pipe >= I915_MAX_PIPES ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	linked_crtc = to_intel_crtc(drm_crtc_from_index(&i915->drm, index));
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+	drm_WARN_ON(&i915->drm, !linked_crtc);
+
+	return linked_crtc;
 }
 
 struct intel_crtc *
-intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
 {
-	struct drm_i915_private *i915 = to_i915(secondary_crtc->base.dev);
-	enum pipe pipe = secondary_crtc->pipe - 1;
-
-	if (drm_WARN_ON(&i915->drm, pipe <= INVALID_PIPE ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	return get_linked_crtc(primary_crtc, primary_crtc->base.index + 1);
+}
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+struct intel_crtc *
+intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+{
+	return get_linked_crtc(secondary_crtc, secondary_crtc->base.index - 1);
 }
 
 void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state)
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsc: use crtc index for bigjoiner primary/secondary crtc

Quoted 8 lines · Jani Nikula
Quoted 4 lines · Jani Nikula

Pipe numbering isn't guaranteed to be contiguous; there may be fused off pipes in the middle. The current bigjoiner primary/secondary crtc lookup with pipe +/- 1 does not take this into account, and may fail unexpectedly. Fixing this while using pipe numbering gets complicated.

This is broken; pipes need to be contiguous for big joiner regardless of whether pipes have been fused off.

Really meant "adjacent", but you get the point.

Quoted 69 lines

BR,
Jani.

Quoted 65 lines

Switch to using crtc index +/- 1 instead. They are contiguous, and the crtc lookup neatly handles overflows and underflows. The performance penalty from the crtc list lookup is neglible.

Fixes 8a029c113b17 ("drm/i915/dp: Modify VDSC helpers to configure DSC for Bigjoiner slave")
Fixes d961eb20adb6 ("drm/i915/bigjoiner: atomic commit changes for uncompressed joiner")
Cc Animesh Manna <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Vandita Kulkarni <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_vdsc.c | 31 +++++++++++------------
 1 file changed, 15 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +15 -16
index 1fd81bd3ea09..1d757b040bce 100644
@@ -1106,30 +1106,29 @@ static i915_reg_t dss_ctl2_reg(const struct intel_crtc_state *crtc_state)
 	return is_pipe_dsc(crtc_state) ? ICL_PIPE_DSS_CTL2(pipe) : DSS_CTL2;
 }
 
-struct intel_crtc *
-intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
+static struct intel_crtc *
+get_linked_crtc(const struct intel_crtc *crtc, int index)
 {
-	struct drm_i915_private *i915 = to_i915(primary_crtc->base.dev);
-	enum pipe pipe = primary_crtc->pipe + 1;
+	struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+	struct intel_crtc *linked_crtc;
 
-	if (drm_WARN_ON(&i915->drm, pipe >= I915_MAX_PIPES ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	linked_crtc = to_intel_crtc(drm_crtc_from_index(&i915->drm, index));
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+	drm_WARN_ON(&i915->drm, !linked_crtc);
+
+	return linked_crtc;
 }
 
 struct intel_crtc *
-intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+intel_dsc_get_bigjoiner_secondary(const struct intel_crtc *primary_crtc)
 {
-	struct drm_i915_private *i915 = to_i915(secondary_crtc->base.dev);
-	enum pipe pipe = secondary_crtc->pipe - 1;
-
-	if (drm_WARN_ON(&i915->drm, pipe <= INVALID_PIPE ||
-			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
-		return NULL;
+	return get_linked_crtc(primary_crtc, primary_crtc->base.index + 1);
+}
 
-	return intel_get_crtc_for_pipe(i915, pipe);
+struct intel_crtc *
+intel_dsc_get_bigjoiner_primary(const struct intel_crtc *secondary_crtc)
+{
+	return get_linked_crtc(secondary_crtc, secondary_crtc->base.index - 1);
 }
 
 void intel_uncompressed_joiner_enable(const struct intel_crtc_state *crtc_state)
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc
URL : https://patchwork.freedesktop.org/series/90936/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1893:21:    expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1893:21:    got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc
URL : https://patchwork.freedesktop.org/series/90936/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10164 -> Patchwork_20271
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/index.html

Known issues
------------

Here are the changes found in Patchwork_20271 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#3487])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-tgl-u2/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [SKIP][3] ([fdo#109271]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-kbl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-kbl-guc/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [DMESG-FAIL][5] ([i915#3462]) -> [INCOMPLETE][6] ([i915#3462])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-cfl-8109u/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-cfl-8109u/igt@i915_selftest@[email protected]
- fi-bsw-nick: [INCOMPLETE][7] ([i915#2782] / [i915#2940] / [i915#3462]) -> [DMESG-FAIL][8] ([i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-bsw-nick/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-bsw-nick/igt@i915_selftest@[email protected]
- fi-icl-u2: [DMESG-FAIL][9] ([i915#3462]) -> [INCOMPLETE][10] ([i915#2782] / [i915#3462])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-icl-u2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-icl-u2/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: [FAIL][11] ([i915#1436] / [i915#3363]) -> [FAIL][12] ([i915#1436] / [i915#2426] / [i915#3363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-skl-6600u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-skl-6600u/igt@[email protected]
- fi-cfl-8109u: [FAIL][13] ([i915#2426] / [i915#3363]) -> [FAIL][14] ([i915#3363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-cfl-8109u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-cfl-8109u/igt@[email protected]
- fi-icl-u2: [FAIL][15] ([i915#2426] / [i915#2782] / [i915#3363]) -> [FAIL][16] ([i915#2782] / [i915#3363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-icl-u2/igt@[email protected]
- fi-kbl-soraka: [FAIL][17] ([i915#1436] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#2426] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-kbl-soraka/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-kbl-soraka/igt@[email protected]
- fi-kbl-guc: [FAIL][19] ([i915#1436] / [i915#3363]) -> [FAIL][20] ([i915#1436] / [i915#2426] / [i915#3363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-kbl-guc/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-kbl-guc/igt@[email protected]
- fi-skl-guc: [FAIL][21] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][22] ([i915#1436] / [i915#3363])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/fi-skl-guc/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/fi-skl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3240]: https://gitlab.freedesktop.org/drm/intel/issues/3240
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#3487]: https://gitlab.freedesktop.org/drm/intel/issues/3487

Participating hosts (46 -> 42)
------------------------------

Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* Linux: CI_DRM_10164 -> Patchwork_20271

CI-20190529: 20190529
CI_DRM_10164: 53e8a7ec483c309e674df59af64c19a215ab3329 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6098: 1fbc1e7d602f96a7f4e2b95057eef994656b8e74 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20271: 55dbda1efd0750df701347dce518f42cb53bd8d6 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

55dbda1efd07 drm/i915/dsc: use crtc index for bigjoiner primary/secondary crtc 7653e05f3d36 drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/2
#6 lore raw
In reply to Jani Nikula
Quoted 23 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Thursday, June 3, 2021 5:59 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Manna, Animesh <[email protected]>; Navare, Manasi D <[email protected]>; Kulkarni, Vandita <[email protected]>
Subject: [PATCH 1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

Add a single point of truth for figuring out the primary/secondary crtc for bigjoiner instead of duplicating the magic pipe +/- 1 in multiple places.

Also fix the pipe validity checks to properly take non-contiguous pipes into account. The current checks may theoretically overflow i915->pipe_to_crtc_mapping[pipe], albeit with a warning, due to fused off pipes, as INTEL_NUM_PIPES() returns the actual number of pipes on the platform, and the check is for INTEL_NUM_PIPES() == pipe + 1.

Prefer primary/secondary terminology going forward.

Quoted 8 lines
Fixes 8a029c113b17 ("drm/i915/dp: Modify VDSC helpers to configure DSC for

Bigjoiner slave")

Fixes d961eb20adb6 ("drm/i915/bigjoiner: atomic commit changes for

uncompressed joiner")

Cc Animesh Manna <[email protected]>
Cc Manasi Navare <[email protected]>
Cc Vandita Kulkarni <[email protected]>

Changes look good to me.

Quoted 138 lines
---
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++--
 drivers/gpu/drm/i915/display/intel_vdsc.c    | 42 ++++++++++++++------
 drivers/gpu/drm/i915/display/intel_vdsc.h    |  2 +
 3 files changed, 35 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -2
index caf0414e0b50..1b213ed42396 100644
@@ -9603,7 +9603,6 @@ static int intel_atomic_check_bigjoiner(struct
 intel_atomic_state *state,
 					struct intel_crtc_state *old_crtc_state,
 					struct intel_crtc_state
 *new_crtc_state)  {
-	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
 	struct intel_crtc_state *slave_crtc_state, *master_crtc_state;
 	struct intel_crtc *slave, *master;
@@ -9619,15 +9618,15 @@ static int intel_atomic_check_bigjoiner(struct
 intel_atomic_state *state,
 	if (!new_crtc_state->bigjoiner)
 		return 0;
 
-	if (1 + crtc->pipe >= INTEL_NUM_PIPES(dev_priv)) {
+	slave = intel_dsc_get_bigjoiner_secondary(crtc);
+	if (!slave) {
 		DRM_DEBUG_KMS("[CRTC:%d:%s] Big joiner configuration

requires "

drivers/gpu/drm/i915/display/intel_display.c +1 -2
 			      "CRTC + 1 to be used, doesn't exist\n",
 			      crtc->base.base.id, crtc->base.name);
 		return -EINVAL;
 	}
 
-	slave = new_crtc_state->bigjoiner_linked_crtc =
-		intel_get_crtc_for_pipe(dev_priv, crtc->pipe + 1);
+	new_crtc_state->bigjoiner_linked_crtc = slave;
 	slave_crtc_state = intel_atomic_get_crtc_state(&state->base, slave);
 	master = crtc;
 	if (IS_ERR(slave_crtc_state))
drivers/gpu/drm/i915/display/intel_vdsc.c +30 -12
index 19cd9531c115..1fd81bd3ea09 100644
@@ -1106,6 +1106,32 @@ static i915_reg_t dss_ctl2_reg(const struct
 intel_crtc_state *crtc_state)
 	return is_pipe_dsc(crtc_state) ? ICL_PIPE_DSS_CTL2(pipe) : DSS_CTL2;  }
 
+struct intel_crtc *
+intel_dsc_get_bigjoiner_secondary(const struct intel_crtc
+*primary_crtc) {
+	struct drm_i915_private *i915 = to_i915(primary_crtc->base.dev);
+	enum pipe pipe = primary_crtc->pipe + 1;
+
+	if (drm_WARN_ON(&i915->drm, pipe >= I915_MAX_PIPES ||
+			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
+		return NULL;
+
+	return intel_get_crtc_for_pipe(i915, pipe); }
+
+struct intel_crtc *
+intel_dsc_get_bigjoiner_primary(const struct intel_crtc
+*secondary_crtc) {
+	struct drm_i915_private *i915 = to_i915(secondary_crtc->base.dev);
+	enum pipe pipe = secondary_crtc->pipe - 1;
+
+	if (drm_WARN_ON(&i915->drm, pipe <= INVALID_PIPE ||
+			!(INTEL_INFO(i915)->pipe_mask & BIT(pipe))))
+		return NULL;
+
+	return intel_get_crtc_for_pipe(i915, pipe); }
+
 void intel_uncompressed_joiner_enable(const struct intel_crtc_state
 *crtc_state)  {
 	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
@@ -1178,15 +1204,11 @@ void intel_uncompressed_joiner_get_config(struct
 intel_crtc_state *crtc_state)
 	dss_ctl1 = intel_de_read(dev_priv, dss_ctl1_reg(crtc_state));
 	if (dss_ctl1 & UNCOMPRESSED_JOINER_MASTER) {
 		crtc_state->bigjoiner = true;
-		if (!WARN_ON(INTEL_NUM_PIPES(dev_priv) == crtc->pipe + 1))
-			crtc_state->bigjoiner_linked_crtc =
-				intel_get_crtc_for_pipe(dev_priv, crtc->pipe +
 1);
+		crtc_state->bigjoiner_linked_crtc =
+intel_dsc_get_bigjoiner_secondary(crtc);
 	} else if (dss_ctl1 & UNCOMPRESSED_JOINER_SLAVE) {
 		crtc_state->bigjoiner = true;
 		crtc_state->bigjoiner_slave = true;
-		if (!WARN_ON(crtc->pipe == PIPE_A))
-			crtc_state->bigjoiner_linked_crtc =
-				intel_get_crtc_for_pipe(dev_priv, crtc->pipe -
 1);
+		crtc_state->bigjoiner_linked_crtc =
+intel_dsc_get_bigjoiner_primary(crtc);
 	}
 }
@@ -1224,13 +1246,9 @@ void intel_dsc_get_config(struct intel_crtc_state
 *crtc_state)
 
 		if (!(dss_ctl1 & MASTER_BIG_JOINER_ENABLE)) {
 			crtc_state->bigjoiner_slave = true;
-			if (!WARN_ON(crtc->pipe == PIPE_A))
-				crtc_state->bigjoiner_linked_crtc =
-					intel_get_crtc_for_pipe(dev_priv, crtc-
 >pipe - 1);
+			crtc_state->bigjoiner_linked_crtc =
+intel_dsc_get_bigjoiner_primary(crtc);
 		} else {
-			if (!WARN_ON(INTEL_NUM_PIPES(dev_priv) == crtc-
 >pipe + 1))
-				crtc_state->bigjoiner_linked_crtc =
-					intel_get_crtc_for_pipe(dev_priv, crtc-
Quoted 1 line

pipe + 1);

drivers/gpu/drm/i915/display/intel_vdsc.c +2 -0
+			crtc_state->bigjoiner_linked_crtc =
+intel_dsc_get_bigjoiner_secondary(crtc);
 		}
 	}
drivers/gpu/drm/i915/display/intel_vdsc.h +0 -0
index fe4d45561253..da95944f4de2 100644
@@ -22,5 +22,7 @@ void intel_uncompressed_joiner_get_config(struct

intel_crtc_state *crtc_state); void intel_dsc_get_config(struct intel_crtc_state *crtc_state); enum intel_display_power_domain intel_dsc_power_domain(const struct intel_crtc_state *crtc_state);

drivers/gpu/drm/i915/display/intel_vdsc.h +4 -1
+struct intel_crtc *intel_dsc_get_bigjoiner_primary(const struct
+intel_crtc *secondary_crtc); struct intel_crtc
+*intel_dsc_get_bigjoiner_secondary(const struct intel_crtc
+*primary_crtc);
 
 #endif /* __INTEL_VDSC_H__ */
--
Quoted 1 line

2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary crtc
URL : https://patchwork.freedesktop.org/series/90936/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10164_full -> Patchwork_20271_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_20271_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl3/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-snb6/igt@[email protected]

* igt@gem_ctx_ringsize@active@bcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][3] ([i915#3316])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@gem_ctx_ringsize@[email protected]

* igt@gem_ctx_shared@q-in-order:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271]) +249 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-snb5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][5] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl1/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][6] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl7/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-tglb3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb6/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][11] -> [SKIP][12] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl2/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-glk6/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-glk4/igt@gem_exec_fair@[email protected]
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2849])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb1/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@gem_exec_fair@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][17] ([i915#2658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl1/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#3297])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][20] ([i915#2724])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-snb5/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][21] ([i915#3318])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl4/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#454])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][23] ([i915#2782])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-snb6/igt@i915_selftest@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271]) +125 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl7/igt@[email protected]

* igt@kms_big_joiner@basic:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#2705])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2705])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl7/igt@[email protected]

* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +16 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-snb5/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +7 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +12 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl1/igt@[email protected]

* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +17 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-max-size-offscreen:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109278]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109278] / [fdo#109279])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109274] / [fdo#109278])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#2346])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#533]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl4/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271]) +179 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#2122]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-glk1/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl3/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([i915#180]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-apl1/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#2122]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl2/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109280]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> [SKIP][46] ([fdo#109271]) +85 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#49])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl6/igt@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][49] -> [FAIL][50] ([i915#1188])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#533]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][52] ([fdo#108145] / [i915#265]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][53] -> [FAIL][54] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl1/igt@[email protected]

* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#1836])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@kms_prime@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#658]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl5/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl1/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][61] -> [SKIP][62] ([fdo#109441]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb5/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109441])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2437])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl4/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#2530])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2994]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@sysfs_clients@recycle:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl3/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2994]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][70] ([i915#2846]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl3/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@[email protected]
- shard-glk: [FAIL][72] ([i915#2846]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-glk9/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-glk6/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][74] ([i915#2842]) -> [PASS][75] +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-glk7/igt@gem_exec_fair@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][76] ([i915#2842]) -> [PASS][77] +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl3/igt@gem_exec_fair@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][78] ([i915#2842]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-tglb7/igt@gem_exec_fair@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [DMESG-WARN][80] ([i915#118] / [i915#95]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-glk6/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-glk2/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][82] ([i915#2190]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-tglb6/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-tglb3/igt@[email protected]

* igt@gem_mmap_gtt@big-copy-xy:
- shard-skl: [FAIL][84] ([i915#307]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl10/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][86] ([i915#307]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb5/igt@[email protected]

* igt@gem_vm_create@destroy-race:
- shard-tglb: [FAIL][88] ([i915#2822]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-tglb1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][90] ([i915#1436] / [i915#716]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl4/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl9/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][92] ([i915#151]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl10/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl7/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][94] ([i915#2521]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl6/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
- shard-skl: [FAIL][96] ([i915#3444]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl2/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl9/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-skl: [DMESG-WARN][98] ([i915#1982]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl9/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl3/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
- shard-skl: [FAIL][100] -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl4/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl9/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [INCOMPLETE][102] ([i915#146] / [i915#198]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl8/igt@kms_flip@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl8/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-iclb: [INCOMPLETE][104] -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb3/igt@kms_flip@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][106] ([i915#1188]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl6/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl10/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [DMESG-WARN][108] ([i915#180]) -> [PASS][109] +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl7/igt@kms_plane@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl2/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][110] ([fdo#108145] / [i915#265]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl9/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][112] ([fdo#109441]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][114] ([i915#180] / [i915#295]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl1/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl3/igt@[email protected]
- shard-apl: [DMESG-WARN][116] ([i915#180] / [i915#295]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-apl6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl3/igt@[email protected]

* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [FAIL][118] ([i915#1731]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl7/igt@sysfs_heartbeat_interval@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]

#### Warnings ####

* igt@i915_selftest@live@execlists:
- shard-iclb: [INCOMPLETE][120] ([i915#2782] / [i915#3462]) -> [DMESG-FAIL][121] ([i915#3462])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb1/igt@i915_selftest@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@i915_selftest@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: [SKIP][122] ([i915#2920]) -> [SKIP][123] ([i915#658])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb2/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl7/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl7/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl7/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl4/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl2/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-kbl1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl1/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl7/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl7/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl4/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl7/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl7/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-kbl3/igt@[email protected]
- shard-iclb: ([FAIL][142], [FAIL][143], [FAIL][144]) ([i915#2426] / [i915#2782] / [i915#3002]) -> ([FAIL][145], [FAIL][146], [FAIL][147]) ([i915#2782] / [i915#3002])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb6/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb1/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-iclb3/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb7/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb3/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-iclb2/igt@[email protected]
- shard-apl: ([FAIL][148], [FAIL][149], [FAIL][150]) ([fdo#109271] / [i915#1814] / [i915#3363]) -> ([FAIL][151], [FAIL][152], [FAIL][153]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-apl3/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-apl6/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-apl2/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl3/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl6/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/shard-apl8/igt@[email protected]
- shard-skl: ([FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158]) ([i915#1436] / [i915#1814] / [i915#2029] / [i915#2426] / [i915#3002] / [i915#3363]) -> ([FAIL][159], [FAIL][160], [FAIL][161]) ([i915#1436] / [i915#3002] / [i915#3363])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl3/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl4/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10164/shard-skl4/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20271/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx