Skip to contentSkip to conversation

net/i40e: fix using heap pointer after free

PATCH Applied [email protected] 2 participants 2 messages Jun 4, 2021 – Jun 7, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: fix using heap pointer after free

From: Dapeng Yu <[email protected]>

The original code use a heap pointer after it is freed.

Fixes 460d1679586e ("drivers/net: delete HW rings while freeing queues")
---
 drivers/net/i40e/i40e_fdir.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/i40e/i40e_fdir.c +2 -2
index ac0e09bfdd..3983122af7 100644
@@ -301,11 +301,11 @@ i40e_fdir_teardown(struct i40e_pf *pf)
 	if (err)
 		PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
 
-	i40e_dev_rx_queue_release(pf->fdir.rxq);
 	rte_eth_dma_zone_free(dev, "fdir_rx_ring", pf->fdir.rxq->queue_id);
+	i40e_dev_rx_queue_release(pf->fdir.rxq);
 	pf->fdir.rxq = NULL;
-	i40e_dev_tx_queue_release(pf->fdir.txq);
 	rte_eth_dma_zone_free(dev, "fdir_tx_ring", pf->fdir.txq->queue_id);
+	i40e_dev_tx_queue_release(pf->fdir.txq);
 	pf->fdir.txq = NULL;
 	i40e_vsi_release(vsi);
 	pf->fdir.fdir_vsi = NULL;
Signature · 1 line
2.27.0
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of [email protected]
Sent: Friday, June 4, 2021 10:02 AM
To: Xing, Beilei <[email protected]>
Cc: [email protected]; Yu, DapengX <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] net/i40e: fix using heap pointer after free

Quoted 8 lines

From: Dapeng Yu <[email protected]>

The original code use a heap pointer after it is freed.

Fixes 460d1679586e ("drivers/net: delete HW rings while freeing queues")

Applied to dpdk-next-net-intel.

Thanks
Qi