Skip to contentSkip to conversation

scsi: NCR5380: Fix fall-through warning for Clang

PATCH Applied Gustavo A. R. Silva 3 participants 4 messages Jun 4, 2021 – Jun 16, 2021

Subsystems (2)
SCSI Ncr 5380 SCSI drivers
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 scsi: NCR5380: Fix fall-through warning for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix a fall-through warning by replacing a /* fallthrough */ comment with the new pseudo-keyword macro fallthrough;

Link https://github.com/KSPP/linux/issues/115
Signed-off-by Gustavo A. R. Silva <[email protected]>

---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 22 in linux-next. This is one of those last remaining warnings.

 drivers/scsi/NCR5380.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/NCR5380.c +1 -1
index 8aa964cd54df..3baadd068768 100644
@@ -1816,7 +1816,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
 				switch (tmp) {
 				case ABORT:
 					set_host_byte(cmd, DID_ABORT);
-					/* fallthrough */
+					fallthrough;
 				case COMMAND_COMPLETE:
 					/* Accept message by clearing ACK */
 					sink = 1;
Signature · 1 line
2.27.0
Applied
#2 lore raw
In reply to Gustavo A. R. Silva

Gustavo,

Quoted 3 lines

In preparation to enable -Wimplicit-fallthrough for Clang, fix a fall-through warning by replacing a /* fallthrough */ comment with the new pseudo-keyword macro fallthrough;

Applied to 5.14/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
Applied
#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 3 lines · Gustavo A. R. Silva

In preparation to enable -Wimplicit-fallthrough for Clang, fix a fall-through warning by replacing a /* fallthrough */ comment with the new pseudo-keyword macro fallthrough;

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: NCR5380: Fix fall-through warning for Clang

      https://git.kernel.org/mkp/scsi/c/61f4f11b48f9
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering