Skip to contentSkip to conversation

layer.conf: set LAYERSERIES_COMPAT with honister

PATCH In review kai 3 participants 7 messages Jun 4, 2021 – Jun 8, 2021 1 message not in the archive

lore
Share & tools
lore

kai

author
#0 lore raw

PATCH 1/1 layer.conf: set LAYERSERIES_COMPAT with honister

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

---
 conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +1 -1
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
 # This should only be incremented on significant changes that will
 # cause compatibility issues with other layers
 LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
 LAYERDEPENDS_realtime = "core openembedded-layer"
 LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Bruce

Quoted 20 lines
---
 conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
 # This should only be incremented on significant changes that will
 # cause compatibility issues with other layers
 LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
 LAYERDEPENDS_realtime = "core openembedded-layer"
 LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--

2.17.1

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#2 lore raw
Quoted 11 lines · Bruce Ashfield
Quoted 5 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Hi Bruce,

Thanks. I have seen your commits.

But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show warning:

  WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott: length 28 exceeds maximum (25), truncating

Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch master, please?

Or it set in oe-core's layer.conf:

LAYERSERIES_CORENAMES = "hardknott honister"

we just align with it to keep the latest 2, please?

Regards,
Kai

Quoted 24 lines

Bruce

Quoted 20 lines
---
  conf/layer.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
  # This should only be incremented on significant changes that will
  # cause compatibility issues with other layers
  LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
  LAYERDEPENDS_realtime = "core openembedded-layer"
  LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--

2.17.1

Signature · 2 lines
Kai Kang
Wind River Linux
#3 lore raw
Quoted 18 lines · Kai
Quoted 11 lines · Bruce Ashfield
Quoted 5 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Hi Bruce,

Thanks. I have seen your commits.

Quoted 8 lines

But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show warning:

WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
length 28 exceeds maximum (25), truncating

Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch master, please?

Nope. It is compatible with those releases, so they need to stay. I see no valid reason to be limited to a certain number of characters.

Quoted 6 lines

Or it set in oe-core's layer.conf:

LAYERSERIES_CORENAMES = "hardknott honister"

we just align with it to keep the latest 2, please?

That is just as arbitrary, I'll keep it as-is.

Bruce

Quoted 33 lines

Regards,
Kai

Quoted 8 lines

Bruce

Quoted 5 lines
---
  conf/layer.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
  # This should only be incremented on significant changes that will
  # cause compatibility issues with other layers
  LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
  LAYERDEPENDS_realtime = "core openembedded-layer"
  LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--
Quoted 2 lines

2.17.1

--
Kai Kang
Wind River Linux

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#4 lore raw
Quoted 33 lines · Bruce Ashfield
Quoted 18 lines · Kai
Quoted 11 lines · Bruce Ashfield
Quoted 5 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Hi Bruce,

Thanks. I have seen your commits.

Quoted 8 lines

But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show warning:

WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
length 28 exceeds maximum (25), truncating

Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch master, please?

Nope. It is compatible with those releases, so they need to stay. I see no valid reason to be limited to a certain number of characters.

Quoted 1 line
Quoted 7 lines
Quoted 5 lines

Or it set in oe-core's layer.conf:

LAYERSERIES_CORENAMES = "hardknott honister"

we just align with it to keep the latest 2, please?

That is just as arbitrary, I'll keep it as-is.

I took a quick look, is this warning coming from the layer index ? That would be important information to convey when sending changes like this.

That being said, it is a longer fix to get that warning changed, and I'd rather not break the index, so I dropped to only the last two releases.

But I do recommend that the layer index be changed (if that is the cause of the warning), since we shouldn't be adapting to the index .. it should be adapting to layers.

Bruce

Quoted 42 lines

Bruce

Quoted 29 lines

Regards,
Kai

Quoted 8 lines

Bruce

Quoted 5 lines
---
  conf/layer.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
  # This should only be incremented on significant changes that will
  # cause compatibility issues with other layers
  LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
  LAYERDEPENDS_realtime = "core openembedded-layer"
  LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--
Quoted 2 lines

2.17.1

Quoted 4 lines

--
Kai Kang
Wind River Linux

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 39 lines · Bruce Ashfield via lists.yoctoproject.org
Quoted 37 lines · Bruce Ashfield
Quoted 18 lines · Kai
Quoted 11 lines · Bruce Ashfield
Quoted 5 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Hi Bruce,

Thanks. I have seen your commits.

Quoted 8 lines

But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show warning:

WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
length 28 exceeds maximum (25), truncating

Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch master, please?

Nope. It is compatible with those releases, so they need to stay. I see no valid reason to be limited to a certain number of characters.

Quoted 5 lines

Or it set in oe-core's layer.conf:

LAYERSERIES_CORENAMES = "hardknott honister"

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

we just align with it to keep the latest 2, please?

That is just as arbitrary, I'll keep it as-is.

I took a quick look, is this warning coming from the layer index ? That would be important information to convey when sending changes like this.

Apologies on this, I see in the follow up email you did mention the layerindex .. I read completely over that, and had to search up the warning myself. (my fault, not yours).

Quoted 8 lines

That being said, it is a longer fix to get that warning changed, and I'd rather not break the index, so I dropped to only the last two releases.

But I do recommend that the layer index be changed (if that is the cause of the warning), since we shouldn't be adapting to the index .. it should be adapting to layers.

This point still stands though :D

Bruce

Quoted 55 lines

Bruce

Quoted 38 lines

Bruce

Quoted 29 lines

Regards,
Kai

Quoted 8 lines

Bruce

Quoted 5 lines
---
  conf/layer.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
  # This should only be incremented on significant changes that will
  # cause compatibility issues with other layers
  LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
  LAYERDEPENDS_realtime = "core openembedded-layer"
  LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--
Quoted 2 lines

2.17.1

Quoted 4 lines

--
Kai Kang
Wind River Linux

Quoted 4 lines

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#7 lore raw
Quoted 59 lines · Bruce Ashfield
Quoted 39 lines · Bruce Ashfield via lists.yoctoproject.org
Quoted 37 lines · Bruce Ashfield
Quoted 18 lines · Kai
Quoted 11 lines · Bruce Ashfield
Quoted 5 lines · On Thu, Jun 3, 2021 at 11:06 PM <[email protected]> wrote:

From: Kai Kang <[email protected]>

Replace hardknott with honister in layer.conf which aligns with oe-core.

I had added this back in April, but apparently didn't push the change.

I also noticed that I've been updating the wrong branch with compatibility.

That should all be fixed now.

Hi Bruce,

Thanks. I have seen your commits.

Quoted 8 lines

But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show warning:

WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
length 28 exceeds maximum (25), truncating

Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch master, please?

Nope. It is compatible with those releases, so they need to stay. I see no valid reason to be limited to a certain number of characters.

Quoted 5 lines

Or it set in oe-core's layer.conf:

LAYERSERIES_CORENAMES = "hardknott honister"

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

we just align with it to keep the latest 2, please?

That is just as arbitrary, I'll keep it as-is.

I took a quick look, is this warning coming from the layer index ? That would be important information to convey when sending changes like this.

Apologies on this, I see in the follow up email you did mention the layerindex .. I read completely over that, and had to search up the warning myself. (my fault, not yours).

Quoted 5 lines

That being said, it is a longer fix to get that warning changed, and I'd rather not break the index, so I dropped to only the last two releases.

Quoted 5 lines
Quoted 3 lines

But I do recommend that the layer index be changed (if that is the cause of the warning), since we shouldn't be adapting to the index .. it should be adapting to layers.

This point still stands though :D

Created:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=14426

Layerindex should allow longer compatible version names

../Randy

Quoted 64 lines

Bruce

Quoted 55 lines

Bruce

Quoted 38 lines

Bruce

Quoted 29 lines

Regards,
Kai

Quoted 8 lines

Bruce

Quoted 5 lines
---
   conf/layer.conf | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 13 lines
conf/layer.conf +1 -2
index 007f578..8ae67ba 100644
@@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
   # This should only be incremented on significant changes that will
   # cause compatibility issues with other layers
   LAYERVERSION_realtime = "1"
-LAYERSERIES_COMPAT_realtime = "hardknott"
+LAYERSERIES_COMPAT_realtime = "honister"
   LAYERDEPENDS_realtime = "core openembedded-layer"
   LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
--
Quoted 2 lines

2.17.1

Quoted 4 lines

--
Kai Kang
Wind River Linux

Quoted 4 lines

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 2 lines
# Randy MacLeod
# Wind River Linux