Skip to contentSkip to conversation

staging: mt7621-dts: review pcie overlay in 'gbpc1' dts file

PATCH New Sergio Paracuellos 1 participant 1 message Jun 4, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: mt7621-dts: review pcie overlay in 'gbpc1' dts file

pcie node is being overlayed in 'gbpc1.dts' file requesting three gpio reset pins for each pcie port. Gnubee only needs general gpio 19 to properly reset and make all of them work. This pin is already requested in the general 'mt7621.dtsi' file as well as is the pinctrl pins. So we only need to enable the node in the overlay and all the other stuff can be safely deleted. Also, pin 8 is being requested for gpio-leds node and there was an error on boot before this changes because of pin was already assigned (EBUSY):

leds-gpio: probe of gpio-leds failed with error -16

With this changes this error has disappear and the board is properly booting without any other regression.

---
 drivers/staging/mt7621-dts/gbpc1.dts | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/mt7621-dts/gbpc1.dts +0 -6
index 7716d0efe524..b65d71686814 100644
@@ -101,12 +101,6 @@ partition@50000 {
 };
 
 &pcie {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pcie_pins>;
-
-	reset-gpios = <&gpio 19 GPIO_ACTIVE_LOW>,
-			<&gpio 8 GPIO_ACTIVE_LOW>,
-			<&gpio 7 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
Signature · 1 line
2.25.1