dt-bindings: hwlock: sun6i: Fix various warnings in binding
Subsystems (4)
RFC PATCH 1/1 dt-bindings: hwlock: sun6i: Fix various warnings in binding
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
---
Hi Wilken,
This fixes the warnings for now on linux-next, but I think the example should be including sun6i-a31-ccu.h files instead to be accurate, and those files are missing the definitions for CLK_BUS_SPINLOCK and RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.
regards
Suman
.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +4 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml# +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
@@ -36,6 +36,9 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/sun8i-a23-a33-ccu.h> + #include <dt-bindings/reset/sun8i-a23-a33-ccu.h> + hwlock@1c18000 { compatible = "allwinner,sun6i-a31-hwspinlock"; reg = <0x01c18000 0x1000>;
Signature · 1 line
2.30.1
Wilken Gottwalt
maintainerQuoted 9 lines · On Thu, 3 Jun 2021 09:42:16 -0500 Suman Anna <[email protected]> wrote:
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>---
Hi Wilken,
Quoted 8 lines
This fixes the warnings for now on linux-next, but I think the example should be including
sun6i-a31-ccu.hfiles instead to be accurate, and those files are missing the definitions forCLK_BUS_SPINLOCKandRST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.regards
Suman
Hi Suman,
thank you for fixing this. I would have fix it the same way for now, so it is fine for me. But I will keep an eye on it.
greetings,
Will
Quoted 26 lines
.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yamlindex733c3d01e56c..10e5a53e447b100644 ---a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml+++b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +3
-0@@ -36,6 +36,9 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/sun8i-a23-a33-ccu.h> + #include <dt-bindings/reset/sun8i-a23-a33-ccu.h> + hwlock@1c18000 { compatible = "allwinner,sun6i-a31-hwspinlock"; reg = <0x01c18000 0x1000>;
Quoted 18 lines · Wilken Gottwalt
Quoted 15 lines · On Thu, 3 Jun 2021 09:42:16 -0500 Suman Anna <[email protected]> wrote:
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>---
Hi Wilken,This fixes the warnings for now on linux-next, but I think the example should be including
sun6i-a31-ccu.hfiles instead to be accurate, and those files are missing the definitions forCLK_BUS_SPINLOCKandRST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.
Quoted 7 lines
Quoted 2 lines
regards
SumanHi Suman,
thank you for fixing this. I would have fix it the same way for now, so it is fine for me. But I will keep an eye on it.
Thanks Will.
Bjorn,
Do ignore the RFC tag then, and you can pick up the patch.
regards
Suman
Quoted 31 lines
greetings,
WillQuoted 26 lines
.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yamlindex733c3d01e56c..10e5a53e447b100644 ---a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml+++b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +3
-0@@ -36,6 +36,9 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/sun8i-a23-a33-ccu.h> + #include <dt-bindings/reset/sun8i-a23-a33-ccu.h> + hwlock@1c18000 { compatible = "allwinner,sun6i-a31-hwspinlock"; reg = <0x01c18000 0x1000>;
Quoted 16 lines · Suman Anna
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>---
Hi Wilken,This fixes the warnings for now on linux-next, but I think the example should be including
sun6i-a31-ccu.hfiles instead to be accurate, and those files are missing the definitions forCLK_BUS_SPINLOCKandRST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.
Quoted 5 lines
regards
Suman.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Hi Bjorn,
Quoted 17 lines · Rob Herring
Quoted 16 lines · Suman Anna
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>---
Hi Wilken,This fixes the warnings for now on linux-next, but I think the example should be including
sun6i-a31-ccu.hfiles instead to be accurate, and those files are missing the definitions forCLK_BUS_SPINLOCKandRST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.
Quoted 8 lines
Quoted 5 lines
regards
Suman.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Acked-by Rob Herring <[email protected]>
Gentle ping, can you pick up this patch and the remoteproc pas binding indentations fixes please so that linux-next is sane w.r.t these?
regards
Suman
Quoted 23 lines · Suman Anna
Hi Bjorn,
Quoted 20 lines · Rob Herring
Quoted 19 lines · Suman Anna
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>---
Hi Wilken,This fixes the warnings for now on linux-next, but I think the example should be including
sun6i-a31-ccu.hfiles instead to be accurate, and those files are missing the definitions forCLK_BUS_SPINLOCKandRST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental patch on top.regards
Suman
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
.../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Acked-by Rob Herring <[email protected]>Gentle ping, can you pick up this patch and the remoteproc pas binding indentations fixes please so that linux-next is sane w.r.t these?
Sorry, I picked up some (biological) bug and haven't been of much use the last couple of weeks. I've picked the two patches now, thank you Suman!
Regards,
Bjorn
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Quoted 8 lines · On Thu, 3 Jun 2021 09:42:16 -0500 you wrote:
The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched $id and fails to compile the example due to undefined args specifier values for clocks and resets. Fix both of these issues.
Fixes f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")Signed-off-by Suman Anna <[email protected]>[...]
Here is the summary with links:
- [RFC] dt-bindings: hwlock: sun6i: Fix various warnings in binding
https://git.kernel.org/andersson/remoteproc/c/234462bc7f23
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html