drm/amd/display: Add missing cases
Subsystems (3)
cover drm/amd/display: Add missing cases
Rev 2: Fix small typo in commit message.
PATCH 1/1 drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_111111 missing.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4 -0
@@ -6515,6 +6515,10 @@ static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_dereturn 14 ;case COLOR_DEPTH_161616 :return 16 ; +case COLOR_DEPTH_999 : +return 9 ; +case COLOR_DEPTH_111111 : +return 11 ;default :break ; }
Signature · 1 line
2.25.1
Harry Wentland
maintainerRe: [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc
Quoted 13 lines · Werner Sembach
convert_dc_color_depth_into_bpc()that converts the enumdc_color_depthto an integer had the cases forCOLOR_DEPTH_999andCOLOR_DEPTH_111111missing.Signed-off-by Werner Sembach <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_de · line 6521
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4
-0@@ -6515,6 +6515,10 @@ static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_dereturn 14 ;case COLOR_DEPTH_161616 :return 16 ; +case COLOR_DEPTH_999 : +return 9 ; +case COLOR_DEPTH_111111 : +return 11 ;
The color_depth returned by convert_color_depth_from_display_info will never return 9 or 11 bpc color depth. If we add these we should add them in all places where they're needed and test the whole sequence.
I'm a bit surprised to find DC has support for 9 bpc and 11 bpc color depth but am not sure how well tested that is.
Harry
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_de · line 6524
Quoted 4 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0default :break ; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx