Skip to contentSkip to conversation

mm/nommu: unexport do_munmap()

PATCH Applied Liam Howlett 3 participants 3 messages Jun 4, 2021 – Jun 9, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/nommu: unexport do_munmap()

do_munmap() does not take the mmap_write_lock(). vm_munmap() should be used instead.

---
 mm/nommu.c | 1 -
 1 file changed, 1 deletion(-)
mm/nommu.c +0 -1
index 0997ca38c2bd..3a93d4054810 100644
@@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
 	delete_vma(mm, vma);
 	return 0;
 }
-EXPORT_SYMBOL(do_munmap);
 
 int vm_munmap(unsigned long addr, size_t len)
 {
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Liam Howlett

do_munmap() does not take the mmap_write_lock(). vm_munmap() should be used instead.

also, do_munmap was unexported for MMU builds back in 2012 by commit 17d1587f553d.

Quoted 20 lines
---
 mm/nommu.c | 1 -
 1 file changed, 1 deletion(-)
mm/nommu.c +0 -1
index 0997ca38c2bd..3a93d4054810 100644
@@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
 	delete_vma(mm, vma);
 	return 0;
 }
-EXPORT_SYMBOL(do_munmap);
 
 int vm_munmap(unsigned long addr, size_t len)
 {
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Liam Howlett
Quoted 14 lines · Liam Howlett

do_munmap() does not take the mmap_write_lock(). vm_munmap() should be used instead.

---
  mm/nommu.c | 1 -
  1 file changed, 1 deletion(-)
mm/nommu.c +0 -0
index 0997ca38c2bd..3a93d4054810 100644

mm/nommu.c int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list · line 1506

Quoted 7 lines
mm/nommu.c +0 -1
@@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
  	delete_vma(mm, vma);
  	return 0;
  }
-EXPORT_SYMBOL(do_munmap);
 
  int vm_munmap(unsigned long addr, size_t len)
  {
Signature · 3 lines
Thanks,

David / dhildenb