drm/etnaviv: remove NULL check which is not needed
Subsystems (2)
PATCH 1/1 drm/etnaviv: remove NULL check which is not needed
NULL check before kvfree functions is not needed.
Signed-off-by Bernard Zhao <[email protected]>
--- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +1 -2
@@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)/* Don't drop the pages for imported dmabuf, as they are not * ours, just free the array we allocated: */ -if (etnaviv_obj->pages) -kvfree (etnaviv_obj->pages); +kvfree (etnaviv_obj->pages);drm_prime_gem_destroy (&etnaviv_obj->base, etnaviv_obj->sgt); }
Signature · 1 line
2.31.0
Christian Gmeiner
reviewerAm Sa., 5. Juni 2021 um 14:18 Uhr schrieb Bernard Zhao <[email protected]>:
Quoted 23 lines
NULL check before kvfree functions is not needed.
Signed-off-by Bernard Zhao <[email protected]>--- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c +1
-3@@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)/* Don't drop the pages for imported dmabuf, as they are not * ours, just free the array we allocated: */ -if (etnaviv_obj->pages) -kvfree (etnaviv_obj->pages); +kvfree (etnaviv_obj->pages);drm_prime_gem_destroy (&etnaviv_obj->base, etnaviv_obj->sgt); } --
Quoted 2 lines
2.31.0
Thanks for the patch, but there is an other one queued up in etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=7d614ab2f20503ed8766363d41f8607337571adf
Signature · 5 lines
greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy