drm/etnaviv: remove no need NULL check
Subsystems (2)
PATCH 1/1 drm/etnaviv: remove no need NULL check
NULL check before kvfree functions is not needed.
Signed-off-by Bernard Zhao <[email protected]>
--- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +4 -8
@@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds:if (ret && (out_fence_fd >=0 ))put_unused_fd (out_fence_fd); -if (stream) -kvfree (stream); -if (bos) -kvfree (bos); -if (relocs) -kvfree (relocs); -if (pmrs) -kvfree (pmrs); +kvfree (stream); +kvfree (bos); +kvfree (relocs); +kvfree (pmrs);return ret; }
Signature · 1 line
2.31.0
Christian Gmeiner
reviewerAm Sa., 5. Juni 2021 um 14:24 Uhr schrieb Bernard Zhao <[email protected]>:
Quoted 32 lines
NULL check before kvfree functions is not needed.
Signed-off-by Bernard Zhao <[email protected]>--- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +4
-9@@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds:if (ret && (out_fence_fd >=0 ))put_unused_fd (out_fence_fd); -if (stream) -kvfree (stream); -if (bos) -kvfree (bos); -if (relocs) -kvfree (relocs); -if (pmrs) -kvfree (pmrs); +kvfree (stream); +kvfree (bos); +kvfree (relocs); +kvfree (pmrs);return ret; } --
Quoted 2 lines
2.31.0
Thanks for the patch, but there is an other one queued up in etnaviv/next that fixes the same issue:
https://git.pengutronix.de/cgit/lst/linux/commit/?h=etnaviv/next&id=bdf622e0fade2cec72c948c708763378b656c01d
Signature · 5 lines
greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy