e1000e: Check the PCIm state
Subsystems (2)
PATCH 1/1 e1000e: Check the PCIm state
Complete to commit def4ec6dce393e ("e1000e: PCIm function state support") Check the PCIm state only on CSME systems. There is no point to do this check on none CSME systems.
This patch fixes a generation a false-positive warning:
"Error in exiting dmoff"
Signed-off-by Sasha Neftin <[email protected]>
--- drivers/net/ethernet/intel/e1000e/netdev.c | 24 ++++++++++++---------- 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/net/ethernet/intel/e1000e/netdev.c +13 -11
@@ -5225,18 +5225,20 @@ static void e1000_watchdog_task(struct work_struct *work)pm_runtime_resume (netdev->dev.parent);/* Checking if MAC is in DMoff state*/ - pcim_state =er32 (STATUS ); -while (pcim_state &E1000_STATUS_PCIM_STATE ) { -if (tries++ == dmoff_exit_timeout) { -e_dbg ("Error in exiting dmoff\n" ); -break ; - } -usleep_range (10000 ,20000 ); +if (er32 (FWSM ) &E1000_ICH_FWSM_FW_VALID ) { pcim_state =er32 (STATUS ); - -/* Checking if MAC exited DMoff state */ -if (!(pcim_state &E1000_STATUS_PCIM_STATE )) -e1000_phy_hw_reset (&adapter->hw); +while (pcim_state &E1000_STATUS_PCIM_STATE ) { +if (tries++ == dmoff_exit_timeout) { +e_dbg ("Error in exiting dmoff\n" ); +break ; + } +usleep_range (10000 ,20000 ); + pcim_state =er32 (STATUS ); + +/* Checking if MAC exited DMoff state */ +if (!(pcim_state &E1000_STATUS_PCIM_STATE )) +e1000_phy_hw_reset (&adapter->hw); + } }/* update snapshot of PHY registers on LSC */
Signature · 1 line
2.25.1
Fuxbrumer
PATCH 1/1 e1000e: Check the PCIm state
Quoted 11 lines · Sasha Neftin
Complete to commit
def4ec6dce393e("e1000e: PCIm function state support") Check the PCIm state only on CSME systems. There is no point to do this check on none CSME systems.
This patch fixes a generation a false-positive warning:
"Error in exiting dmoff"Signed-off-by Sasha Neftin <[email protected]>--- drivers/net/ethernet/intel/e1000e/netdev.c | 24 ++++++++++++---------- 1 file changed, 13 insertions(+), 11 deletions(-)
Tested-by Dvora Fuxbrumer <[email protected]>